#2 Don't install systemd unit files neither udev rules for Flatpak
Merged 4 years ago by elmarco. Opened 4 years ago by feborges.
rpms/ feborges/phodav disable-for-flatpak  into  master

file modified
+4 -1
@@ -71,7 +71,8 @@ 

  

  

  %build

- %meson ||  cat %_vpath_builddir/meson-logs/meson-log.txt

+ %meson %{?flatpak:-Dsystemd=disabled -Dudev=disabled} || cat %_vpath_builddir/meson-logs/meson-log.txt

+ 

  %meson_build

  

  %install
@@ -108,8 +109,10 @@ 

  %files -n spice-webdavd

  %license COPYING

  %{_sbindir}/spice-webdavd

+ %if ! 0%{?flatpak}

  /usr/lib/udev/rules.d/70-spice-webdavd.rules

  %{_unitdir}/spice-webdavd.service

+ %endif

  

  %changelog

  * Tue Feb 26 2019 Marc-André Lureau <marcandre.lureau@redhat.com> - 2.3-1

We are building Flatpaks from RPMs[0], and for these we don't want
systemd unit files nor udev rules to be installed, since Flatpak
installs files in a different prefix within a container.

The "flatpak" macro is provided by the package flatpak-rpm-macros.
It is already used in various RPMs such as spice-gtk, gedit,
file-roller.

[0] https://docs.fedoraproject.org/en-US/flatpak/tutorial/

I guess spice-webdavd doesn't make much sense in flatpak, but ok

Pull-Request has been merged by elmarco

4 years ago

It is pulled by spice-gtk in our modulemd at build time (BuildRequires: libphodav-devel).

The Boxes Flatpak (not to be confused with the RPM2Flatpak effort here) uses phodav for the Shared Folders feature and it works like a charm there.

Thanks for acting fast and all of your work!