#43 Gate on openQA update test results
Merged 2 years ago by lsm5. Opened 2 years ago by adamwill.
rpms/ adamwill/podman gate-openqa  into  rawhide

file modified
+11 -5
@@ -1,14 +1,20 @@ 

  --- !Policy

  product_versions:

    - fedora-*

- decision_context: bodhi_update_push_stable

+ decision_contexts:

+   - bodhi_update_push_stable

+   - bodhi_update_push_testing

  subject_type: koji_build

  rules:

    - !PassingTestCaseRule {test_case_name: fedora-ci.koji-build.tier0.functional}

  --- !Policy

  product_versions:

-   - fedora-*

- decision_context: bodhi_update_push_testing

- subject_type: koji_build

+   - fedora-33

+   - fedora-34

+ decision_contexts:

+   - bodhi_update_push_stable

+   - bodhi_update_push_testing

+ subject_type: bodhi_update

  rules:

-   - !PassingTestCaseRule {test_case_name: fedora-ci.koji-build.tier0.functional}

+   - !PassingTestCaseRule {test_case_name: update.podman}

+   - !PassingTestCaseRule {test_case_name: update.podman_client}

This adds a policy to gate podman updates for stable releases
on the openQA podman and podman_client tests, which will be run
on podman updates as of today. Unfortunately there is no way to
express "all versions except Rawhide" so we have to just list
the versions explicitly; this will need to be updated when
releases branch and go EOL.

Signed-off-by: Adam Williamson awilliam@redhat.com

This also simplifies the config to use multiple decision_contexts in a single policy rather than duplicating policies. This has been allowed in greenwave for some time now.

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci

Sorry, I was ignoring this because of all the test failures. Are those not important?

@santiago i'll check if any of those are something I can fix or if it's for zuul

If the test failures are unimportant, I'm fine with this. I can't review it, because I don't know anything about the magic gating.yaml format, but I totally trust @adamwill to get it right. (And we can fine-tune later if needed).

I believe the failures are basically lint fails in the package spec. The same tests would probably fail on any PR. It's been so long since they ran the logs aren't arouynd any more, though.

@adamwill do those need to be resolved before this can be merged, I don't mind merging this right away otherwise.

rebased onto b1bac7c

2 years ago

i'll merge this and we can sort out the failures after a build

@adamwill do we need this on other branches too? Could you open PRs if that's the case?

Pull-Request has been merged by lsm5

2 years ago

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci

@lsm5 that's actually a good question, and I'm not sure of the answer. The gating policy itself has to include version information so it would be sort of redundant to require it on every branch, but it may be necessary even so. I'll ask the CI team.

So I asked, and it turns out the gating policies are actually per branch. So this wasn't exactly right! Sorry about that. I'll send a few follow-ups.

@adamwill no worries, thanks for checking. Looking forward to the changes.

I've sent #44 , #45 and #46 that should clean things up...

Metadata