From cc4e6f0ef1f6a6eb95cd57def4eeb59ea4ee60ca Mon Sep 17 00:00:00 2001
From: David Kaspar [Dee'Kej] <dkaspar@redhat.com>
Date: Nov 15 2017 18:00:08 +0000
Subject: specfile: cleanup according to Fedora Packaging Guidelines


---

diff --git a/poppler-data.spec b/poppler-data.spec
index 6d4ab36..3f03ffd 100644
--- a/poppler-data.spec
+++ b/poppler-data.spec
@@ -1,47 +1,87 @@
-Summary: Encoding files 
-Name:    poppler-data
-Version: 0.4.8
-Release: 3%{?dist}
-# The cMap data files installed by the poppler-data package are
-# under the COPYING.adobe license
-# cidToUnicode, nameToUnicode and unicodeMap data files
-# are under the COPYING.gpl2 license
-# Identity-UTF16-H is GPLv3+ (from GPL ghostscript)
-License: BSD and GPLv2 and GPLv3+
-URL:     http://poppler.freedesktop.org/
-Source0: http://poppler.freedesktop.org/poppler-data-%{version}.tar.gz
-BuildArch: noarch
-BuildRequires: pkgconfig
+# =============================================================================
+
+Name:             poppler-data
+Summary:          Encoding files for use with poppler
+Version:          0.4.8
+Release:          3%{?dist}
+
+# NOTE: The licensing details are explained in COPYING file in source archive.
+License:          BSD and GPLv2
+
+URL:              https://poppler.freedesktop.org/
+Source:           https://poppler.freedesktop.org/poppler-data-%{version}.tar.gz
+
+BuildArch:        noarch
+BuildRequires:    git
+
+# =============================================================================
+
+# NOTE: 'autosetup' macro (below) uses 'git' for applying the patches:
+#       ->> All the patches should be provided in 'git format-patch' format.
+#       ->> Auxiliary repository will be created during 'fedpkg prep', you
+#           can see all the applied patches there via 'git log'.
+
+# Upstream patches -- official upstream patches released by upstream since the
+# ----------------    last rebase that are necessary for any reason:
+#Patch000: example000.patch
+
+
+# Downstream patches -- these should be always included when doing rebase:
+# ------------------
+#Patch100: example100.patch
+
+
+# Downstream patches for RHEL -- patches that we keep only in RHEL for various
+# ---------------------------    reasons, but are not enabled in Fedora:
+%if %{defined rhel} || %{defined centos}
+#Patch200: example200.patch
+%endif
+
+
+# Patches to be removed -- deprecated functionality which shall be removed at
+# ---------------------    some point in the future:
+
 
 %description
-This package consists of encoding files for poppler.  When installed,
-the encoding files enables poppler to correctly render CJK and Cyrillic 
-properly.
+This package consists of encoding files for use with poppler. The encoding
+files are optional and poppler will automatically read them if they are present.
+
+When installed, the encoding files enables poppler to correctly render both CJK
+and Cyrrilic characters properly.
+
+# === SUBPACKAGES =============================================================
+
+%package          devel
+Summary:          Devel files for %{name}
+
+Requires:         %{name} = %{version}-%{release}
+BuildRequires:    pkgconfig
 
-%package devel
-Summary: Developer files for %{name}
-Requires: %{name} = %{version}-%{release}
 %description devel
-%{summary}.
+This sub-package currently contains only pkgconfig file, which can be used with
+pkgconfig utility allowing your software to be build with poppler-data.
 
+# === BUILD INSTRUCTIONS ======================================================
 
 %prep
-%setup -q -a 1
+%autosetup -S git
 
+# NOTE: Nothing to do here - we are packaging the content only.
 %build
-# intentionally left blank
 
 %install
-make install  DESTDIR=%{buildroot} datadir=%{_datadir}
+%make_install prefix=%{_prefix}
 
+# === PACKAGING INSTRUCTIONS ==================================================
 
 %files
-%doc COPYING COPYING.adobe COPYING.gpl2 README
+%license COPYING COPYING.adobe COPYING.gpl2
 %{_datadir}/poppler/
 
 %files devel
 %{_datadir}/pkgconfig/poppler-data.pc
 
+# =============================================================================
 
 %changelog
 * Thu Nov 09 2017 David Kaspar [Dee'Kej] <dkaspar@redhat.com> - 0.4.8-3