From f5077858cc2f03a88caffec50ecc59dcea803aaf Mon Sep 17 00:00:00 2001
From: Marek Kasik <mkasik@redhat.com>
Date: Jun 15 2022 08:03:39 +0000
Subject: Don't run out of file for Hints


Resolves: #2090965

---

diff --git a/poppler-22.01.0-hints.patch b/poppler-22.01.0-hints.patch
new file mode 100644
index 0000000..8d77a54
--- /dev/null
+++ b/poppler-22.01.0-hints.patch
@@ -0,0 +1,58 @@
+From 81044c64b9ed9a10ae82a28bac753060bdfdac74 Mon Sep 17 00:00:00 2001
+From: Albert Astals Cid <aacid@kde.org>
+Date: Tue, 15 Mar 2022 15:14:32 +0100
+Subject: Hints::readTables: bail out if we run out of file when reading
+
+Fixes #1230
+
+diff --git a/poppler/Hints.cc b/poppler/Hints.cc
+index 79f04088..4707e1c6 100644
+--- a/poppler/Hints.cc
++++ b/poppler/Hints.cc
+@@ -5,7 +5,7 @@
+ // This file is licensed under the GPLv2 or later
+ //
+ // Copyright 2010, 2012, 2013 Hib Eris <hib@hiberis.nl>
+-// Copyright 2010, 2011, 2013, 2014, 2016-2019, 2021 Albert Astals Cid <aacid@kde.org>
++// Copyright 2010, 2011, 2013, 2014, 2016-2019, 2021, 2022 Albert Astals Cid <aacid@kde.org>
+ // Copyright 2010, 2013 Pino Toscano <pino@kde.org>
+ // Copyright 2013 Adrian Johnson <ajohnson@redneon.com>
+ // Copyright 2014 Fabio D'Urso <fabiodurso@hotmail.it>
+@@ -189,21 +189,31 @@ void Hints::readTables(BaseStream *str, Linearization *linearization, XRef *xref
+     char *p = &buf[0];
+ 
+     if (hintsOffset && hintsLength) {
+-        Stream *s = str->makeSubStream(hintsOffset, false, hintsLength, Object(objNull));
++        std::unique_ptr<Stream> s(str->makeSubStream(hintsOffset, false, hintsLength, Object(objNull)));
+         s->reset();
+         for (unsigned int i = 0; i < hintsLength; i++) {
+-            *p++ = s->getChar();
++            const int c = s->getChar();
++            if (unlikely(c == EOF)) {
++                error(errSyntaxWarning, -1, "Found EOF while reading hints");
++                ok = false;
++                return;
++            }
++            *p++ = c;
+         }
+-        delete s;
+     }
+ 
+     if (hintsOffset2 && hintsLength2) {
+-        Stream *s = str->makeSubStream(hintsOffset2, false, hintsLength2, Object(objNull));
++        std::unique_ptr<Stream> s(str->makeSubStream(hintsOffset2, false, hintsLength2, Object(objNull)));
+         s->reset();
+         for (unsigned int i = 0; i < hintsLength2; i++) {
+-            *p++ = s->getChar();
++            const int c = s->getChar();
++            if (unlikely(c == EOF)) {
++                error(errSyntaxWarning, -1, "Found EOF while reading hints2");
++                ok = false;
++                return;
++            }
++            *p++ = c;
+         }
+-        delete s;
+     }
+ 
+     MemStream *memStream = new MemStream(&buf[0], 0, bufLength, Object(objNull));
diff --git a/poppler.spec b/poppler.spec
index 8cc8791..adcbd4a 100644
--- a/poppler.spec
+++ b/poppler.spec
@@ -11,7 +11,7 @@
 Summary: PDF rendering library
 Name:    poppler
 Version: 22.01.0
-Release: 4%{?dist}
+Release: 5%{?dist}
 License: (GPLv2 or GPLv3) and GPLv2+ and LGPLv2+ and MIT
 URL:     http://poppler.freedesktop.org/
 Source0: http://poppler.freedesktop.org/poppler-%{version}.tar.xz
@@ -22,6 +22,8 @@ Patch1:  poppler-0.90.0-position-independent-code.patch
 
 Patch3:  poppler-21.01.0-glib-introspection.patch
 
+Patch4:  poppler-22.01.0-hints.patch
+
 BuildRequires: make
 BuildRequires: cmake
 BuildRequires: gcc-c++
@@ -256,6 +258,10 @@ test "$(pkg-config --modversion poppler-qt6)" = "%{version}"
 %{_mandir}/man1/*
 
 %changelog
+* Wed Jun 15 2022 Marek Kasik <mkasik@redhat.com> - 22.01.0-5
+- Don't run out of file for Hints
+- Resolves: #2090965
+
 * Fri May 20 2022 Sandro Mani <manisandro@gmail.com> - 22.01.0-4
 - Rebuild for gdal-3.5.0 and/or openjpeg-2.5.0