PR#2: Update to 2.5.0 - rpms/pre-commit

rpms / pre-commit

#2 Update to 2.5.0

Merged 2 years ago by churchyard. Opened 2 years ago by lbalhar.

rpms/ lbalhar/pre-commit master into master

Lumir Balhar • 2 years ago

6935c96

.gitignore

file modified

		`@@ -3,3 +3,5 @@`
		`/pre-commit-2.2.0.tar.gz`
		`/pre-commit-2.3.0.tar.gz`
		`/pre-commit-2.4.0.tar.gz`
		`+ /pre-commit-2.5.0.tar.gz`
		`+ /pre-commit-2.5.1.tar.gz`

pre-commit.spec

file modified

+6 -3

		`@@ -2,8 +2,8 @@`
		`%global pypi_name pre-commit`

		`Name: %{pypi_name}`
		`- Version: 2.4.0`
		`- Release: 2%{?dist}`
		`+ Version: 2.5.1`
		`+ Release: 1%{?dist}`
		`Summary: Framework for managing and maintaining multi-language pre-commit hooks`

		`License: MIT`
		`@@ -29,7 +29,7 @@`
		`BuildRequires: python3dist(pyyaml)`
		`BuildRequires: python3dist(six)`
		`BuildRequires: python3dist(toml)`
		`- BuildRequires: python3dist(virtualenv) >= 15.2`
		`+ BuildRequires: python3dist(virtualenv) >= 20`
		`%endif`

		`%?python_enable_dependency_generator`
		`@@ -81,6 +81,9 @@`


		`%changelog`
		`+ * Mon Jun 22 2020 Lumír Balhar <lbalhar@redhat.com> - 2.5.1-1`
		`+ - Update to 2.5.1`
		`+`
		`* Tue May 26 2020 Miro Hrončok <mhroncok@redhat.com> - 2.4.0-2`
		`- Rebuilt for Python 3.9`

sources

file modified

+1 -1

		`@@ -1,1 +1,1 @@`
		`- SHA512 (pre-commit-2.4.0.tar.gz) = 9ef9c8ab931180c13b92220110a06ca416cca43d463c9d4bcf2cc22b09ee623334a538611a81d1e349b56ee57a19619f41e34274bca7cc45e43e03cc3f78e3c9`
		`+ SHA512 (pre-commit-2.5.1.tar.gz) = 860fe77434209148110d24ea67756b941f58d7bd9bf315615eec455f988de6d49764f1228c95e24a8cd5fabd6a6014ed56e5401c306a6e53f6ea5fc29e6782f4`

no initial comment

churchyard commented 2 years ago

Note: This needs virtualenv 20, same as 2.4.0. We can merge it, because the current master already doesn't work.

churchyard commented 2 years ago

A scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=45827338

churchyard commented 2 years ago

@lbalhar could you please pin virtualenv BR to >=20? and possibly upgrade to 2.5.1

lbalhar commented 2 years ago

Done, scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=45976510

rebased onto 6e9323b

2 years ago

churchyard commented on line 17 of pre-commit.spec 2 years ago

I don't understand why 20.0.0. I'd either use >= 20 for simplicity (also, the python3dist provides never have trailing zeros), or the upstream provided information explicitly >=20.0.8. The current value doesn't really have any benefit, except being potentially confusing.

rebased onto 6935c96

2 years ago

lbalhar commented 2 years ago

Fixed to >= 20