#3 Obsolete emacs-el subpackage
Closed 5 years ago by orion. Opened 5 years ago by scfc.

file modified
+8 -14
@@ -12,7 +12,7 @@

  Summary:        Protocol Buffers - Google's data interchange format

  Name:           protobuf

  Version:        3.6.1

- Release:        3%{?dist}

+ Release:        4%{?dist}

  License:        BSD

  URL:            https://github.com/protocolbuffers/protobuf

  Source:         https://github.com/protocolbuffers/protobuf/archive/v%{version}%{?rcver}/%{name}-%{version}%{?rcver}-all.tar.gz
@@ -153,20 +153,13 @@

  BuildArch:      noarch

  Requires:       emacs(bin) >= 0%{emacs_version}

  

+ Provides:       protobuf-emacs-el = %{version}-%{release}

+ Obsoletes:      protobuf-emacs-el < 3.6.1-4

+ 

  %description emacs

  This package contains syntax highlighting for Google Protocol Buffers

  descriptions in the Emacs editor.

  

- %package emacs-el

- Summary:        Elisp source files for Google protobuf Emacs mode

- BuildArch:      noarch

- Requires:       protobuf-emacs = %{version}

- 

- %description emacs-el

- This package contains the elisp source files for %{name}-emacs

- under GNU Emacs. You do not need to install this package to use

- %{name}-emacs.

- 

  

  %if %{with java}

  %package java
@@ -359,10 +352,8 @@

  

  %files emacs

  %{emacs_startdir}/protobuf-init.el

- %{emacs_lispdir}/protobuf-mode.elc

- 

- %files emacs-el

  %{emacs_lispdir}/protobuf-mode.el

+ %{emacs_lispdir}/protobuf-mode.elc

  

  %if %{with java}

  %files java -f .mfiles-protobuf-java
@@ -380,6 +371,9 @@

  %endif

  

  %changelog

+ * Mon Mar  4 2019 Tim Landscheidt <tim@tim-landscheidt.de> - 3.6.1-4

+ - Obsolete emacs-el subpackage

+ 

  * Wed Feb 27 2019 Orion Poplawski <orion@nwra.com> - 3.6.1-3

  - Update googletest to 1.8.1 to re-enable tests

  

no initial comment

It would be great to have some rationale in commit message.

rebased onto db2416b

5 years ago

This was a move in the right direction, but not far enough. Thanks for the push though. I've committed changes that hopefully bring it in line with current (F13+!) guidelines.

Pull-Request has been closed by orion

5 years ago