PR#8: Don't overwrite config files modified by administrator - rpms/pulseaudio

rpms / pulseaudio

#8 Don't overwrite config files modified by administrator

Merged 3 years ago by rdieter. Opened 3 years ago by imsedgar.

rpms/ imsedgar/pulseaudio main into rawhide

Don't overwrite config files modified by administrator

Edgar Hoch • 3 years ago

b3838bf

pulseaudio.spec

file modified

+1 -1

		`@@ -542,7 +542,7 @@`
		`%endif`

		`%files module-x11`
		`- %{_sysconfdir}/xdg/autostart/pulseaudio.desktop`
		`+ %config(noreplace) %{_sysconfdir}/xdg/autostart/pulseaudio.desktop`
		`#{_bindir}/start-pulseaudio-kde`
		`%{_bindir}/start-pulseaudio-x11`
		`%{_libdir}/pulse-%{pa_major}/modules/module-x11-bell.so`

imsedgar commented 3 years ago

When an administrator modifies files in /etc/xdg/autostart/, these changes are lost on next update of the package. But the administrator should be able to configure systemwide defaults, e.g. that the program should not autostart at log in.

zuul commented 3 years ago

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci

check-for-arches : SUCCESS in 1m 21s
rpm-scratch-build : SUCCESS in 9m 19s
rpm-scratch-build-s390x : SUCCESS in 12m 18s (non-voting)
rpm-scratch-build-ppc64le : SUCCESS in 12m 22s (non-voting)
rpm-scratch-build-i686 : SUCCESS in 11m 17s (non-voting)
rpm-scratch-build-armv7hl : SUCCESS in 15m 28s (non-voting)
rpm-scratch-build-aarch64 : SUCCESS in 15m 07s (non-voting)
rpm-linter : FAILURE in 6m 36s
rpm-rpminspect : SUCCESS in 14m 47s (non-voting)
check-for-tests : SUCCESS in 39s
rpm-install-test : SUCCESS in 4m 16s
rpm-test : SKIPPED

rdieter commented 3 years ago

I'll probably not ok this, I see no good reason to consider this a config file

rdieter commented 3 years ago

I probably could be talked into removing the autostart or setting it to disabled by default (and then set as config)... Since pulseaudio functions generally via on demand socket activation these days...so the autostart file here is (almost) not needed anymore.

I'll think on it

Edited 3 years ago by rdieter

imsedgar commented 3 years ago

I'll probably not ok this, I see no good reason to consider this a config file

Did you read what I write as comment to the pull request?

Please see https://pagure.io/packaging-committee/issue/1056

All files in /etc/xdg/autostart/ are to be considered as configuration files, because these files are the only way to configure these autostart programs for desktop login as default for the host. I cannot (and will not) apply a config file in each home directory of hundreds of users to set the default for standard users.

Currently I run a script after installation that modifies some files in /etc/xdg/autostart/. When I check them some weeks later, the changes was overwritten by package updates. Then I have to run the scripts again. But I don't know when updates will be installed (I use dnf-automatic-install.service). I have to check it manually, or I need to write a script that does this regularly. But this would be paradox as a very simple solution would be that the package does not overwrite changes done locally.

rdieter commented 3 years ago

I still think editing global xdg autostart files is the wrong solution to almost any problem, if admins want to break stuff, that's their business I guess.

I'll merge this begrudgingly.