#5 Avoid coverage checks
Closed 11 months ago by bcl. Opened 11 months ago by yselkowitz.
rpms/ yselkowitz/pykickstart rawhide  into  rawhide

file modified
+6 -3
@@ -5,7 +5,7 @@ 

  

  Name:      pykickstart

  Version:   3.47

- Release:   1%{?dist}

+ Release:   2%{?dist}

  License:   GPL-2.0-only AND MIT

  Summary:   Python utilities for manipulating kickstart files.

  Url:       http://fedoraproject.org/wiki/pykickstart
@@ -27,7 +27,6 @@ 

  

  # Only required when building with runtests

  %if %{with runtests}

- BuildRequires: python3-coverage

  BuildRequires: python3-sphinx

  %endif

  
@@ -55,7 +54,8 @@ 

  

  %check

  %if %{with runtests}

- LC_ALL=C make PYTHON=%{__python3} test

+ # make test uses coverage; call the tests manually

+ %{py3_test_envvars} LC_ALL=C %{python3} -m unittest tests/*py tests/commands/*py tests/tools/*py

  %endif

  

  %files
@@ -79,6 +79,9 @@ 

  %{python3_sitelib}/pykickstart*.egg-info

  

  %changelog

+ * Wed Jun 07 2023 Yaakov Selkowitz <yselkowi@redhat.com> - 3.47-2

+ - Avoid coverage checks

+ 

  * Fri Mar 17 2023 Brian C. Lane <bcl@redhat.com> - 3.47-1

  - network: Move new options to Fedora 39 (bcl)

    Related: rhbz#1656662

python-coverage is unwanted in RHEL, but Fedora Python packaging guidelines state that test coverage checkers should not be used:

https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_linters

I'd rather do this upstream with a new makefile target.

See https://github.com/pykickstart/pykickstart/pull/457

Pull-Request has been closed by bcl

11 months ago

@bcl what is the timeframe for getting a new release in rawhide which does not pull in the unwanted python-coverage?

I can do one tomorrow

Metadata