#3 Fix package build with setuptools >= 60.x
Closed 2 years ago by jdekloe. Opened 2 years ago by ksurma.
rpms/ ksurma/pyproj setuptools-60  into  rawhide

file added
+22
@@ -0,0 +1,22 @@ 

+ From 3bd9df51e016c69ca588273bbd0a2ff06c19bfcf Mon Sep 17 00:00:00 2001

+ From: snowman2 <alansnow21@gmail.com>

+ Date: Tue, 25 Jan 2022 19:18:40 -0600

+ Subject: [PATCH] BUG: Reorder deps in show_versions for setuptools issue

+ 

+ ---

+  pyproj/_show_versions.py | 2 +-

+  1 file changed, 1 insertion(+), 1 deletion(-)

+ 

+ diff --git a/pyproj/_show_versions.py b/pyproj/_show_versions.py

+ index fdbbd05a..b5690f8b 100644

+ --- a/pyproj/_show_versions.py

+ +++ b/pyproj/_show_versions.py

+ @@ -81,7 +81,7 @@ def _get_deps_info():

+      deps_info: dict

+          version information on relevant Python libraries

+      """

+ -    deps = ["certifi", "pip", "setuptools", "Cython"]

+ +    deps = ["certifi", "Cython", "setuptools", "pip"]

+  

+      def get_version(module):

+          try:

file modified
+9 -1
@@ -4,7 +4,7 @@ 

  

  Name:           pyproj

  Version:        3.3.0

- Release:        3%{?dist}

+ Release:        4%{?dist}

  Summary:        Cython wrapper to provide python interfaces to Proj

  License:        MIT

  URL:            https://github.com/jswhit/%{name}
@@ -12,6 +12,11 @@ 

  # the old source url still works, but if need be it can be replaced

  # with: https://files.pythonhosted.org/packages/source/p/%%{name}/%%{name}-%%{version}.tar.gz

  

+ # In order for pyproj to work with setuptools >= 60, the order of imported

+ # modules must be changed. Otherwise the invocation `python -m pyproj -v` makes

+ # a giant boom. Upstream PR: https://github.com/pyproj4/pyproj/pull/1019

+ Patch:          1019.patch

+ 

  BuildRequires:  make

  BuildRequires:  gcc

  BuildRequires:  proj-devel >= %{minimal_needed_proj_version}
@@ -173,6 +178,9 @@ 

  

  

  %changelog

+ * Mon Mar 14 2022 Karolina Surma <ksurma@redhat.com> 3.3.0-4

+ - Fix package build with setuptools >= 60.x

+ 

  * Wed Mar 09 2022 Sandro Mani <manisandro@gmail.com> - 3.3.0-3

  - Rebuild for proj-9.0.0

  

I'm working on integrating python-setuptools 60.x to Fedora. This package failed in the impact check performed in Copr, which was assessed to be an effect of setuptools' changes.
This change will make it possible to build the package with the newest setuptools, once it's in Rawhide.

rebased onto 8055e99

2 years ago

setuptools 60.9.3 is now in Rawhide so this fix will be needed to build pyproj.

Thanks for your PR. The same change was applied upstream between releases 3.3.0 and 3.3.1 so this PR is no longer applicable, since rawhide version of pyproj is at 3.3.1 now.
Sorry for my late response. Seems that for some reason pull-requests don't generate emails to the packager, so I only noticed now that you opened one 3 months ago.

Pull-Request has been closed by jdekloe

2 years ago
Metadata