PR#42: Fedora CI: Add support for Zuul based CI - rpms/pyproject-rpm-macros

rpms / pyproject-rpm-macros

#42 Fedora CI: Add support for Zuul based CI

Merged 4 years ago by churchyard. Opened 4 years ago by churchyard.

rpms/ churchyard/pyproject-rpm-macros zuul into master

Fedora CI: Add support for Zuul based CI

Miro Hrončok • 4 years ago

fe3aa8f

tests/mocktest.sh

file modified

+9 -1

		`@@ -18,7 +18,15 @@`
		`cp $original $config`

		`echo -e '\n\nconfig_opts[f"{config_opts.package_manager}.conf"] += """' >> $config`
		`- cat /etc/yum.repos.d/test-*.repo >> $config`
		`+`
		`+ # The zuul CI has zuul-build.repo`
		`+ # The Jenkins CI has test-<pkgname>.repo`
		`+ # We run this code from various packages, so we support any <pkgname>`
		`+ if [ -f /etc/yum.repos.d/zuul-build.repo ]; then`
		`+ cat /etc/yum.repos.d/zuul-build.repo >> $config`
		`+ else`
		`+ cat /etc/yum.repos.d/test-*.repo >> $config`
		`+ fi`
		`echo -e '\n"""\n' >> $config`
		`fi`

churchyard commented 4 years ago

Untested, waits for https://pagure.io/fedora-project-config/pull-request/70

churchyard commented 4 years ago

recheck

churchyard commented 4 years ago

recheck

fbo commented 4 years ago

recheck

fbo commented 4 years ago

There is delay between the merge of such changes https://pagure.io/fedora-project-config/pull-request/70 and the Zuul reload. The first "recheck" was to fast for the system :)

zuul commented 4 years ago

Build succeeded.

rpm-scratch-build : SUCCESS in 5m 32s
rpm-linter : SUCCESS in 1m 54s
rpm-rpminspect : FAILURE in 2m 48s (non-voting)

churchyard commented 4 years ago

There is no rpm-test?

churchyard commented 4 years ago

recheck

zuul commented 4 years ago

Build succeeded.

rpm-scratch-build : SUCCESS in 4m 30s
rpm-linter : SUCCESS in 2m 24s
rpm-rpminspect : FAILURE in 6m 26s (non-voting)

fbo commented 4 years ago

ah yes, I've removed rpm-tests from the defaults jobs as some distgit does not have tests. So this need to be setup by project https://pagure.io/fedora-zuul-jobs-config/pull-request/42

fbo commented 4 years ago

recheck

zuul commented 4 years ago

Build succeeded.

rpm-test : SUCCESS in 13m 44s
rpm-scratch-build : SUCCESS in 4m 59s
rpm-linter : SUCCESS in 1m 51s
rpm-rpminspect : FAILURE in 2m 40s (non-voting)

churchyard commented 4 years ago

Oh. Should this be mentioned at https://fedoraproject.org/wiki/Zuul-based-ci#Configure_the_repository_for_Zuul ?

some distgit does not have tests

What if... the test run when there is the test config file but don't run when not?

Pull-Request has been merged by churchyard

4 years ago

fbo commented 4 years ago

Oh. Should this be mentioned at https://fedoraproject.org/wiki/Zuul-based-ci#Configure_the_repository_for_Zuul ?

Yes it is, I've updated it recently:
"Note that all repositories with a name that match the regexp '^rpms/.*' will get, by default, the jobs defined by the build and lint templates attached. Thus, if the default configuration is sufficient, then no need to edit the zuul.d/projects.yaml file as explained at the end of this section. "

some distgit does not have tests

What if... the test run when there is the test config file but don't run when not?

My concern is that Zuul will spawn the VM as waste Nodepool provider resources just to discover the job cannot be run. Unfortunately I don't see a Zuul job attribute to tell Zuul to skip a job when a file or directory does not exist.
I'd like the Zuul community opinion on that so http://lists.zuul-ci.org/pipermail/zuul-discuss/2020-March/001168.html

churchyard commented 4 years ago

Thanks!