#1 Update to build with sip 5
Merged 2 years ago by kevin. Opened 2 years ago by swt2c.
rpms/ swt2c/pyqtwebengine sip5  into  rawhide

file modified
+16 -14
@@ -9,7 +9,7 @@ 

  Summary: Python bindings for QtWebEngine

  Name:    pyqtwebengine

  Version: 5.15.2

- Release: 2%{?dist}

+ Release: 3%{?dist}

  

  License: GPLv3

  Url:     https://www.riverbankcomputing.com/software/pyqt/
@@ -36,8 +36,8 @@ 

  BuildRequires: python%{python3_pkgversion}-devel python%{python3_pkgversion}

  BuildRequires: python%{python3_pkgversion}-qt5

  BuildRequires: python%{python3_pkgversion}-qt5-devel

- BuildRequires: python%{python3_pkgversion}-pyqt5-sip >= %{sip_ver}

- BuildRequires: python%{python3_pkgversion}-sip-devel >= %{sip_ver}

+ BuildRequires: %{py3_dist sip} >= 5.3

+ BuildRequires: %{py3_dist PyQt-builder} >= 1

  %endif # with_python3

  

  %description
@@ -62,7 +62,7 @@ 

  # when webengine content was split out

  Conflicts: python2-qt5-devel < 5.12.1

  Conflicts: python%{python3_pkgversion}-qt5-devel < 5.12.1

- Requires: sip

+ Requires: %{py3_dist sip} >= 5.3

  BuildArch: noarch

  %description devel

  %{summary}.
@@ -100,17 +100,16 @@ 

  

  # Python 3 build:

  %if 0%{?with_python3}

- mkdir %{_target_platform}-python3

- pushd %{_target_platform}-python3

- %{__python3} ../configure.py \

+ sip-build \

+   --no-make \

    --qmake=%{_qt5_qmake} \

+   --api-dir=%{_qt5_datadir}/qsci/api/python \

    --verbose \

-   QMAKE_CFLAGS_RELEASE="%{build_cflags}" \

-   QMAKE_CXXFLAGS_RELEASE="%{build_cxxflags}" \

-   QMAKE_LFLAGS_RELEASE="%{build_ldflags}"

+   --qmake-setting 'QMAKE_CFLAGS_RELEASE="%{build_cflags}"' \

+   --qmake-setting 'QMAKE_CXXFLAGS_RELEASE="%{build_cxxflags}"' \

+   --qmake-setting 'QMAKE_LFLAGS_RELEASE="%{build_ldflags}"'

  

- %make_build

- popd

+ %make_build -C build

  %endif # with_python3

  

  
@@ -118,7 +117,7 @@ 

  

  # Python 3 build:

  %if 0%{?with_python3}

- %make_install INSTALL_ROOT=%{buildroot} -C %{_target_platform}-python3

+ %make_install INSTALL_ROOT=%{buildroot} -C build

  

  # ensure .so modules are executable for proper -debuginfo extraction

  for i in %{buildroot}%{python3_sitearch}/PyQt5/*.so ; do
@@ -160,7 +159,7 @@ 

  

  %files devel

  %license LICENSE

- %{_datadir}/sip/PyQt5/QtWebEngine*/

+ %{python3_sitearch}/PyQt5/bindings/QtWebEngine*/

  

  %files doc

  # avoid dep on qscintilla-python, own %%_qt5_datadir/qsci/... here for now
@@ -171,6 +170,9 @@ 

  

  

  %changelog

+ * Thu Jun 10 2021 Scott Talbert <swt@techie.net> - 5.15.2-3

+ - Update to build with sip 5

+ 

  * Fri Jun 04 2021 Python Maint <python-maint@redhat.com> - 5.15.2-2

  - Rebuilt for Python 3.10

  

Please DON'T MERGE but do provide comments/approval. This is part of a coordinated move to sip5 in F35+.

Doing builds in f35-build-side-43327

Pull-Request has been merged by kevin

2 years ago

So, this fails because the devel subpackage is noarch and sip5 installs into %{_libdir} making the devel package different on the different arches. ;(

If we just make the devel subpackage archfull it works otherwise. ( scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=71259213 )
Or if there's some way to get sip5 to install into datadir or the like?

Let's just make the -devel package archful. pyqt5's devel package is already archful so probably not worth trying to change the paths into something archful. Let me know if you want me to do an update or you just want to make that quick fix?

BTW, looks like qscintilla might have the same problem, pushing a fix.

Metadata