#1 Update to 3.2.2 (#1691128)
Merged a month ago by carlwgeorge. Opened a month ago by churchyard.
rpms/ churchyard/python-asgiref 3  into  master

file modified
+9 -5

@@ -20,10 +20,11 @@ 

  

  

  Name:           python-%{pkgname}

- Version:        2.3.2

- Release:        4%{?dist}

+ Version:        3.2.2

+ Release:        1%{?dist}

  Summary:        ASGI specs, helper code, and adapters

- License:        BSD

+ # This is BSD + bundled async-timeout ASL 2.0

+ License:        BSD and ASL 2.0

  URL:            https://github.com/django/asgiref

  # PyPI tarball doesn't have tests

  Source0:        %{url}/archive/%{version}/%{srcname}-%{version}.tar.gz

@@ -40,9 +41,9 @@ 

  %if %{with tests}

  BuildRequires:  python3-pytest >= 3.3

  BuildRequires:  python3-pytest-asyncio

- BuildRequires:  python3-async-timeout >= 2.0

  %endif

- Requires:       python3-async-timeout >= 2.0

+ # https://github.com/django/asgiref/commit/9c6df6e02700092eb19adefff3552d44388f69b8

+ Provides:       bundled(python3dist(async-timeout)) == 3.0.1

  %{?python_provide:%python_provide python3-%{pkgname}}

  

  

@@ -75,6 +76,9 @@ 

  

  

  %changelog

+ * Mon Sep 16 2019 Miro Hrončok <mhroncok@redhat.com> - 3.2.2-1

+ - Update to 3.2.2 (#1691128)

+ 

  * Mon Aug 19 2019 Miro Hrončok <mhroncok@redhat.com> - 2.3.2-4

  - Rebuilt for Python 3.8

  

file modified
+1 -1

@@ -1,1 +1,1 @@ 

- SHA512 (asgiref-2.3.2.tar.gz) = 0ea56d346dcb7c2327f049a686cea1686423ec10a150eeb437b6f12aeffa8a1358443eee199c3076827a15b17b8f66fa50a467066358f796c9d49175dd81e908

+ SHA512 (asgiref-3.2.2.tar.gz) = 27c86570bf44a7638bee56ade5e82484da6e36462570ced8b95fded43f4fbc796f4bb321b2e44d76e8bdb80742580b06cc940836350a115673d021e935652d69

no initial comment

BTW A async-timeout runtime requirement is present, however that seems bundled in asgiref/timeout.py.

Looks like that happened in 3.1.3.

https://github.com/django/asgiref/commit/c0fdf92290b94f04b9f9c02cfdb190727a708c8a

https://github.com/django/asgiref/commit/9c6df6e02700092eb19adefff3552d44388f69b8#diff-dc926f43ce7755fce7332425aa258eaa

The comments in asgiref/timeout.py state that the code has been modified. Do you think we should keep the modified vendored library, or remove it and continue requiring python3-async-timeout? I'm fine either way.

I'd keep it bundled for simplicity. Let me adapt the spec.

I just tested unbundling it via patch and at least the test suite passes.

If we're keeping it we just need to remove the requirement and add the bundling provides.

rebased onto 09811ff

a month ago

Looks good, except the release doesn't match the changelog.

rebased onto cb241f2

a month ago

I just tested unbundling it via patch and at least the test suite passes.

If you want to maintain such patch, do it. I just needed an update :D

Pull-Request has been merged by carlwgeorge

a month ago

Nah, I was just curious if it would work. Since upstream says the code has been modified I don't want to assume that unbundling will always work.

I've built it for rawhide, do you want it for F31 also?

https://bodhi.fedoraproject.org/updates/FEDORA-2019-d2393053ba

Thanks.

do you want it for F31 also?

Not really, this is needed for Django 3 (Fedora 32+ only).

BTW Could add python-sig to the package maintainers?