PR#1: Fix directory ownership - rpms/python-cachetools

rpms / python-cachetools

#1 Fix directory ownership

Merged 5 years ago by jeckersb. Opened 5 years ago by lbalhar.

rpms/ lbalhar/python-cachetools master into master

Fix directory ownership

Lumir Balhar • 5 years ago

017ac09

python-cachetools.spec

file modified

+6 -3

		`@@ -6,7 +6,7 @@`

		`Name: python-cachetools`
		`Version: 2.0.1`
		`- Release: 2%{?dist}`
		`+ Release: 3%{?dist}`
		`Summary: Extensible memoizing collections and decorators`

		`License: MIT`
		`@@ -107,7 +107,7 @@`
		`%doc python2/CHANGES.rst python2/PKG-INFO python2/README.rst`
		`%license python2/LICENSE`
		`# For noarch packages: sitelib`
		`- %{python2_sitelib}/cachetools/*`
		`+ %{python2_sitelib}/cachetools`
		`%{python2_sitelib}/cachetools-%{version}-py%{python2_version}.egg-info`

		`%if %{with python3}`
		`@@ -115,12 +115,15 @@`
		`%doc python3/CHANGES.rst python3/PKG-INFO python3/README.rst`
		`%license python3/LICENSE`
		`# For noarch packages: sitelib`
		`- %{python3_sitelib}/cachetools/*`
		`+ %{python3_sitelib}/cachetools`
		`%{python3_sitelib}/cachetools-%{version}-py%{python3_version}.egg-info`
		`%endif # with python3`


		`%changelog`
		`+ * Wed Jan 03 2018 Lumír Balhar <lbalhar@redhat.com> - 2.0.1-3`
		`+ - Fix directory ownership`
		`+`
		`* Sat Aug 19 2017 Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> - 2.0.1-2`
		`- Python 2 binary package renamed to python2-cachetools`
		`See https://fedoraproject.org/wiki/FinalizingFedoraSwitchtoPython3`

lbalhar commented 5 years ago

Hello.

The problem here I am trying to solve is that some directory in /usr/lib*/python*/site-packages/<package_name> were not owned by your packages and remain untouched after uninstallation process.

Have a nice day.

jeckersb commented 5 years ago

The rpm looks like it uninstalls cleanly to me. Is it possible in your case that cachetools is being installed both by rpm and some other external utility (pip or similar)?

lbalhar commented 5 years ago

Hello.

The problem is that python[23]-cachetools installed from the repository to fresh mock doesn't own its main directory.

$ rpm -qf /usr/lib/python*/site-packages/cachetools
file /usr/lib/python2.7/site-packages/cachetools is not owned by any package
file /usr/lib/python3.6/site-packages/cachetools is not owned by any package

and after removal, the directories are still there and empty:

$ ll /usr/lib/python*/site-packages/cachetools/
/usr/lib/python2.7/site-packages/cachetools/:
total 0

/usr/lib/python3.6/site-packages/cachetools/:
total 0

jeckersb commented 5 years ago

Oh right. I read the patch backwards. Not a good start to the year!

Looks good now :)