PR#3: don't require python3-pkgversion-macros - rpms/python-contextlib2

rpms / python-contextlib2

#3 don't require python3-pkgversion-macros

Merged 5 years ago by ralph. Opened 5 years ago by dcallagh.

rpms/ dcallagh/python-contextlib2 epel7-no-python3-pkg-version-macros into epel7

don't require python3-pkgversion-macros

Dan Callaghan • 5 years ago

a881d4d

python-contextlib2.spec

file modified

-1

		`@@ -29,7 +29,6 @@`
		`BuildRequires: python-unittest2`

		`%if 0%{?with_python3}`
		`- BuildRequires: python3-pkgversion-macros`
		`BuildRequires: python%{python3_pkgversion}-devel`
		`%if 0%{?with_python3_other}`
		`BuildRequires: python%{python3_other_pkgversion}-devel`

dcallagh commented 5 years ago

This was only ever needed in the very earliest drafts of the EPEL7
Python 3 guidelines. Nowadays the RPM macros for python3_* are provided
by the regular python-srpm-macros package which is in the minimal
buildroot.

This fixes the build on EPEL7 which is currently failing due to this
unsatisfiable dependency.

dcallagh commented 5 years ago

Not sure if you would prefer a Release bump for this... I didn't bother since there is no effective change to the package itself, there would be no point filing it as an update.

dcallagh commented 5 years ago

Also FYI I found this problem when I was doing some repoclosure checks on our third-party Beaker repos. I noticed that Koschei was not enabled for the epel7 branch of this package, so the FTBFS problem had presumably gone unnoticed. I took the liberty of turning on Koschei (and it does indeed fail).

ralph commented 5 years ago

Nice, thanks!

Pull-Request has been merged by ralph

5 years ago

dcallagh commented 5 years ago

Huh... seems like Koschei does not realise that the .spec file has changed, maybe because I didn't bump the Release... or else this fix didn't actually work...