PR#1: Update Python 2 dependency declarations to new packaging standards - rpms/python-f5-icontrol-rest

rpms / python-f5-icontrol-rest

#1 Update Python 2 dependency declarations to new packaging standards

Merged 6 years ago by xavierb. Opened 6 years ago by ishcherb.

rpms/ ishcherb/python-f5-icontrol-rest pyambiguous into master

Update Python 2 dependency declarations to new packaging standards

Iryna Shcherbina • 6 years ago

c11c7ca

python-f5-icontrol-rest.spec

file modified

+7 -3

		`@@ -7,7 +7,7 @@`

		`Name: python-%{srcname}`
		`Version: 1.3.6`
		`- Release: 2%{?dist}`
		`+ Release: 3%{?dist}`
		`Summary: %{sum}`

		`License: ASL 2.0`
		`@@ -52,9 +52,9 @@`
		`BuildRequires: python2-flake8`
		`BuildRequires: python2-mccabe`
		`BuildRequires: python2-mock`
		`- BuildRequires: python-pep8`
		`+ BuildRequires: python2-pep8`
		`BuildRequires: python2-pyflakes`
		`- BuildRequires: python-requests-mock`
		`+ BuildRequires: python2-requests-mock`
		`BuildRequires: python2-tox`
		`%endif`

		`@@ -151,6 +151,10 @@`


		`%changelog`
		`+ * Fri Mar 09 2018 Iryna Shcherbina <ishcherb@redhat.com> - 1.3.6-3`
		`+ - Update Python 2 dependency declarations to new packaging standards`
		`+ (See https://fedoraproject.org/wiki/FinalizingFedoraSwitchtoPython3)`
		`+`
		`* Wed Feb 21 2018 Xavier Bachelot <xavier@bachelot.org> - 1.3.6-2`
		`- Fix doc.`
		`- Tidy up BR:s for EL6 and EL7.`

ishcherb commented 6 years ago

This package uses names with ambiguous python- prefix in requirements.

According to Fedora Packaging guidelines for Python, packages must use names with either python2- or python3- prefix in requirements where available.
We are aiming to rename python-* dependencies to python2-*, so we can later switch the python-* namespace to Python 3.

This PR is part of Fedora's Switch to Python 3 effort.

Note that, although this PR was created automatically, we will respond to any comments or issues which you might find with it. We will keep the PR open for review for a week, and if there's no feedback we'll merge it. There is no need to build the package right after merge, this change can wait for the next package rebuild.
The local mock build passed, for Koji scratch build please see simple-koji-ci result.

Note: please do not backport this to f26, f27 branches, as some of the modified requirements are not available there

This PR was opened automatically, for source code see here

xavierb commented 6 years ago

Thanks for the patch.
Is there any effort going on to sanitize the python packages in F27 and F26 ?
I like to keep my specfiles identical for the various release branches and the special case for EL make it bad enough already. if I have to special case for F26 and F27 too, that'll become a real mess. Wouldn't it be better to first ensure all packages are properly producing python2 and python3 sub-packages before changing the (Build)Requires ?

Pull-Request has been merged by xavierb

6 years ago

ishcherb commented 6 years ago

@xavierb thanks for merging.

Is there any effort going on to sanitize the python packages in F27 and F26 ?

Not that I know of. The renaming effort was done in F28, and it was up to maintainers if they backport the change to the previous branches.

Wouldn't it be better to first ensure all packages are properly producing python2 and python3 sub-packages before changing the (Build)Requires ?

We have ensured this in F28. Ensuring this on all branches would just take too much time. If you need some packages to provide python2- names on previous branches, let me know, I'll backport the renaming change.