PR#1: WIP: Update to 0.9.7.post1 (fix RHBZ#2060033) - rpms/python-glymur

rpms / python-glymur

#1 WIP: Update to 0.9.7.post1 (fix RHBZ#2060033)

Closed 2 years ago by music. Opened 2 years ago by music.

rpms/ music/python-glymur v0.9.7 into rawhide

Update to 0.9.7.post1 (fix RHBZ#2060033)

Benjamin A. Beasley • 2 years ago

57512c7

.gitignore

file modified

		`@@ -1,1 +1,2 @@`
		`/python-glymur-0.9.4.tar.gz`
		`+ /python-glymur-0.9.7.post1.tar.gz`

544.patch

file added

+25

		`@@ -0,0 +1,25 @@`
		`+ From 3e026de6ac3b9dee28701e34c3a95efcbaeaa659 Mon Sep 17 00:00:00 2001`
		`+ From: "Benjamin A. Beasley" <code@musicinmybrain.net>`
		`+ Date: Wed, 2 Mar 2022 11:14:35 -0500`
		`+ Subject: [PATCH] =?UTF-8?q?Add=20missing=20=E2=80=9Cpackaging=E2=80=9D=20d?=`
		`+ =?UTF-8?q?ependency?=`
		`+ MIME-Version: 1.0`
		`+ Content-Type: text/plain; charset=UTF-8`
		`+ Content-Transfer-Encoding: 8bit`
		`+`
		`+ ---`
		`+ setup.cfg \| 1 +`
		`+ 1 file changed, 1 insertion(+)`
		`+`
		`+ diff --git a/setup.cfg b/setup.cfg`
		`+ index c781114..6abb685 100644`
		`+ --- a/setup.cfg`
		`+ +++ b/setup.cfg`
		`+ @@ -27,6 +27,7 @@ packages = find:`
		`+ install_requires =`
		`+ numpy`
		`+ lxml`
		`+ + packaging`
		`+ setuptools`
		`+ python_requires = >=3.7`
		`+ include_package_data = True`

jp2dump.1

file modified

		`@@ -37,4 +37,6 @@`
		`(default:`
		`.BR 1 )`
		`.SH "SEE ALSO"`
		`+ .BR tiff2jp2 (1)`
		`+ .P`
		`.BR j2k_dump (1)`

python-glymur.spec

file modified

+15 -3

		`@@ -1,17 +1,24 @@`
		`Name: python-glymur`
		`- Version: 0.9.4`
		`+ Version: 0.9.7.post1`
		`Release: %autorelease`
		`Summary: Interface to the OpenJPEG library for working with JPEG 2000 files`

		`License: MIT`
		`URL: https://pypi.org/project/Glymur/`
		`Source0: https://github.com/quintusdias/glymur/archive/v%{version}/%{name}-%{version}.tar.gz`
		`+ # Man pages hand-written for Fedora in groff_man(7) format based on --help`
		`+ # output:`
		`Source1: jp2dump.1`
		`+ Source2: tiff2jp2.1`
		`+`
		`+ Patch0: https://github.com/quintusdias/glymur/pull/544.patch`

		`BuildArch: noarch`
		`BuildRequires: python3-devel`
		`- BuildRequires: python3-pytest`
		`- BuildRequires: python3-scikit-image`
		`+ BuildRequires: python3dist(pytest)`
		`+ # tests/fixtures.py: each of these enables more tests`
		`+ BuildRequires: python3dist(scikit-image)`
		`+ BuildRequires: python3dist(gdal)`

		`%global _description %{expand:`
		`Glymur contains a Python interface to the OpenJPEG`
		`@@ -23,6 +30,9 @@`
		`Requires: openjpeg2`
		`Summary: %{summary}`

		`+ # glymur/jp2box.py: provides optional functionality`
		`+ Recommends: python3dist(gdal)`
		`+`
		`%description -n python3-glymur %_description`


		`@@ -52,6 +62,8 @@`
		`%doc README.md CHANGES.txt`
		`%license LICENSE.txt`
		`%{_bindir}/jp2dump`
		`+ %{_bindir}/tiff2jp2`
		`+`
		`%exclude %{python3_sitelib}/tests`
		`%{_mandir}/man1/jp2dump.1*`

sources

file modified

+1 -1

		`@@ -1,1 +1,1 @@`
		`- SHA512 (python-glymur-0.9.4.tar.gz) = 8fa6a3ad17af897af3aa79cb2cd65145eda6c78489768535701f1805dcab356483ffe91c6897e6d4d73156527ddb0b90c3d48b2d725f166536351316c765d077`
		`+ SHA512 (python-glymur-0.9.7.post1.tar.gz) = b3719e769d35bb9952f3f3b66b59dcc50bb00894b4d1de3c51354647d2dedc6f7f3dbc520a518115885d8b1dfe164e3add5833b82bcac4550f694f4da423bd63`

music commented 2 years ago

I think it should be fine to build this as a compatible update for stable branches.

music commented 2 years ago

Is Fedora CI choking on rpmautospec now?

ankursinha commented 2 years ago

CI says:

+ fedpkg sources
Parsing specfile for used sources failed. Falling back to downloading all sources.
warning: line 3: Possible unexpanded macro in: Release:        %autorelease
warning: line 3: Possible unexpanded macro in: Release:        %autorelease
error: %changelog entries must start with *

Downloading python-glymur-0.9.7.post1.tar.gz

So, it does download the tar, but then can't rebuild the srpm:

ERROR: Command failed: 
 # bash --login -c /usr/bin/rpmbuild -bs --target x86_64 --nodeps /builddir/build/SPECS/python-glymur.spec

I don't see anything wrong in the spec, though..

music commented 2 years ago

[citest]

ankursinha commented 2 years ago

[citest]

music commented 2 years ago

I re-ran the CI on a different PR, https://src.fedoraproject.org/rpms/c4core/pull-request/3, and had no trouble. This PR works locally and via fedpkg scratch-build --srpm. I’m confused.

music commented 2 years ago

Upstream source diff: https://github.com/quintusdias/glymur/compare/v0.9.4...v0.9.7.post1

music commented 2 years ago

The issues in https://bugzilla.redhat.com/show_bug.cgi?id=2060087 are all for the new tiff2jp2 tool, so it might be worth looking into them before moving forward with this PR. Marking this PR as WIP.

music commented 2 years ago

Replaced by https://src.fedoraproject.org/rpms/python-glymur/pull-request/2.

Pull-Request has been closed by music

2 years ago