#2 Change dependencies to work with the latest location of test.support module
Merged 2 months ago by qulogic. Opened 2 months ago by lbalhar.
rpms/ lbalhar/python-heapdict test.support_change  into  master

file modified
+6 -1

@@ -3,7 +3,7 @@ 

  

  Name:           python-%{srcname}

  Version:        1.0.0

- Release:        8%{?dist}

+ Release:        9%{?dist}

  Summary:        A heap with decrease-key and increase-key operations

  

  License:        BSD

@@ -25,6 +25,7 @@ 

  %{?python_provide:%python_provide python3-%{srcname}}

  

  BuildRequires:  python3-devel

+ BuildRequires:  python3-test

  

  %description -n python3-%{srcname} %{_description}

  

@@ -54,6 +55,10 @@ 

  

  

  %changelog

+ * Wed Jul 17 2019 Lumír Balhar <lbalhar@redhat.com> - 1.0.0-9

+ - Change dependencies to work with the latest location of test.support module

+   https://fedoraproject.org/wiki/Changes/Move_test.support_module_to_python3-test_subpackage

+ 

  * Sat Feb 02 2019 Fedora Release Engineering <releng@fedoraproject.org> - 1.0.0-8

  - Rebuilt for https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild

  

Juts a nitpick, but maybe an explaining comment (or part of the commit message) about what part of test.support is used would be helpful? Otherwise looks good.

Juts a nitpick, but maybe an explaining comment (or part of the commit message) about what part of test.support is used would be helpful? Otherwise looks good.

I don't know what part of the test.support is used in tests of this package. I just know that the tests fail without the test.support module. If you need to know that, I can dive into this package and tell you but I don't think it would change this PR anyhow. I mean, maintainer knows much better than me what's inside a package.

Sure thing, I just assumed you still have the failure logs from copr.

Sure thing, I just assumed you still have the failure logs from copr.

I do, but they are useless because nearly all of them ends with ModuleNotFoundError: No module named 'test' which tells you nothing about exact usage.

To make it completely clear, I did new builds of affected packages before and after the proposed fix to see that the change of test.support location really breaks the package and my fix fixes it. https://copr.fedorainfracloud.org/coprs/lbalhar/test.support_change/builds/

It uses test.support.run_unittest. Don't know if there's some replacement for that it could use instead.

Pull-Request has been merged by qulogic

2 months ago
Metadata