PR#5: Update to 4.23.8 (#1711096) - rpms/python-hypothesis

rpms / python-hypothesis

#5 Update to 4.23.8 (#1711096)

Merged 4 years ago by churchyard. Opened 4 years ago by churchyard.

rpms/ churchyard/python-hypothesis 4.23.8 into master

Add %check

Miro Hrončok • 4 years ago

c8af0a6

Update to 4.23.8 (#1711096)

Miro Hrončok • 4 years ago

f8e8af8

.gitignore

file modified

		`@@ -22,3 +22,4 @@`
		`/hypothesis-3.66.11.tar.gz`
		`/hypothesis-4.9.0.tar.gz`
		`/hypothesis-4.23.4.tar.gz`
		`+ /hypothesis-4.23.8.tar.gz`

python-hypothesis.spec

file modified

+27 -1

		`@@ -2,7 +2,7 @@`
		`%global srcname hypothesis`

		`Name: python-%{srcname}`
		`- Version: 4.23.4`
		`+ Version: 4.23.8`
		`Release: 1%{?dist}`
		`Summary: Library for property based testing`

		`@@ -15,6 +15,9 @@`

		`BuildArch: noarch`

		`+ # Needs pytest and others, but hypothesis is built sooner than pytest when bootstrapping`
cstratak commented 4 years ago Would a bootstrap bcond make sense here?
churchyard commented 4 years ago Well this serves as good and running the test should not change the resulting RM in any way, so we are not really bootstrapping it. Other Python packages that are bootstrapped for test only usually have this kind of bcond. See for example https://github.com/hroncok/rpm-list-builder/blob/python37/python37.yaml
		`+ %bcond_without tests`
		`+`
		`%global _description \`
		`Hypothesis is a library for testing your Python code against a much\`
		`larger range of examples than you would ever want to write by\`
		`@@ -48,6 +51,16 @@`
		`BuildRequires: python3-setuptools`
		`BuildRequires: python3dist(attrs) >= 16.0.0`
		`BuildRequires: python3dist(coverage)`
		`+ %if %{with tests}`
		`+ #BuildRequires: python3dist(django)`
		`+ #BuildRequires: python3dist(dpcontracts)`
		`+ #BuildRequires: python3dist(lark)`
		`+ BuildRequires: python3dist(mock)`
		`+ BuildRequires: python3dist(numpy)`
		`+ BuildRequires: python3dist(pandas)`
		`+ BuildRequires: python3dist(pytest)`
		`+ BuildRequires: python3dist(pytest-xdist)`
		`+ %endif`
		`Suggests: python%{python3_version}dist(pytz) >= 2014.1`
		`Suggests: python%{python3_version}dist(numpy) >= 1.9.0`
		`Suggests: python%{python3_version}dist(pytest) >= 3.0`
		`@@ -61,6 +74,11 @@`
		`# disable Sphinx extensions that require Internet access`
		`sed -i -e '/sphinx.ext.intersphinx/d' docs/conf.py`

		`+ # remove tests we cannot run`
cstratak commented 4 years ago Another approach would be to exclude those tests during the pytest invocation, not sure which one is more beneficial, but I guess since the dependencies are not shipped, maybe it's better to remove them.
churchyard commented 4 years ago I don't think it's better or worse. Let's keep it as it is? (Less work.)
cstratak commented 4 years ago Yes, no need to ponder over that.
		`+ rm -r tests/py2 # python 2`
		`+ rm -r tests/lark tests/dpcontracts # missing deps`
		`+ rm -r tests/django # doesn't work, maybe bad django version`
		`+`
		`%build`
		`%py2_build`
		`%py3_build`
		`@@ -71,6 +89,11 @@`
		`%py3_install`
		`%{__install} -Dpm0644 -t %{buildroot}%{_mandir}/man1 docs/_build/man/hypothesis.1`

		`+ %if %{with tests}`
		`+ %check`
		`+ PYTHONPATH=%{buildroot}%{python3_sitelib} pytest-3 -v -n auto`
		`+ %endif`
		`+`
		`%files -n python2-%{srcname}`
		`%license ../LICENSE.txt`
		`%doc README.rst`
		`@@ -86,6 +109,9 @@`
		`%{_mandir}/man1/hypothesis.1*`

		`%changelog`
		`+ * Tue May 28 2019 Miro Hrončok <mhroncok@redhat.com> - 4.23.8-1`
		`+ - Update to 4.23.8 (#1711096)`
		`+`
		`* Thu May 09 2019 Miro Hrončok <mhroncok@redhat.com> - 4.23.4-1`
		`- Update to 4.23.4 (#1609770)`

sources

file modified

+1 -1

		`@@ -1,1 +1,1 @@`
		`- SHA512 (hypothesis-4.23.4.tar.gz) = a9be9d6cf2ae5c13f0c79ee360bd56c3f38305d2e5f947ba9e77b55693985740979c63453623f3b46131546c7dc0e02d56083b89d72d9c9a99b90ed5717bf5e2`
		`+ SHA512 (hypothesis-4.23.8.tar.gz) = 4eb66bc467f37fb66600c2e88f031c41e063286bdd1aa40495e75e1a41018053db2b054ee2696b25f9a58e92f5b9ea60f3b59659a1c0ad15bc1a5e63e582ee5a`

no initial comment

churchyard commented 4 years ago

Builds on 3.7 and 3.8 alike. However, no %check is here. I'll see if i can add it.

Metadata Update from @churchyard:
- Request assigned

4 years ago

Metadata Update from @churchyard:
- Request assignee reset

4 years ago

1 new commit added

Add %check

4 years ago

churchyard commented 4 years ago

Added check.

cstratak commented 4 years ago

Overall LGTM. Some observations to be added.

cstratak commented on line 14 of python-hypothesis.spec 4 years ago

Would a bootstrap bcond make sense here?

cstratak commented on line 41 of python-hypothesis.spec 4 years ago

Another approach would be to exclude those tests during the pytest invocation, not sure which one is more beneficial, but I guess since the dependencies are not shipped, maybe it's better to remove them.

churchyard commented on line 14 of python-hypothesis.spec 4 years ago

Well this serves as good and running the test should not change the resulting RM in any way, so we are not really bootstrapping it. Other Python packages that are bootstrapped for test only usually have this kind of bcond. See for example https://github.com/hroncok/rpm-list-builder/blob/python37/python37.yaml

churchyard commented on line 41 of python-hypothesis.spec 4 years ago

I don't think it's better or worse. Let's keep it as it is? (Less work.)

cstratak commented on line 41 of python-hypothesis.spec 4 years ago

Yes, no need to ponder over that.

cstratak commented 4 years ago

You can go ahead and merge it.

Pull-Request has been merged by churchyard

4 years ago