cc'ing @churchyard

What about: 's/1\.58/%{version}/' instead? Should last if the problem is not fixed upstream in next version.

I'd normally use: %{url}/archive/%{version}/%{name}-%{version}.tar.gz but this works as well.

+ /usr/bin/pytest
============================= test session starts ==============================
platform linux -- Python 3.9.1, pytest-6.2.2, py-1.10.0, pluggy-0.13.1
rootdir: /builddir/build/BUILD/python-memcached-1.59
collected 23 items
tests/test_memcache.py ......................                            [ 95%]
tests/test_setmulti.py .                                                 [100%]
=============================== warnings summary ===============================
memcache.py:110
  /builddir/build/BUILD/python-memcached-1.59/memcache.py:110: DeprecationWarning: invalid escape sequence \ 
    """Object representing a pool of memcache servers.
memcache.py:1303
  /builddir/build/BUILD/python-memcached-1.59/memcache.py:1303: SyntaxWarning: "is" with a literal. Did you mean "=="?
    if key is '':
memcache.py:1304
  /builddir/build/BUILD/python-memcached-1.59/memcache.py:1304: SyntaxWarning: "is" with a literal. Did you mean "=="?
    if key_extra_len is 0:
-- Docs: https://docs.pytest.org/en/stable/warnings.html
======================== 23 passed, 3 warnings in 0.25s ========================

Looks like the tests indeed run, so this is an overall improvement, thanks!

+1. Let me know if you want me to merge / build.

Keeping it in-line with the URL. I can either change both, or none, I don't like seeing those different :P

It's fixed (but not released): https://github.com/linsomniac/python-memcached/commit/7942465eba2009927e5d14b4b6dbd48b75780d80

I am afraid I don't understand. My suggestion changes the filename to contain the name + uses the %{url} macro. Which bit are you referring to?

It's fixed (but not released)

ack

Could you please bring this to upstream as well? However they seem dormant a bit.

Apologies for not explaining properly. It's more of a visual thing preference:

URL:            https://github.com/linsomniac/python-memcached
Source0:        https://github.com/linsomniac/python-memcached/archive/%{version}.tar.gz

vs

URL:            https://github.com/linsomniac/python-memcached
Source0:        %{url}/archive/%{version}/%{name}-%{version}.tar.gz

However since this is obviously a personal preference and not my package, I can modify it accordingly.

Not "my" package either, don't worry about it.

lgtm - and agree re. dormant upstream, so few hacks in .spec is fine