PR#24: Drop dependency on dask for i686 - rpms/python-pandas

rpms / python-pandas

#24 Drop dependency on dask for i686

Merged 2 months ago by zbyszek. Opened 2 months ago by gui1ty.

rpms/ gui1ty/python-pandas dask into rawhide

Drop dependency on dask for i686

Sandro • 2 months ago

9f63f05

python-pandas.spec

file modified

+9 -4

		`@@ -13,7 +13,7 @@`

		`Name: python-pandas`
		`Version: 2.2.1`
		`- Release: 1%{?dist}`
		`+ Release: 2%{?dist}`
		`Summary: Python library providing high-performance data analysis tools`

		`# The entire source is BSD-3-Clause and covered by LICENSE, except:`
		`@@ -409,8 +409,11 @@`
		`# Additional dependencies from environment.yml:`
		`# “Dask and its dependencies (that dont install with dask)”`
		`# Asks for dask-core, but we just have dask`
		`- BuildRequires: python3dist(dask)`
		`- Recommends: python3dist(dask)`
		`+ #`
		+ # Drop dependency on `dask` for i686 (package excludes i686)
		+ # This can be reverted once `pandas` drops i686
		`+ BuildRequires: (python3dist(dask) or python3(x86-32))`
		`+ Recommends: (python3dist(dask) if python3(x86-64))`
churchyard commented 2 months ago This excludes all the other architectures, right?
gui1ty commented 2 months ago We could change it to `if (python3(x86-64) or python3(aarch-64) or python3(ppc-64) or python3(s390-64))` or some lua script matching on `64`. Or we could wrap the Recommends in a `%ifnarch`. Thoughts?
		`BuildRequires: python3dist(toolz) >= 0.7.3`
		`Recommends: python3dist(toolz) >= 0.7.3`
		`BuildRequires: python3dist(partd) >= 0.3.10`
		`@@ -676,6 +679,9 @@`


		`%changelog`
		`+ * Mon Mar 11 2024 Sandro <devel@penguinpee.nl> - 2.2.1-2`
		`+ - Drop dependency on dask for i686`
		`+`
		`* Fri Feb 23 2024 Elliott Sales de Andrade <quantum.analyst@gmail.com> - 2.2.1-1`
		`- Update to 2.2.1`

		`@@ -1003,4 +1009,3 @@`

		`* Tue Jul 10 2012 Kushal Das <kushal@fedoraproject.org> 0.8.1-1`
		`- Initial release in Fedora`
		`-`

gui1ty commented 2 months ago

There's a circular dependency between both packages, that we need to
break now dask will no longer be built on i686.

Scratch builds in koji for i686 and x86_64 confirm the former no longer requires dask while the latter still does.

zuul commented 2 months ago

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/83f031ebb4b046aa9f7f8c67271a2aac

check-for-arches : SUCCESS in 2m 20s
check-for-eln : SUCCESS in 23s
rpm-scratch-build : SUCCESS in 50m 01s
rpm-scratch-build-s390x : SUCCESS in 40m 29s (non-voting)
rpm-scratch-build-ppc64le : SUCCESS in 1h 18m 09s (non-voting)
rpm-scratch-build-i686 : SUCCESS in 46m 06s (non-voting)
rpm-scratch-build-aarch64 : SUCCESS in 53m 36s (non-voting)
rpm-linter : SUCCESS in 6m 40s (non-voting)
rpm-rpminspect : FAILURE in 8m 15s (non-voting)
check-for-sti-tests : SUCCESS in 17s
check-for-fmf-tests : SUCCESS in 16s
rpm-install-test : SUCCESS in 3m 14s
Skipped 3 jobs

Pull-Request has been merged by zbyszek

2 months ago

zbyszek commented 2 months ago

I started a build for rawhide.

churchyard commented on line 20 of python-pandas.spec 2 months ago

This excludes all the other architectures, right?

zbyszek commented 2 months ago

Yeah, it's not ideal. But it's a temporary thing, so I don't think it matters too much.

gui1ty commented on line 20 of python-pandas.spec 2 months ago

We could change it to if (python3(x86-64) or python3(aarch-64) or python3(ppc-64) or python3(s390-64)) or some lua script matching on 64. Or we could wrap the Recommends in a %ifnarch. Thoughts?