PR#7: Switch to buildtime dependency generator - rpms/python-pathspec

rpms / python-pathspec

#7 Switch to buildtime dependency generator

Closed 2 years ago by rcallicotte. Opened 2 years ago by rcallicotte.

rpms/ rcallicotte/python-pathspec epel9 into epel9

Added sub-package to match packaging guidelines.

Robby Callicotte • 2 years ago

9ab5633

Changed BR to use %generate_buildrequires macro.

Robby Callicotte • 2 years ago

23044d6

python-pathspec.spec

file modified

+18 -8

		`@@ -1,21 +1,28 @@`
		`- Name: python%{python3_pkgversion}-pathspec`
		`+ Name: python-pathspec`
		`Version: 0.9.0`
		`- Release: 1%{?dist}`
		`+ Release: 2%{?dist}`
		`Summary: Utility library for gitignore style pattern matching of file paths`

		`License: MPL 2.0`
		`URL: https://github.com/cpburnz/python-path-specification`
		`Source0: https://files.pythonhosted.org/packages/source/p/pathspec/pathspec-%{version}.tar.gz`
		`BuildArch: noarch`
		`+ BuildRequires: python3-devel`

		`- %description`
		`+ %generate_buildrequires`
churchyard commented 2 years ago I don't understand why is this section here and why is it empty?
		`+`
		`+ %global _description %{expand:`
		`Path Specification (pathspec) is a utility library for pattern matching of file`
		`paths. So far this only includes Git's wildmatch pattern matching which itself`
		`- is derived from Rsync's wildmatch. Git uses wildmatch for its gitignore files.`
		`+ is derived from Rsync's wildmatch. Git uses wildmatch for its gitignore files.}`
		`+`
		`+ %description %_description`

		`- BuildRequires: python%{python3_pkgversion}-devel`
		`- BuildRequires: python%{python3_pkgversion}-setuptools`
		`- %{?python_provide:%python_provide python%{python3_pkgversion}-pathspec}`
		`+ %package -n python3-pathspec`
		`+ Summary: %{summary}`
		`+ %{?python_provide:%python_provide python3-pathspec}`
		`+`
		`+ %description -n python3-pathspec %_description`

		`%prep`
		`%autosetup -n pathspec-%{version}`
		`@@ -33,13 +40,16 @@`
		`%{__python3} setup.py test`


		`- %files`
		`+ %files -n python3-pathspec`
		`%doc README.rst`
		`%license LICENSE`
		`%{python3_sitelib}/pathspec`
		`%{python3_sitelib}/pathspec-%{version}-py%{python3_version}.egg-info`

		`%changelog`
		`+ * Fri Dec 31 2021 Robby Callicotte <rcallicotte@fedoraproject.org> - 0.9.0-2`
		`+ - Switched BR to use new macro`
		`+`
		`* Fri Dec 17 2021 Adrien Vergé <adrienverge@gmail.com> - 0.9.0-1`
		`- Update to version 0.9.0`
		`- Prepare for EPEL9`

rcallicotte commented 2 years ago

Hello,

I have added the opt-in builditime dependency generator to the spec. In addition, I have converted the spec to match the sub-package style outlined in the python packaging guidelines.

I have submitted a koji scratch build here: https://koji.fedoraproject.org/koji/taskinfo?taskID=80684775.

Please let me know if there is anything else required and I will be happy to help.

churchyard commented on line 16 of python-pathspec.spec 2 years ago

I don't understand why is this section here and why is it empty?

churchyard commented 2 years ago

Moreover, I don't really understand the existing epel9 commit at all :/

rcallicotte commented 2 years ago

My fork commit history is a bit out of sorts and I'm a bit embarrassed, so apologies for that. I see that adrienverge has update the epel9 branch with the new upstream release. I will close this PR.

Pull-Request has been closed by rcallicotte

2 years ago