#2 Add upstream integration tests
Closed 4 years ago by jcline. Opened 5 years ago by jcline.
rpms/ jcline/python-pika master  into  master

Drop Python 2 unit tests
Jeremy Cline • 4 years ago  
Add upstream integration tests
Jeremy Cline • 5 years ago  
file modified
+5 -11
@@ -7,7 +7,7 @@ 

  

  Name:           python-%{srcname}

  Version:        1.0.1

- Release:        1%{?dist}

+ Release:        2%{?dist}

  Summary:        AMQP 0-9-1 client library for Python

  

  License:        BSD
@@ -22,11 +22,6 @@ 

  # Python 2 requirements

  BuildRequires:  python2-setuptools

  BuildRequires:  python2-devel

- BuildRequires:  python2-mock

- BuildRequires:  python2-nose

- BuildRequires:  python2-tornado

- BuildRequires:  python2-coverage

- BuildRequires:  python2-twisted

  

  # Python 3 requirements

  BuildRequires:  python3-setuptools
@@ -37,10 +32,6 @@ 

  BuildRequires:  python3-twisted

  BuildRequires:  python3-tornado

  

- # for tests

- BuildRequires:  rabbitmq-server

- BuildRequires:  hostname

- BuildRequires:  procps-ng

  

  %description

  %{desc}
@@ -99,7 +90,6 @@ 

  

  

  %check

- PYTHONPATH=%{buildroot}%{python2_sitelib} nosetests-2

  PYTHONPATH=%{buildroot}%{python3_sitelib} nosetests-3

  

  
@@ -120,6 +110,10 @@ 

  

  

  %changelog

+ * Tue May 28 2019 Jeremy Cline <jcline@redhat.com> - 1.0.1-2

+ - Drop tests for Python 2 as Tornado is going away

+ - Drop integration test requirements from specfile

+ 

  * Mon Apr 15 2019 Jeremy Cline <jcline@redhat.com> - 1.0.1-1

  - Update to v1.0.1

  

file added
+1
@@ -0,0 +1,1 @@ 

+ - import_playbook: upstream_integration_tests.yml

@@ -0,0 +1,36 @@ 

+ ---

+ - hosts: localhost

+   roles:

+     - role: standard-test-basic

+       tags:

+         - classic

+       repositories:

+         - repo: "https://github.com/pika/pika.git"

+           dest: "pika"

+       required_packages:

+         - python3-nose2

+         - python3-mock

+         - python3-tornado

+         - python3-twisted

+         - rabbitmq-server

+       tasks:

+         - name: Enable the HTTP management console and SSL authentication plugins

+           rabbitmq_plugin:

+             names: "rabbitmq_management,\

+                     rabbitmq_auth_mechanism_ssl"

+ 

+         - name: Start the RabbitMQ broker

+           systemd: name=rabbitmq-server state=started

+ 

+         - name: Get the right version of the tests

+           command: git checkout 1.0.1

+ 

+         - name: Ensure we're testing the RPM installation

+           command: rm -rf pika

+ 

+         - name: Turn off the unit tests

+           command: >

+               sed -i -e s#tests=tests/unit,tests/acceptance#tests=tests/acceptance#g setup.cfg

+ 

+         - name: Run the integration tests

+           shell: nosetests-3

no initial comment

LGTM due to or except no obvious connection to normal build procedure.

Please don't merge it as the tests still don't pass, I just made a PR since that will kick off the tests.

@jcline OK I've already wondered why a PR from you. :alien:

2 new commits added

  • Drop Python 2 unit tests
  • Drop the integration test requirements
4 years ago

Pull-Request has been closed by jcline

4 years ago