e3d6d6a
@@ -90,6 +90,9 @@
%install
%py3_install
+ # Remove bundled dist/egg-info directories
+ rm -rf %{buildroot}%{python3_sitelib}/py/_vendored_packages/*.{dist,egg}-info
+
%check
%if %{with tests}
rebased onto e3d6d6a
Hi @thm, I wanted to push a commit to my forked repo to update this PR and instead I accidentally pushed to master on the main repo (with my provenpackager privileges). I should have created a new branch for this PR to avoid any mistake like this. I'm really sorry for touching your package without your permission :/
If you disagree with the change in this PR, I will revert the commit. Again, apologies :(
This is the commit I accidentally pushed to master: https://src.fedoraproject.org/rpms/python-py/c/5255af12354b411f7baa037472334b1c6ab9e11a?branch=master
Don't worry - at first sight I would think that's a reasonable change.
Not sure though whether there could be corner cases where the embedded .*{dist,egg}-info is needed?
.*{dist,egg}-info
Don't worry - at first sight I would think that's a reasonable change. Not sure though whether there could be corner cases where the embedded .*{dist,egg}-info is needed?
Actually, I found this bug when trying this spec file in RHEL/CentOS where the embedded dist-info are causing an issue. The python3-rpm-generators there has a bug where it looks at all dist-info folders (in Fedora it looks only at the top-level ones) and thus generates wrong Provides for this package.
This PR should not have any effect in Fedora, but will make the specfile safer for EL.
I don't think it is, but we'll be affected soon enough if that's that's case. I'll keep an eye on that.
Pull-Request has been closed by churchyard
