|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
torsava commented 3 years ago | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
torsava commented 3 years ago As discussed on IRC: The '-E' flag has questionable benefits, especially for upstream. | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
torsava commented 3 years ago
Noting for discussion: For new setuptools but old Python 3.6 and 3.7, which is the better default requirement - setuptools or importlib_metadata? While it's true that this script runs on importlib{.,_}metadata, it also very likely runs on newer version of Python. E.g. in Fedora we run this script on Python 3.9 or soon 3.10. The presence of importlib*metadata there is not a good predictor whether importlib_metadata is available for Python 3.6 and 3.7. And I would wager that in most old Python stacks, setuptools is much more likely to be present than importlib_metadata. | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
torsava commented 3 years ago
Minor nitpick, I think the original | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
torsava commented 3 years ago
Let's print out some error before exit? | ||
|
||
|
||
|
||
|
||
|
||
torsava commented 3 years ago
So, new version of setuptools would generate | ||
|
||
|
||
|
||
|
||
torsava commented 3 years ago
This really needs to be also on top of this file, people have brainfarts and sometimes run with sudo without checking. | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
torsava commented 3 years ago
I need more context here. | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
torsava commented 3 years ago
I need a drink :laughing: | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
torsava commented 3 years ago
By "ours" you mean it detects version of the python3-setuptools package for the main Python (now 3.9)? But Why? | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
Minor nitpick: Why each import on it's own line when other imports use a multi-import style?