#4 run test suite as part of the build process
Merged 3 years ago by limb. Opened 3 years ago by fschwarz.
Unknown source master  into  rawhide

file modified
+15 -2
@@ -4,7 +4,7 @@

  

  Name:           python-%{srcname}

  Version:        0.4.2

- Release:        1%{?dist}

+ Release:        2%{?dist}

  Summary:        Amazon S3 Transfer Manager

  

  License:        ASL 2.0
@@ -17,15 +17,21 @@

  

  %package -n python3-%{srcname}

  Summary:        %{summary}

+ 

  BuildRequires:  python3-devel

  BuildRequires:  python3-setuptools

+ # required to run the test suite

+ BuildRequires:  python3-botocore        >= 1.12.36

+ BuildRequires:  python3-botocore        < 2.0

+ BuildRequires:  python3-mock

+ BuildRequires:  python3-pytest

  

  %description -n python3-%{srcname} %{_description}

  

  Python 3 version.

  

  %prep

- %autosetup -n %{srcname}-%{version}

+ %autosetup -n %{srcname}-%{version} -p1

  rm -vrf *.egg-info

  

  %build
@@ -34,6 +40,10 @@

  %install

  %py3_install

  

+ %check

+ cd tests

+ pytest-%{python3_version} unit functional

+ 

  %files -n python3-%{srcname}

  %license LICENSE.txt

  %doc README.rst
@@ -41,6 +51,9 @@

  %{python3_sitelib}/%{srcname}-*.egg-info/

  

  %changelog

+ * Fri May 14 2021 Felix Schwarz <fschwarz@fedoraproject.org> - 0.4.2-1

+ - run test suite as part of the build process

+ 

  * Fri Apr 23 2021 Gwyn Ciesla <gwync@protonmail.com> - 0.4.2-1

  - 0.4.2

  

pretty much straightforward except one additional patch which I found in the upstream bugtracker

rebased onto 2380fd3

3 years ago

bad: I just noticed that this PR is still not merged.
good: No need for the additional patch, github PR is merged since s3transfer 0.3.5

@limb Would you mind merging this?

Pull-Request has been merged by limb

3 years ago

I just noticed that I messed up the changelog as I did not increase the release (0.4.2-1 instead of 0.4.2-2). Could you fix that or should I send a new PR?

A new PR, but just fix the CL, so we don't need to rebuild.