PR#8: BR python3-rpm-generators manually - rpms/python-wheel

rpms / python-wheel

#8 BR python3-rpm-generators manually

Merged 5 years ago by churchyard. Opened 5 years ago by churchyard.

rpms/ churchyard/python-wheel bootstrap into master

Miro Hrončok • 5 years ago

624c912

python-wheel.spec

file modified

		`@@ -55,6 +55,9 @@`
		`%package -n python3-%{pypi_name}`
		`Summary: %{summary}`
		`BuildRequires: python3-devel`
		`+ # python3 bootstrap: this is rebuilt before the final build of python3, which`
		`+ # adds the dependency on python3-rpm-generators, so we require it manually`
		`+ BuildRequires: python3-rpm-generators`
		`BuildRequires: python3-setuptools`
		`%if %{without bootstrap}`
		`BuildRequires: python3-pytest`

no initial comment

Metadata Update from @churchyard:
- Request assigned

5 years ago

torsava commented 5 years ago

LGTM!

Minor nitpick, the commit message says "BR python3-rpm-generators manually without bootstrap", but we require it in every case here, not just without bootstrap.

churchyard commented 5 years ago

You are right.

rebased onto 624c912

5 years ago

churchyard commented 5 years ago

Changed the message

torsava commented 5 years ago