#19 Update to 3.11.0a5
Merged 2 years ago by thrnciar. Opened 2 years ago by thrnciar.
rpms/ thrnciar/python3.11 update-to-3.11.0a5  into  rawhide

@@ -54,7 +54,7 @@ 

           if os.path.isdir(sitedir):

               addsitedir(sitedir, known_paths)

  diff --git a/Lib/sysconfig.py b/Lib/sysconfig.py

- index da918b7ba1..89e5c079ca 100644

+ index d4a8a68028..491f82de45 100644

  --- a/Lib/sysconfig.py

  +++ b/Lib/sysconfig.py

  @@ -58,6 +58,31 @@
@@ -90,7 +90,7 @@ 

   # NOTE: site.py has copy of this function.

   # Sync it when modify this function.

  diff --git a/Lib/test/test_sysconfig.py b/Lib/test/test_sysconfig.py

- index 506266d081..761cac2779 100644

+ index 2c4120979d..3a2901b0bf 100644

  --- a/Lib/test/test_sysconfig.py

  +++ b/Lib/test/test_sysconfig.py

  @@ -267,7 +267,7 @@ def test_get_config_h_filename(self):
@@ -102,7 +102,7 @@ 

           if HAS_USER_BASE:

               wanted.extend(['nt_user', 'osx_framework_user', 'posix_user'])

           self.assertEqual(get_scheme_names(), tuple(sorted(wanted)))

- @@ -278,6 +278,8 @@ def test_symlink(self): # Issue 7880

+ @@ -279,6 +279,8 @@ def test_symlink(self): # Issue 7880

               cmd = "-c", "import sysconfig; print(sysconfig.get_platform())"

               self.assertEqual(py.call_real(*cmd), py.call_link(*cmd))

   

@@ -33,7 +33,7 @@ 

       else:

           return PycInvalidationMode.TIMESTAMP

  diff --git a/Lib/test/test_py_compile.py b/Lib/test/test_py_compile.py

- index 5ed98dbff1..f30c4e43de 100644

+ index 794d6436b6..322e072b61 100644

  --- a/Lib/test/test_py_compile.py

  +++ b/Lib/test/test_py_compile.py

  @@ -19,6 +19,7 @@ def without_source_date_epoch(fxn):

file modified
+5 -2
@@ -14,10 +14,10 @@ 

  #  WARNING  When rebasing to a new Python version,

  #           remember to update the python3-docs package as well

  %global general_version %{pybasever}.0

- %global prerel a4

+ %global prerel a5

  %global upstream_version %{general_version}%{?prerel}

  Version: %{general_version}%{?prerel:~%{prerel}}

- Release: 2%{?dist}

+ Release: 1%{?dist}

  License: Python

  

  
@@ -1609,6 +1609,9 @@ 

  # ======================================================

  

  %changelog

+ * Fri Feb 04 2022 Tomáš Hrnčiar <thrnciar@redhat.com> - 3.11.0~a5-1

+ - Update to 3.11.0a5

+ 

  * Fri Jan 21 2022 Fedora Release Engineering <releng@fedoraproject.org> - 3.11.0~a4-2

  - Rebuilt for https://fedoraproject.org/wiki/Fedora_36_Mass_Rebuild

  

file modified
+2 -2
@@ -1,2 +1,2 @@ 

- SHA512 (Python-3.11.0a4.tar.xz) = 721ed64f3fde360e9eae6d8f8a046091c7c08f14c860572ac868132dffa4ae0a46f3f57a3872fcc096551a66e4fa3b1c87f77baa52d8524da026bbdaa74837ec

- SHA512 (Python-3.11.0a4.tar.xz.asc) = 21e56475186c3e6a029a51799cf8c86ac74d3810b5aa76e4b4bc063bacb2624b21b6ec3450dd9f91722162e57390617efb521351b11d262d6583655081277611

+ SHA512 (Python-3.11.0a5.tar.xz) = 219dc67d1968a9950a73a809335312cc2e624695503ee0e957ed0a969966376d9cc29f50a4721828fa42fb4d0fa1f4ed3595d17c8be0b8e0265bd38fa7434c94

+ SHA512 (Python-3.11.0a5.tar.xz.asc) = 3c7fb2be22dc71c4b38100dbb4ed20371782f7e7df4f02e377e6329863cc0007c1ba0d5f96b36ae46da1e452e01ccf7f66eb3abf75f746a582c8d7a96a0d0a29

no initial comment

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci

I have had trouble with Zuul on rawhide since yesterday. Ignore it, the Fedora CI passed.

Can we get rid of -i test_freeze_simple_script from tests?

rebased onto 3edb6d5c899ce6d04890465814bdc4c2fea3c432

2 years ago

Can we get rid of -i test_freeze_simple_script from tests?

I've removed it, let's see what CI says.

Seems like the test still fails.

======================================================================
ERROR: test_freeze_simple_script (test.test_tools.test_freeze.TestFreeze)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/Python-3.11.0a5/Lib/contextlib.py", line 155, in __exit__
    self.gen.throw(typ, value, traceback)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/builddir/build/BUILD/Python-3.11.0a5/Lib/test/support/os_helper.py", line 396, in temp_dir
    yield path
    ^^^^^^^^^^
  File "/builddir/build/BUILD/Python-3.11.0a5/Lib/test/test_tools/test_freeze.py", line 27, in test_freeze_simple_script
    outdir, scriptfile, python = helper.prepare(script, outdir)
                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/builddir/build/BUILD/Python-3.11.0a5/Tools/freeze/test/freeze.py", line 159, in prepare
    _run_quiet([MAKE, '-C', builddir, '-j8'])
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/builddir/build/BUILD/Python-3.11.0a5/Tools/freeze/test/freeze.py", line 25, in _run_quiet
    return subprocess.run(
           ^^^^^^^^^^^^^^^
  File "/builddir/build/BUILD/Python-3.11.0a5/Lib/subprocess.py", line 529, in run
    raise CalledProcessError(retcode, process.args,
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
subprocess.CalledProcessError: Command '['/usr/bin/make', '-C', '/tmp/tmpju_u2x82/python-build', '-j8']' returned non-zero exit status 2.
----------------------------------------------------------------------
Ran 1 test in 57.010s
FAILED (errors=1)

rebased onto 83ff9b9

2 years ago

https://bugs.python.org/issue45783 is closed and the previous error was different. we should probably investigate the new failure and report a new issue (that does not block this PR).

The update looks good otherwise. Please open this PR for other branches, so we see the CI results before we merge.

How come this built fine and suddenly it does not?

I've no idea. Seems like Fedora CI failed with the same error I've seen this morning in Zuul. It's weird because some builds passed and some didn't.

test_abs (test.test_cmath.CMathTests) ... FAIL
test_phase (test.test_cmath.CMathTests) ... FAIL
test_polar (test.test_cmath.CMathTests) ... FAIL
test_polar_errno (test.test_cmath.CMathTests) ... FAIL
test_specific_values (test.test_cmath.CMathTests) ... FAIL
test_inf_ninf_nan (test.test_cmath.IsCloseTests) ... FAIL
======================================================================
FAIL: test_abs (test.test_cmath.CMathTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/Python-3.11.0a5/Lib/test/test_cmath.py", line 516, in test_abs
    self.assertTrue(math.isnan(abs(complex(NAN, -2.3))))
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: False is not true
======================================================================
FAIL: test_phase (test.test_cmath.CMathTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/Python-3.11.0a5/Lib/test/test_cmath.py", line 503, in test_phase
    self.assertTrue(math.isnan(phase(z)))
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: False is not true
======================================================================
FAIL: test_polar (test.test_cmath.CMathTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/Python-3.11.0a5/Lib/test/test_cmath.py", line 450, in test_polar
    self.check_polar(polar)
    ^^^^^^^^^^^^^^^^^^^^^^^
  File "/builddir/build/BUILD/Python-3.11.0a5/Lib/test/test_cmath.py", line 441, in check_polar
    check(complex(nan, 0), (nan, nan))
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/builddir/build/BUILD/Python-3.11.0a5/Lib/test/test_cmath.py", line 425, in check
    self.rAssertAlmostEqual(e, g)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/builddir/build/BUILD/Python-3.11.0a5/Lib/test/test_cmath.py", line 116, in rAssertAlmostEqual
    self.fail(msg or '{!r} should be nan'.format(b))
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 0.0 should be nan
======================================================================
FAIL: test_polar_errno (test.test_cmath.CMathTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/Python-3.11.0a5/Lib/test/test_cmath.py", line 462, in test_polar_errno
    self.check_polar(polar_with_errno_set)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/builddir/build/BUILD/Python-3.11.0a5/Lib/test/test_cmath.py", line 441, in check_polar
    check(complex(nan, 0), (nan, nan))
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/builddir/build/BUILD/Python-3.11.0a5/Lib/test/test_cmath.py", line 425, in check
    self.rAssertAlmostEqual(e, g)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/builddir/build/BUILD/Python-3.11.0a5/Lib/test/test_cmath.py", line 116, in rAssertAlmostEqual
    self.fail(msg or '{!r} should be nan'.format(b))
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 0.0 should be nan
======================================================================
FAIL: test_specific_values (test.test_cmath.CMathTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/Python-3.11.0a5/Lib/test/test_cmath.py", line 418, in test_specific_values
    self.rAssertAlmostEqual(expected.imag, actual.imag,
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/builddir/build/BUILD/Python-3.11.0a5/Lib/test/test_cmath.py", line 116, in rAssertAlmostEqual
    self.fail(msg or '{!r} should be nan'.format(b))
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: acos1004: acos(complex(0.0, nan))
Expected: complex(1.5707963267948966, nan)
Received: complex(1.5707963267948966, 0.0)
Received value insufficiently close to expected value.
======================================================================
FAIL: test_inf_ninf_nan (test.test_cmath.IsCloseTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/Python-3.11.0a5/Lib/test/test_math.py", line 2196, in test_inf_ninf_nan
    self.assertAllNotClose(not_close_examples, abs_tol=0.999999999999999)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/builddir/build/BUILD/Python-3.11.0a5/Lib/test/test_math.py", line 2139, in assertAllNotClose
    self.assertIsNotClose(a, b, *args, **kwargs)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/builddir/build/BUILD/Python-3.11.0a5/Lib/test/test_math.py", line 2130, in assertIsNotClose
    self.assertFalse(self.isclose(a, b, *args, **kwargs),
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: True is not false : nan and nan should not be close!
----------------------------------------------------------------------
Ran 6 tests in 0.008s
FAILED (failures=6)
test test_cmath failed
0:02:52 load avg: 1.79 Re-running test_complex in verbose mode (matching: test_truediv)
test_truediv (test.test_complex.ComplexTest) ... FAIL
======================================================================
FAIL: test_truediv (test.test_complex.ComplexTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/Python-3.11.0a5/Lib/test/test_complex.py", line 115, in test_truediv
    self.assertTrue(isnan(z.real))
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: False is not true
----------------------------------------------------------------------
Ran 1 test in 0.051s
FAILED (failures=1)
test test_complex failed
0:02:52 load avg: 1.79 Re-running test_math in verbose mode (matching: testAtan2, testDist, testHypot, testRemainder)
testAtan2 (test.test_math.MathTests) ... FAIL
testDist (test.test_math.MathTests) ... FAIL
testHypot (test.test_math.MathTests) ... FAIL
testRemainder (test.test_math.MathTests) ... FAIL
======================================================================
FAIL: testAtan2 (test.test_math.MathTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/Python-3.11.0a5/Lib/test/test_math.py", line 334, in testAtan2
    self.assertTrue(math.isnan(math.atan2(0., NAN)))
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: False is not true
======================================================================
FAIL: testDist (test.test_math.MathTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/Python-3.11.0a5/Lib/test/test_math.py", line 991, in testDist
    self.assertTrue(math.isnan(dist(p, q)))
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: False is not true
======================================================================
FAIL: testHypot (test.test_math.MathTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/Python-3.11.0a5/Lib/test/test_math.py", line 815, in testHypot
    self.assertTrue(math.isnan(hypot(NAN)))
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: False is not true
======================================================================
FAIL: testRemainder (test.test_math.MathTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/Python-3.11.0a5/Lib/test/test_math.py", line 1495, in testRemainder
    with self.assertRaises(ValueError):
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: ValueError not raised
----------------------------------------------------------------------

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci

How come this built fine and suddenly it does not?

The buildroot is the same:

$ diff <(koji list-buildroot 32911778) <(koji list-buildroot 32912410)
$ echo $?
0

The SRPMs are the same:

$ rpmdiff python3.11-3.11.0~a5-1.fc36.src*
..........T 00001-rpath.patch
..........T 00251-change-user-install-location.patch
..........T 00328-pyc-timestamp-invalidation-mode.patch
..........T check-pyc-timestamps.py
..........T idle3.appdata.xml
..........T idle3.desktop
..........T pgp_keys.asc
..........T python3.11.spec

The only remaining thing that AFAIK might be different is the builder itself (e.g. the kernel).

success: kernel version == 5.15.6-200.fc35.x86_64
failure: kernel version == 5.15.18-200.fc35.x86_64

The buildroot is the same:

$ diff <(koji list-buildroot 32911778) <(koji list-buildroot 32912410) $ echo $? 0

This was false claim. Both outputs are empty for some reasons :D

GCC was updated from -0.4 to -0.5.

The CI is happy otherwise. Let's merge all 3 PRs and build in f35 and f34, so packagers can easily install this. We could also tag an older version of gcc to a rawhide side tag if the regression isn't solved promptly.

Pull-Request has been merged by thrnciar

2 years ago

About test_math and test_cmath, it's a GCC regression. I reported it to GCC upstream: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104389