#78 Update the license tag to SPDX
Merged 2 years ago by churchyard. Opened 2 years ago by churchyard.
rpms/ churchyard/python3.11 spdx  into  rawhide

file modified
+1 -1
@@ -18,7 +18,7 @@ 

  %global upstream_version %{general_version}%{?prerel}

  Version: %{general_version}%{?prerel:~%{prerel}}

  Release: 1%{?dist}

- License: Python

+ License: Python-2.0.1

  

  

  # ==================================

See https://gitlab.com/fedora/legal/fedora-license-data/-/merge_requests/61

The LICENSE file differs from the text at https://spdx.org/licenses/Python-2.0.1.html
only by:

  • not saying "Python 2.0.1" but "Python" which is considered OK
  • copyright years which is considered OK
  • formatting
  • listing the history and license for code examples from the documentation
    (the documentation is not shipped via this package)

Blocked by https://gitlab.com/fedora/legal/fedora-license-data/-/merge_requests/61#note_1074288284

Depended on: https://src.fedoraproject.org/rpms/fedora-license-data/pull-request/10

Build succeeded.

rebased onto 909d90686e19421ec9d99a567589145ce3f9cf42

2 years ago

Build succeeded.

rpminspect is now a success. rpmlint warns with:

python-unversioned-command.noarch: W: invalid-license Python-2.0.1
python3.x86_64: W: invalid-license Python-2.0.1
python3-debug.x86_64: W: invalid-license Python-2.0.1
python3-devel.x86_64: W: invalid-license Python-2.0.1
python3-idle.x86_64: W: invalid-license Python-2.0.1
python3-libs.x86_64: W: invalid-license Python-2.0.1
python3-test.x86_64: W: invalid-license Python-2.0.1
python3-tkinter.x86_64: W: invalid-license Python-2.0.1
python3.11.src: W: invalid-license Python-2.0.1
python3.11-debuginfo.x86_64: W: invalid-license Python-2.0.1
python3.11-debugsource.x86_64: W: invalid-license Python-2.0.1
python3.11-debugsource.x86_64: W: files-duplicate /usr/src/debug/python3.11-3.11.0~rc1-2.fc38.x86_64/build/optimized/Include/pydtrace_probes.h /usr/src/debug/python3.11-3.11.0~rc1-2.fc38.x86_64/build/debug/Include/pydtrace_probes.h
python3.11-debugsource.x86_64: W: files-duplicate /usr/src/debug/python3.11-3.11.0~rc1-2.fc38.x86_64/build/optimized/Modules/config.c /usr/src/debug/python3.11-3.11.0~rc1-2.fc38.x86_64/build/debug/Modules/config.c
python3.11-debugsource.x86_64: W: files-duplicate /usr/src/debug/python3.11-3.11.0~rc1-2.fc38.x86_64/build/optimized/Python/deepfreeze/deepfreeze.c /usr/src/debug/python3.11-3.11.0~rc1-2.fc38.x86_64/build/debug/Python/deepfreeze/deepfreeze.c
python3.11-debugsource.x86_64: W: files-duplicate /usr/src/debug/python3.11-3.11.0~rc1-2.fc38.x86_64/build/optimized/Python/frozen_modules/getpath.h /usr/src/debug/python3.11-3.11.0~rc1-2.fc38.x86_64/build/debug/Python/frozen_modules/getpath.h
 11 packages and 1 specfiles checked; 0 errors, 15 warnings, 0 badness; has taken 30.9 s

I will open a separate PR to filter files-duplicate from debugsource. Licenses "blocked" on https://gitlab.com/fedora/legal/fedora-license-data/-/merge_requests/76

I will open a separate PR to filter files-duplicate from debugsource.

Turned out to be a typo: https://src.fedoraproject.org/rpms/python3.11/pull-request/79

rebased onto 2d80073

2 years ago

Build succeeded.

The rpmlint update is https://bodhi.fedoraproject.org/updates/FEDORA-2022-7d27077fed -- we need it stable and we need the Zuul job to install it.

Build succeeded.

Looks good, but should we also include licences of the incorporated software? For some we use system libraries, but not for all.

but should we also include licences of the incorporated software? For some we use system libraries, but not for all.

I agree that we should, but I'd rather update to SPDX first and track this as a possible improvement, as I am afraid we might hit some roadblocks there if some of the licenses don't have SPDX identifiers yet.

Is that alright?

Definitely! Go ahead and merge.

Pull-Request has been merged by churchyard

2 years ago
Metadata