#106 symlink for python3.7m man pages
Merged a month ago by churchyard. Opened a month ago by pkopkan.
https://pagure.io/python3.git master  into  master

add symlink for python3.Xm manpages
Patrik Kopkan • a month ago  
python3.spec
file modified
+7 -1

@@ -17,7 +17,7 @@

  #global prerel ...

  %global upstream_version %{general_version}%{?prerel}

  Version: %{general_version}%{?prerel:~%{prerel}}

- Release: 1%{?dist}

+ Release: 2%{?dist}

  License: Python

  

  

@@ -901,6 +901,9 @@

  # See https://bugzilla.redhat.com/show_bug.cgi?id=1111275

  mv %{buildroot}%{_bindir}/2to3-%{pybasever} %{buildroot}%{_bindir}/2to3

  

+ # make man python3.Xm work https://bugzilla.redhat.com/show_bug.cgi?id=1612241

+ ln -s ./python%{pybasever}.1 %{buildroot}%{_mandir}/man1/python%{pybasever}m.1

+ 

  %if %{with flatpackage}

  # Remove stuff that would conflict with python3 package

  rm %{buildroot}%{_bindir}/python3

@@ -1491,6 +1494,9 @@

  # ======================================================

  

  %changelog

+ * Wed Apr 17 2019 Patrik Kopkan <pkopkan@redhat.com> - 3.7.3-2

+ - Makes man python3.7m show python3.7 man pages (#1612241)

+ 

  * Wed Mar 27 2019 Miro Hrončok <mhroncok@redhat.com> - 3.7.3-1

  - Update to 3.7.3

  

no initial comment

Let's see what the CI thinks. The patch looks sane.

As a style thing, I suggest to move the added block above the flatpackage removals, so removing stuff remains the last thing.

Also, as a convention, we tend to use full bugzilla URLs in the specfilea and only use shortcuts in the %changelog.

Would you like to bring this to upstream an eventually make their makefile stuff do this for us?

Side note: As a packager, you should now be able to fork this repo and use the forked repo instead of Remote Pull Request.

Metadata Update from @churchyard:
- Pull-request tagged with: feature
- Request assigned

a month ago

rebased onto 8f86cfe

a month ago
<mock-chroot> sh-5.0# rpm -q python3
python3-3.7.3-2.fc31.x86_64
<mock-chroot> sh-5.0# rpm -q python3 --changelog | head -n2
* Wed Apr 17 2019 Patrik Kopkan <pkopkan@redhat.com> - 3.7.3-2
- Makes man python3.7m show python3.7 man pages (#1612241)
<mock-chroot> sh-5.0# man python3.7m
PYTHON(1)               General Commands Manual               PYTHON(1)

NAME
       python - an interpreted, interactive, object-oriented programming language
...
<mock-chroot> sh-5.0# rpm -qf /usr/share/man/man1/python3.7m.1.gz 
python3-3.7.3-2.fc31.x86_64
<mock-chroot> sh-5.0# file /usr/share/man/man1/python3.7m.1.gz 
/usr/share/man/man1/python3.7m.1.gz: symbolic link to ./python3.7.1.gz

The change looks good. I'd like to get the CI to integrate, but if it doesn't, no big deal, this should not break things.

Metadata Update from @churchyard:
- Pull-request tagged with: merge - rebase - CI
- Request assigned

a month ago
./findleaks.sh: line 18: 19657 Killed                  $PYTHON -m test -wW --findleaks $X

This is tracked in https://bugzilla.redhat.com/show_bug.cgi?id=1677584

Pull-Request has been merged by churchyard

a month ago

Would you like to bring this to upstream an eventually make their makefile stuff do this for us?

See also https://bugs.python.org/issue36707 which renders this irrelevant.