#130 Enable Profile-guided optimization for all arches
Closed a month ago by churchyard. Opened a month ago by churchyard.
rpms/ churchyard/python3 optimize_all_arches  into  master

file modified
+4 -7

@@ -17,7 +17,7 @@ 

  %global prerel b3

  %global upstream_version %{general_version}%{?prerel}

  Version: %{general_version}%{?prerel:~%{prerel}}

- Release: 3%{?dist}

+ Release: 4%{?dist}

  License: Python

  

  

@@ -52,13 +52,7 @@ 

  %bcond_without rpmwheels

  

  # Expensive optimizations (mainly, profile-guided optimizations)

- %ifarch %{ix86} x86_64

  %bcond_without optimizations

- %else

- # On some architectures, the optimized build takes tens of hours, possibly

- # longer than Koji's 24-hour timeout. Disable optimizations here.

- %bcond_with optimizations

- %endif

  

  # Run the test suite in %%check

  %bcond_without tests

@@ -1528,6 +1522,9 @@ 

  # ======================================================

  

  %changelog

+ * Thu Aug 15 2019 Miro Hrončok <mhroncok@redhat.com> - 3.8.0~b3-4

+ - Enable Profile-guided optimization for all arches, not just x86 (#1741015)

+ 

  * Wed Aug 14 2019 Miro Hrončok <mhroncok@redhat.com> - 3.8.0~b3-3

  - Rebuilt for Python 3.8

  

This increases the build time (to ~2 hours on armv7hl Koji),
but should bring more optimized Python to architectures other than x86.

The build time overhead is not so big on Python 3.8,
as only a limited number of tests is used.

Resolves https://bugzilla.redhat.com/show_bug.cgi?id=1741015

Koji scratch build in 3.8 side tag: https://koji.fedoraproject.org/koji/taskinfo?taskID=37056659

Would you mind to specify that previously it was only enabled on x86 and x86-64?

I concur with https://bugzilla.redhat.com/show_bug.cgi?id=1741015 rationale, so this change LGTM. I just made small request on the changelog entry.

It seems the CI infra has some issues related to the cloud image.

The change itself LGTM, I'd add Victor's suggestion and then merge it.

The CI cannot work. 3.8 side tag is not yet merged.

changelog entry amended.

rebased onto 7b9cec6

a month ago

LGTM as well. Merge at will.

Merged manually, the Merge button is not working.

Pull-Request has been closed by churchyard

a month ago