#156 Fix faulthandler._stack_overflow() on GCC 10
Closed 2 months ago by churchyard. Opened 2 months ago by cstratak.
rpms/ cstratak/python3 gcc10fix  into  master

file modified
+11 -1

@@ -17,7 +17,7 @@ 

  #global prerel ...

  %global upstream_version %{general_version}%{?prerel}

  Version: %{general_version}%{?prerel:~%{prerel}}

- Release: 3%{?dist}

+ Release: 4%{?dist}

  License: Python

  

  

@@ -278,6 +278,12 @@ 

  # Ideally, we should talk to upstream and explain why we don't want this

  Patch328: 00328-pyc-timestamp-invalidation-mode.patch

  

+ # 00338 #

+ # test_stack_overflow from test_faulthandler hangs when python

+ # has been compiled with gcc 10.

+ # Fixed upstream: https://bugs.python.org/issue38965

+ Patch338: 00338-fix-faulthandler._stack_overflow-on-gcc10.patch

+ 

  # (New patches go here ^^^)

  #

  # When adding new patches to "python" and "python3" in Fedora, EL, etc.,

@@ -625,6 +631,7 @@ 

  %patch251 -p1

  %patch274 -p1

  %patch328 -p1

+ %patch338 -p1

  

  

  # Remove files that should be generated by the build

@@ -1569,6 +1576,9 @@ 

  # ======================================================

  

  %changelog

+ * Fri Dec 06 2019 Charalampos Stratakis <cstratak@redhat.com> - 3.8.0-4

+ - Fix faulthandler._stack_overflow() on GCC 10

+ 

  * Tue Dec 03 2019 Miro Hrončok <mhroncok@redhat.com> - 3.8.0-3

  - Build Python with -fno-semantic-interposition for better performance

  - https://fedoraproject.org/wiki/Changes/PythonNoSemanticInterpositionSpeedup

no initial comment

gcc 10 will go soon into rawhide, however the toolchain team does weekly snapshots of Fedora before deploying the new compiler. Python hangs due to this issue which can then lead to big parts of the distro, down the dependency chain, not being testable.

push to https://github.com/fedora-python/cpython/tree/fedora-3.8 ?

Apart of that: the change LGTM. The change is already in 3.7, 3.8 and master branches upstream: https://bugs.python.org/issue38965 It's just a temporary practical solution until 3.8.1 becomes available.

rebased onto 673dd77

2 months ago

3.8.1rc1 should contain the fix. Let's just update instead?

Pull-Request has been closed by churchyard

2 months ago