...for Python

this should now be part of python3-devel. it should also conflict with python3-tools < (hardcoded current version)

something still needs to obsolete this. maybe just the python3 packages, maybe devel, that's not that important.

or even idle for consistency

This needs more love. What about:

IDLE is Python’s Integrated Development and Learning Environment.

IDLE has the following features: Python shell window (interactive interpreter) with colorizing of code input, output, and error messages. Multi-window text editor with multiple undo, Python colorizing, smart indent, call tips, auto completion, and other features. Search within any window, replace within editor windows, and search through multiple files (grep). Debugger with persistent breakpoints, stepping, and viewing of global and local namespaces
configuration, browsers, and other dialogs.

(From https://docs.python.org/3/library/idle.html)

Thanks for the review! I have fixed the above comments in the last commit.

it should also conflict with python3-tools < (hardcoded current version)

So when the conflict usually should be removed? in around 3 releases?

So when the conflict usually should be removed? in around 3 releases?

Assuming this will get into Fedora 28 but not 27. N+2 upgrades are supported, so when users upgrade form F27 to F29 they need the conflict. It's safe to remove it once F30 is branched.

Assuming this will get into Fedora 28 but not 27. N+2 upgrades are supported, so when users upgrade form F27 to F29 they need the conflict. It's safe to remove it once F30 is branched.

Thanks for explanation. Will add a todo comment

Rebased, Koji scratch build without flatpackage: https://koji.fedoraproject.org/koji/taskinfo?taskID=24303812

Some sanity checks failed...

$ rpm -qpl python37-idle-3.7.0-0.4.a4.fc28.x86_64.rpm 
...
/usr/lib64/python3.7/idlelib/CREDITS.txt
/usr/lib64/python3.7/idlelib/ChangeLog
/usr/lib64/python3.7/idlelib/HISTORY.txt
/usr/lib64/python3.7/idlelib/NEWS.txt
/usr/lib64/python3.7/idlelib/NEWS2x.txt
/usr/lib64/python3.7/idlelib/README.txt
/usr/lib64/python3.7/idlelib/TODO.txt

Shouldn't those go into idle's %doc? With NEWS2x.txt completely removed (it's about python 2.7). (This is just a question, not a blocker, but while we are moving things around...) (Note: check if those are not loaded on runtime before moving it into doc.)

$ rpm -qp --requires python37-idle-3.7.0-0.4.a4.fc28.x86_64.rpm | grep -v rpmlib
/usr/bin/python3.7
python37 = 3.7.0-0.4.a4.fc28
python37-tkinter = 3.7.0-0.4.a4.fc28

$ rpm -qp --obsoletes python37-idle-3.7.0-0.4.a4.fc28.x86_64.rpm 
platform-python-tools < 3.6.2-20
python37-tools < 3.7.0-0.4.a4.fc28

$ rpm -qp --provides python37-idle-3.7.0-0.4.a4.fc28.x86_64.rpm 
application()
application(idle3.desktop)
idle3 = 3.7.0-0.4.a4.fc28
metainfo()
metainfo(idle3.appdata.xml)
mimehandler(text/x-python)
python37-idle = 3.7.0-0.4.a4.fc28
python37-idle(x86-64) = 3.7.0-0.4.a4.fc28
python37-tools = 3.7.0-0.4.a4.fc28
python37-tools(x86-64) = 3.7.0-0.4.a4.fc28

OK.

$ rpm -qpvl python37-devel-3.7.0-0.4.a4.fc28.x86_64.rpm | grep 2to3
lrwxrwxrwx    1 root    root                        8 Jan 19 19:12 /usr/bin/2to3 -> 2to3-3.7

Not OK (it's a link to a file that is not there; instead of removing 2to3-3.7, is should be renamed to 2to3). (This was probably already broken, but should be fixed.)

$ rpm -qp --requires python37-devel-3.7.0-0.4.a4.fc28.x86_64.rpm | grep -v rpmlib
/bin/sh
/usr/bin/env
/usr/bin/pkg-config
/usr/bin/python3.7m
libpython3.7m.so.1.0()(64bit)
python-rpm-macros
python3-rpm-generators
python3-rpm-macros
python37 = 3.7.0-0.4.a4.fc28
python37-libs(x86-64) = 3.7.0-0.4.a4.fc28
redhat-rpm-config

$ rpm2cpio python37-devel-3.7.0-0.4.a4.fc28.x86_64.rpm | cpio -idmv
...

$ grep -r 'env python' usr
usr/bin/pathfix.py:#!/usr/bin/env python3

Not OK. This is broken by removing %{buildroot}%{pylibdir}/Tools/scripts/*-*.py from the pathfix call.
You can play around with the order and add already copied %{buildroot}%{_bindir}/pathfix.py as an argument of the pathfix call (or don't, because it should be pulled automatically with the %{buildroot} arg, but better be explicit).

$ rpm -qp --conflicts python37-devel-3.7.0-0.4.a4.fc28.x86_64.rpm 
python-tools < 2.7.13-17
python2-tools < 2.7.13-17
python3-tools < 3.7.0-0.4.a4
python37 < 3.7.0-0.4.a4.fc28

I think that the exact version for python3-tools conflict here doesn't make much sense.
If we decide to backport this to python3 3.6, it will have to be adjusted there.
For flatpackage python37 it doesn't happen, for non-flat python3 3.7 this will only make sense once 3.7 hits rawhide and that would be later than alpha versions, so I'll be less specific here and say < 3.7.

$ rpm -qp --provides python37-devel-3.7.0-0.4.a4.fc28.x86_64.rpm | grep 2to3
2to3 = 3.7.0-0.4.a4.fc28
python37-2to3 = 3.7.0-0.4.a4.fc28

OK.

Shouldn't those go into idle's %doc? With NEWS2x.txt completely removed (it's about python 2.7). (This is just a question, not a blocker, but while we are moving things around...) (Note: check if those are not loaded on runtime before moving it into doc.)

Most of those files are indeed loaded on runtime for idle Help/About. More info here: https://github.com/python/cpython/blob/master/Lib/idlelib/README.txt#L95

I believe to doc we can move only HISTORY.txt, TODO.txt, extend.txt. Do you think it is worth it?

$ rpm -qpvl python37-devel-3.7.0-0.4.a4.fc28.x86_64.rpm | grep 2to3 lrwxrwxrwx 1 root root 8 Jan 19 19:12 /usr/bin/2to3 -> 2to3-3.7

Not OK (it's a link to a file that is not there; instead of removing 2to3-3.7, is should be renamed to 2to3). (This was probably already broken, but should be fixed.)

Changed, fixup

$ rpm -qp --requires python37-devel-3.7.0-0.4.a4.fc28.x86_64.rpm | grep -v rpmlib /bin/sh /usr/bin/env

Not OK. This is broken by removing %{buildroot}%{pylibdir}/Tools/scripts/-.py from the pathfix call.
You can play around with the order and add already copied %{buildroot}%{_bindir}/pathfix.py as an argument of the pathfix call (or don't, because it should be pulled automatically with the %{buildroot} arg, but better be explicit).

I moved the pathfix.py installation before the pathfix call on %{buildroot}. I do not think we should add another explicit argument to pathfix.py, because then %{buildroot}%{_bindir}/pathfix.py will be converted twice, with no change message the second time. I know it's just one extra call with no harm, but it seems wrong.

fixup

$ rpm -qp --conflicts python37-devel-3.7.0-0.4.a4.fc28.x86_64.rpm
python3-tools < 3.7.0-0.4.a4

I think that the exact version for python3-tools conflict here doesn't make much sense.
If we decide to backport this to python3 3.6, it will have to be adjusted there.
For flatpackage python37 it doesn't happen, for non-flat python3 3.7 this will only make sense once 3.7 hits rawhide and that would be later than alpha versions, so I'll be less specific here and say < 3.7.

Right, changed to Conflicts: python3-tools < 3.7, fixup

Building a non flat package: https://koji.fedoraproject.org/koji/taskinfo?taskID=24471107

Note, to do a build I had to apply the latest commits from python3 package, otherwise python37 currently fails to build.
I have ported the commits in my branch here: https://src.fedoraproject.org/fork/ishcherb/rpms/python37/commits/sync-with-python3
I can do a separate PR from that branch if needed.

# There's no point of having this, as decided in
# https://bugzilla.redhat.com/show_bug.cgi?id=1111275
mv %{buildroot}%{_bindir}/2to3-%{pybasever} %{buildroot}%{_bindir}/2to3

This needs to be reworded a bit, the comment is confusing.

I'll do sanity checks later.

Note, to do a build I had to apply the latest commits from python3 package, otherwise python37 currently fails to build.
I have ported the commits in my branch here: https://src.fedoraproject.org/fork/ishcherb/rpms/python37/commits/sync-with-python3
I can do a separate PR from that branch if needed.

@cstratak beware of that part not to duplicate this.

I believe to doc we can move only HISTORY.txt, TODO.txt, extend.txt. Do you think it is worth it?

Probably not.

$ rpm -qpvl python37-devel-3.7.0-0.7.a4.fc28.x86_64.rpm | grep 2to3
-rwxr-xr-x    1 root    root                       95 led 26 18:32 /usr/bin/2to3

$ rpm -qp --requires python37-devel-3.7.0-0.7.a4.fc28.x86_64.rpm | grep -v rpmlib
/bin/sh
/usr/bin/pkg-config
/usr/bin/python3.7
/usr/bin/python3.7m
libpython3.7m.so.1.0()(64bit)
python-rpm-macros
python3-rpm-generators
python3-rpm-macros
python37 = 3.7.0-0.7.a4.fc28
python37-libs(x86-64) = 3.7.0-0.7.a4.fc28
redhat-rpm-config

$ rpm -qp --conflicts python37-devel-3.7.0-0.7.a4.fc28.x86_64.rpm 
python-tools < 2.7.13-17
python2-tools < 2.7.13-17
python3-tools < 3.7
python37 < 3.7.0-0.7.a4.fc28

Merged as dc669ab