diff --git a/00351-avoid-infinite-loop-in-the-tarfile-module.patch b/00351-avoid-infinite-loop-in-the-tarfile-module.patch new file mode 100644 index 0000000..996fcfc --- /dev/null +++ b/00351-avoid-infinite-loop-in-the-tarfile-module.patch @@ -0,0 +1,67 @@ +From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 +From: "Miss Islington (bot)" + <31488909+miss-islington@users.noreply.github.com> +Date: Wed, 15 Jul 2020 05:35:08 -0700 +Subject: [PATCH] 00351: Avoid infinite loop in the tarfile module + +Avoid infinite loop when reading specially crafted TAR files using the tarfile module +(CVE-2019-20907). +Fixed upstream: https://bugs.python.org/issue39017 +--- + Lib/tarfile.py | 2 ++ + Lib/test/recursion.tar | Bin 0 -> 516 bytes + Lib/test/test_tarfile.py | 7 +++++++ + .../2020-07-12-22-16-58.bpo-39017.x3Cg-9.rst | 1 + + 4 files changed, 10 insertions(+) + create mode 100644 Lib/test/recursion.tar + create mode 100644 Misc/NEWS.d/next/Library/2020-07-12-22-16-58.bpo-39017.x3Cg-9.rst + +diff --git a/Lib/tarfile.py b/Lib/tarfile.py +index 3b596cbf49..3be5188c8b 100755 +--- a/Lib/tarfile.py ++++ b/Lib/tarfile.py +@@ -1233,6 +1233,8 @@ class TarInfo(object): + + length, keyword = match.groups() + length = int(length) ++ if length == 0: ++ raise InvalidHeaderError("invalid header") + value = buf[match.end(2) + 1:match.start(1) + length - 1] + + # Normally, we could just use "utf-8" as the encoding and "strict" +diff --git a/Lib/test/recursion.tar b/Lib/test/recursion.tar +new file mode 100644 +index 0000000000000000000000000000000000000000..b8237251964983f54ed1966297e887636cd0c5f4 +GIT binary patch +literal 516 +zcmYdFPRz+kEn=W0Fn}74P8%Xw3X=l~85kIuo0>8xq$A1Gm}!7)KUsFc41m#O8A5+e +I1_}|j06>QaCIA2c + +literal 0 +HcmV?d00001 + +diff --git a/Lib/test/test_tarfile.py b/Lib/test/test_tarfile.py +index 5e4d75ecfc..9133d60e49 100644 +--- a/Lib/test/test_tarfile.py ++++ b/Lib/test/test_tarfile.py +@@ -395,6 +395,13 @@ class CommonReadTest(ReadTest): + with self.assertRaisesRegex(tarfile.ReadError, "unexpected end of data"): + tar.extractfile(t).read() + ++ def test_length_zero_header(self): ++ # bpo-39017 (CVE-2019-20907): reading a zero-length header should fail ++ # with an exception ++ with self.assertRaisesRegex(tarfile.ReadError, "file could not be opened successfully"): ++ with tarfile.open(support.findfile('recursion.tar')) as tar: ++ pass ++ + class MiscReadTestBase(CommonReadTest): + def requires_name_attribute(self): + pass +diff --git a/Misc/NEWS.d/next/Library/2020-07-12-22-16-58.bpo-39017.x3Cg-9.rst b/Misc/NEWS.d/next/Library/2020-07-12-22-16-58.bpo-39017.x3Cg-9.rst +new file mode 100644 +index 0000000000..ad26676f8b +--- /dev/null ++++ b/Misc/NEWS.d/next/Library/2020-07-12-22-16-58.bpo-39017.x3Cg-9.rst +@@ -0,0 +1 @@ ++Avoid infinite loop when reading specially crafted TAR files using the tarfile module (CVE-2019-20907). diff --git a/python37.spec b/python37.spec index 675e201..3e17035 100644 --- a/python37.spec +++ b/python37.spec @@ -17,7 +17,7 @@ URL: https://www.python.org/ #%%global prerel rc1 %global upstream_version %{general_version}%{?prerel} Version: %{general_version}%{?prerel:~%{prerel}} -Release: 1%{?dist} +Release: 2%{?dist} License: Python @@ -302,6 +302,14 @@ Patch316: 00316-mark-bdist_wininst-unsupported.patch # when $RPM_BUILD_ROOT is set (i.e. when we are building RPM packages). Patch328: 00328-pyc-timestamp-invalidation-mode.patch +# 00351 # 62210578a7157342bd7cbf426f8934da31773c4d +# Avoid infinite loop in the tarfile module +# +# Avoid infinite loop when reading specially crafted TAR files using the tarfile module +# (CVE-2019-20907). +# Fixed upstream: https://bugs.python.org/issue39017 +Patch351: 00351-avoid-infinite-loop-in-the-tarfile-module.patch + # (New patches go here ^^^) # # When adding new patches to "python" and "python3" in Fedora, EL, etc., @@ -1539,6 +1547,10 @@ CheckPython optimized # ====================================================== %changelog +* Tue Jul 28 2020 Charalampos Stratakis - 3.7.8-2 +- Avoid infinite loop when reading specially crafted TAR files (CVE-2019-20907) +Resolves: rhbz#1856481 + * Tue Jun 30 2020 Petr Viktorin - 3.7.8-1 - Update to 3.7.8 final