test_asyncio and test_hashlib failures, both unrelated.

The change itself looks good. However, I think this needs to be entangled with the rpmwheels bcond as well. Because when bootstrapping, you can't use the rpm wheels yet.

Let's put the definition of the bootstrap bcond above rpmwheels bcond, and let's set rpmwheels to negative when bootstrapping?

I was thinking about that but it depends on your bootstrapping conditions a lot.

In Fedora proper, when you rebuild setuptools/pip/wheel without wheels, you lost the packages from the repo and python3 won't install.

In Copr on the other hand, , when you rebuild setuptools/pip/wheel without wheels, you can still install the previous version of the wheels and you don't really care that they have been built with Python 3.N-1.

Maybe this just deserves a comment?

Ok, that sounds fair. I would put the 2 bconds next to each other, and comment that in most cases you should flip both.

However, are you sure that in Copr you can install the previous version? I thought it was not possible.

Pretty sure because I've forgot to flip the switch :)

You get the wheels from the Fedora repo, they are Python version agnostic and they don't any requirement on the nonwheel package that would prevent them to install.

Ah :)

Ok, how about a comment:

# When bootstrapping python3, we need to build setuptools.
# but setuptools BR python3-devel and that brings in python3-rpm-generators;
# python3-rpm-generators needs python3-setuptools, so we cannot have it yet.
# Procedure: https://fedoraproject.org/wiki/SIGs/Python/UpgradingPython
#
#   IMPORTANT: When bootstrapping, it's very likely the wheels for pip and
#   setuptools are not available. Turn off also the `rpmwheels` bcond until
#   the two packages are built with wheels to get around the issue.

Sounds good.

Amended.

Looks good.

I noticed one last thing, there's randomly placed comment in the spec:

# Notes from bootstraping Python 3.7:
# https://fedoraproject.org/wiki/SIGs/Python/UpgradingPython

Let's delete it, as the link is already in your comment about the bcond?

That's just a nitpick though. Feel free to merge!

A very good nitpick. Amended.

Perfect. Ship it!

Thanks. Will ship it in late May.