|
 |
eff9421 |
From af483cb870ad81dce8e10215e0add284fcc38da4 Mon Sep 17 00:00:00 2001
|
|
|
eff9421 |
From: Michael S. Tsirkin <mst@redhat.com>
|
|
|
eff9421 |
Date: Wed, 24 Feb 2010 21:09:45 +0200
|
|
|
eff9421 |
Subject: [PATCH] msix: migration fix
|
|
|
eff9421 |
|
|
|
eff9421 |
Be careful to match mask/unmask callbacks from msix.
|
|
|
eff9421 |
Fixes crash during migration.
|
|
|
eff9421 |
|
|
|
eff9421 |
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
|
|
|
eff9421 |
---
|
|
|
eff9421 |
hw/msix.c | 16 +++++++++++++---
|
|
|
eff9421 |
1 files changed, 13 insertions(+), 3 deletions(-)
|
|
|
eff9421 |
|
|
|
eff9421 |
diff --git a/hw/msix.c b/hw/msix.c
|
|
|
eff9421 |
index 3fcf3a1..fafaf09 100644
|
|
|
eff9421 |
--- a/hw/msix.c
|
|
|
eff9421 |
+++ b/hw/msix.c
|
|
|
eff9421 |
@@ -614,9 +614,19 @@ int msix_set_mask_notifier(PCIDevice *dev, unsigned vector, void *opaque)
|
|
|
eff9421 |
if (vector >= dev->msix_entries_nr || !dev->msix_entry_used[vector])
|
|
|
eff9421 |
return 0;
|
|
|
eff9421 |
|
|
|
eff9421 |
- if (dev->msix_mask_notifier)
|
|
|
eff9421 |
- r = dev->msix_mask_notifier(dev, vector, opaque,
|
|
|
eff9421 |
- msix_is_masked(dev, vector));
|
|
|
eff9421 |
+ if (dev->msix_mask_notifier && !msix_is_masked(dev, vector)) {
|
|
|
eff9421 |
+ /* Mask previous notifier if any */
|
|
|
eff9421 |
+ if (dev->msix_mask_notifier_opaque[vector]) {
|
|
|
eff9421 |
+ r = dev->msix_mask_notifier(dev, vector,
|
|
|
eff9421 |
+ dev->msix_mask_notifier_opaque[vector],
|
|
|
eff9421 |
+ 1);
|
|
|
eff9421 |
+ assert(r >= 0);
|
|
|
eff9421 |
+ }
|
|
|
eff9421 |
+ /* Unmask new notifier, assumed to be masked at start */
|
|
|
eff9421 |
+ if (opaque) {
|
|
|
eff9421 |
+ r = dev->msix_mask_notifier(dev, vector, opaque, 0);
|
|
|
eff9421 |
+ }
|
|
|
eff9421 |
+ }
|
|
|
eff9421 |
if (r >= 0)
|
|
|
eff9421 |
dev->msix_mask_notifier_opaque[vector] = opaque;
|
|
|
eff9421 |
return r;
|
|
|
eff9421 |
--
|
|
|
eff9421 |
1.6.6.1
|
|
|
eff9421 |
|