|
 |
1c30660 |
From 75e3acce2d9302a2344b3de381a49f6cd0fa04ad Mon Sep 17 00:00:00 2001
|
|
|
96a5f8d |
From: Cole Robinson <crobinso@redhat.com>
|
|
|
96a5f8d |
Date: Tue, 19 Feb 2013 14:44:49 -0500
|
|
|
96a5f8d |
Subject: [PATCH] acpi_piix4: Drop minimum_version_id to handle qemu-kvm
|
|
|
96a5f8d |
migration
|
|
|
96a5f8d |
|
|
|
96a5f8d |
qemu-kvm 1.2 advertised version_id=2, but it was not the same
|
|
|
96a5f8d |
format as qemu.git version_id=2.
|
|
|
96a5f8d |
|
|
|
96a5f8d |
commit b0b873a07872f7ab7f66f259c73fb9dd42aa66a9 added the qemu-kvm
|
|
|
96a5f8d |
format to qemu.git, but was forced to call it version_id=3, and
|
|
|
96a5f8d |
bumped minimum_version_id to 3. This breaks incoming migration from
|
|
|
96a5f8d |
qemu-kvm.
|
|
|
96a5f8d |
|
|
|
96a5f8d |
If --enable-migration-from-qemu-kvm is enabled, drop minimum_version_id
|
|
|
96a5f8d |
to 2. Migration from qemu-kvm version_id=2 and qemu 1.3+ version_id=3
|
|
|
96a5f8d |
works, but migration from qemu < 1.3 is broken.
|
|
|
96a5f8d |
|
|
|
96a5f8d |
Signed-off-by: Cole Robinson <crobinso@redhat.com>
|
|
|
96a5f8d |
---
|
|
|
96a5f8d |
hw/acpi_piix4.c | 15 +++++++++------
|
|
|
96a5f8d |
1 file changed, 9 insertions(+), 6 deletions(-)
|
|
|
96a5f8d |
|
|
|
96a5f8d |
diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c
|
|
|
1c30660 |
index 1beac21..2abcc9d 100644
|
|
|
96a5f8d |
--- a/hw/acpi_piix4.c
|
|
|
96a5f8d |
+++ b/hw/acpi_piix4.c
|
|
|
96a5f8d |
@@ -257,16 +257,19 @@ static int acpi_load_old(QEMUFile *f, void *opaque, int version_id)
|
|
|
96a5f8d |
return ret;
|
|
|
96a5f8d |
}
|
|
|
96a5f8d |
|
|
|
96a5f8d |
-/* qemu-kvm 1.2 uses version 3 but advertised as 2
|
|
|
96a5f8d |
- * To support incoming qemu-kvm 1.2 migration, change version_id
|
|
|
96a5f8d |
- * and minimum_version_id to 2 below (which breaks migration from
|
|
|
96a5f8d |
- * qemu 1.2).
|
|
|
96a5f8d |
- *
|
|
|
96a5f8d |
- */
|
|
|
96a5f8d |
static const VMStateDescription vmstate_acpi = {
|
|
|
96a5f8d |
.name = "piix4_pm",
|
|
|
96a5f8d |
.version_id = 3,
|
|
|
96a5f8d |
+#ifdef CONFIG_MIGRATE_FROM_QEMU_KVM
|
|
|
96a5f8d |
+ /*
|
|
|
96a5f8d |
+ * qemu-kvm 1.2 uses qemu.git version 3 format, but advertised as 2.
|
|
|
96a5f8d |
+ * This allows incoming migration from qemu-kvm, but breaks incoming
|
|
|
96a5f8d |
+ * migration from qemu < 1.3.
|
|
|
96a5f8d |
+ */
|
|
|
96a5f8d |
+ .minimum_version_id = 2,
|
|
|
96a5f8d |
+#else
|
|
|
96a5f8d |
.minimum_version_id = 3,
|
|
|
96a5f8d |
+#endif
|
|
|
96a5f8d |
.minimum_version_id_old = 1,
|
|
|
96a5f8d |
.load_state_old = acpi_load_old,
|
|
|
96a5f8d |
.post_load = vmstate_acpi_post_load,
|