5544c1b
From f4a5b8185d067430cd605a740af654cd1cd2e2aa Mon Sep 17 00:00:00 2001
5544c1b
From: Meador Inge <meadori@codesourcery.com>
5544c1b
Date: Wed, 26 Sep 2012 16:46:28 +0100
5544c1b
Subject: [PATCH] hw/armv7m_nvic: Correctly register GIC region when setting
5544c1b
 up NVIC
5544c1b
5544c1b
When setting up the NVIC memory regions the memory range
5544c1b
0x100..0xcff is aliased to an IO memory region that belongs
5544c1b
to the ARM GIC.  This aliased region should be added to the
5544c1b
NVIC memory container, but the actual GIC IO memory region
5544c1b
was being added instead.  This mixup was causing the wrong
5544c1b
IO memory access functions to be called when accessing parts
5544c1b
of the NVIC memory.
5544c1b
5544c1b
Signed-off-by: Meador Inge <meadori@codesourcery.com>
5544c1b
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
5544c1b
(cherry picked from commit 9892cae39562d2e6c00ccc5966302c00f23be6d4)
5544c1b
5544c1b
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
5544c1b
---
5544c1b
 hw/armv7m_nvic.c | 3 ++-
5544c1b
 1 file changed, 2 insertions(+), 1 deletion(-)
5544c1b
5544c1b
diff --git a/hw/armv7m_nvic.c b/hw/armv7m_nvic.c
5544c1b
index 6a0832e..5c09116 100644
5544c1b
--- a/hw/armv7m_nvic.c
5544c1b
+++ b/hw/armv7m_nvic.c
5544c1b
@@ -489,7 +489,8 @@ static int armv7m_nvic_init(SysBusDevice *dev)
5544c1b
      */
5544c1b
     memory_region_init_alias(&s->gic_iomem_alias, "nvic-gic", &s->gic.iomem,
5544c1b
                              0x100, 0xc00);
5544c1b
-    memory_region_add_subregion_overlap(&s->container, 0x100, &s->gic.iomem, 1);
5544c1b
+    memory_region_add_subregion_overlap(&s->container, 0x100,
5544c1b
+                                        &s->gic_iomem_alias, 1);
5544c1b
     /* Map the whole thing into system memory at the location required
5544c1b
      * by the v7M architecture.
5544c1b
      */
5544c1b
-- 
5544c1b
1.7.12.1
5544c1b