5544c1b
From b95fb22d2799ed07c55bccbd7ffa3cb19fb7feb3 Mon Sep 17 00:00:00 2001
5544c1b
From: Hans de Goede <hdegoede@redhat.com>
5544c1b
Date: Mon, 10 Sep 2012 13:49:46 +0200
5544c1b
Subject: [PATCH] usb-redir: Revert usb-redir part of commit 93bfef4c
5544c1b
5544c1b
Commit 93bfef4c6e4b23caea9d51e1099d06433d8835a4 makes qemu-devices
5544c1b
which report the qemu version string to the guest in some way use a
5544c1b
qemu_get_version function which reports a machine-specific version string.
5544c1b
5544c1b
However usb-redir does not expose the qemu version to the guest, only to
5544c1b
the usbredir-host as part of the initial handshake. This can then be logged
5544c1b
on the usbredir-host side for debugging purposes and is otherwise completely
5544c1b
unused! For debugging purposes it is important to have the real qemu version
5544c1b
in there, rather then the machine-specific version.
5544c1b
5544c1b
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
5544c1b
---
5544c1b
 hw/usb/redirect.c | 1 -
5544c1b
 1 file changed, 1 deletion(-)
5544c1b
5544c1b
diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c
5544c1b
index 57e6289..78e93a7 100644
5544c1b
--- a/hw/usb/redirect.c
5544c1b
+++ b/hw/usb/redirect.c
5544c1b
@@ -875,7 +875,6 @@ static void usbredir_chardev_close_bh(void *opaque)
5544c1b
 static void usbredir_chardev_open(USBRedirDevice *dev)
5544c1b
 {
5544c1b
     uint32_t caps[USB_REDIR_CAPS_SIZE] = { 0, };
5544c1b
-    char version[32];
5544c1b
     int flags = 0;
5544c1b
 
5544c1b
     /* Make sure any pending closes are handled (no-op if none pending) */
5544c1b
-- 
5544c1b
1.7.12.1
5544c1b