|
 |
0fb2b27 |
From 82e922c8be1b32eeb0c8c22165cdeff39e12d3ef Mon Sep 17 00:00:00 2001
|
|
|
0fb2b27 |
From: Paolo Bonzini <pbonzini@redhat.com>
|
|
|
0fb2b27 |
Date: Tue, 22 Aug 2017 09:42:59 +0200
|
|
|
0fb2b27 |
Subject: [PATCH 09/15] scsi: introduce scsi_build_sense
|
|
|
0fb2b27 |
MIME-Version: 1.0
|
|
|
0fb2b27 |
Content-Type: text/plain; charset=UTF-8
|
|
|
0fb2b27 |
Content-Transfer-Encoding: 8bit
|
|
|
0fb2b27 |
|
|
|
0fb2b27 |
Move more knowledge of sense data format out of hw/scsi/scsi-bus.c
|
|
|
0fb2b27 |
for reusability.
|
|
|
0fb2b27 |
|
|
|
0fb2b27 |
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
|
|
|
0fb2b27 |
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
0fb2b27 |
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
|
|
|
0fb2b27 |
---
|
|
|
0fb2b27 |
hw/scsi/scsi-bus.c | 8 +-------
|
|
|
0fb2b27 |
include/scsi/utils.h | 2 ++
|
|
|
0fb2b27 |
scsi/utils.c | 11 +++++++++++
|
|
|
0fb2b27 |
3 files changed, 14 insertions(+), 7 deletions(-)
|
|
|
0fb2b27 |
|
|
|
0fb2b27 |
diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c
|
|
|
0fb2b27 |
index 42920d5422..652ab046ab 100644
|
|
|
0fb2b27 |
--- a/hw/scsi/scsi-bus.c
|
|
|
0fb2b27 |
+++ b/hw/scsi/scsi-bus.c
|
|
|
0fb2b27 |
@@ -818,13 +818,7 @@ void scsi_req_build_sense(SCSIRequest *req, SCSISense sense)
|
|
|
0fb2b27 |
{
|
|
|
0fb2b27 |
trace_scsi_req_build_sense(req->dev->id, req->lun, req->tag,
|
|
|
0fb2b27 |
sense.key, sense.asc, sense.ascq);
|
|
|
0fb2b27 |
- memset(req->sense, 0, 18);
|
|
|
0fb2b27 |
- req->sense[0] = 0x70;
|
|
|
0fb2b27 |
- req->sense[2] = sense.key;
|
|
|
0fb2b27 |
- req->sense[7] = 10;
|
|
|
0fb2b27 |
- req->sense[12] = sense.asc;
|
|
|
0fb2b27 |
- req->sense[13] = sense.ascq;
|
|
|
0fb2b27 |
- req->sense_len = 18;
|
|
|
0fb2b27 |
+ req->sense_len = scsi_build_sense(req->sense, sense);
|
|
|
0fb2b27 |
}
|
|
|
0fb2b27 |
|
|
|
0fb2b27 |
static void scsi_req_enqueue_internal(SCSIRequest *req)
|
|
|
0fb2b27 |
diff --git a/include/scsi/utils.h b/include/scsi/utils.h
|
|
|
0fb2b27 |
index 90bf4dce6e..b49392d841 100644
|
|
|
0fb2b27 |
--- a/include/scsi/utils.h
|
|
|
0fb2b27 |
+++ b/include/scsi/utils.h
|
|
|
0fb2b27 |
@@ -30,6 +30,8 @@ typedef struct SCSISense {
|
|
|
0fb2b27 |
uint8_t ascq;
|
|
|
0fb2b27 |
} SCSISense;
|
|
|
0fb2b27 |
|
|
|
0fb2b27 |
+int scsi_build_sense(uint8_t *buf, SCSISense sense);
|
|
|
0fb2b27 |
+
|
|
|
0fb2b27 |
/*
|
|
|
0fb2b27 |
* Predefined sense codes
|
|
|
0fb2b27 |
*/
|
|
|
0fb2b27 |
diff --git a/scsi/utils.c b/scsi/utils.c
|
|
|
0fb2b27 |
index 2327e06da0..89d9167d9d 100644
|
|
|
0fb2b27 |
--- a/scsi/utils.c
|
|
|
0fb2b27 |
+++ b/scsi/utils.c
|
|
|
0fb2b27 |
@@ -96,6 +96,17 @@ int scsi_cdb_length(uint8_t *buf)
|
|
|
0fb2b27 |
return cdb_len;
|
|
|
0fb2b27 |
}
|
|
|
0fb2b27 |
|
|
|
0fb2b27 |
+int scsi_build_sense(uint8_t *buf, SCSISense sense)
|
|
|
0fb2b27 |
+{
|
|
|
0fb2b27 |
+ memset(buf, 0, 18);
|
|
|
0fb2b27 |
+ buf[0] = 0x70;
|
|
|
0fb2b27 |
+ buf[2] = sense.key;
|
|
|
0fb2b27 |
+ buf[7] = 10;
|
|
|
0fb2b27 |
+ buf[12] = sense.asc;
|
|
|
0fb2b27 |
+ buf[13] = sense.ascq;
|
|
|
0fb2b27 |
+ return 18;
|
|
|
0fb2b27 |
+}
|
|
|
0fb2b27 |
+
|
|
|
0fb2b27 |
/*
|
|
|
0fb2b27 |
* Predefined sense codes
|
|
|
0fb2b27 |
*/
|
|
|
0fb2b27 |
--
|
|
|
0fb2b27 |
2.13.5
|
|
|
0fb2b27 |
|