|
 |
d2798f5 |
commit ed8e5a85a1741147ce06932b478a509ce3407061
|
|
|
d2798f5 |
Author: Christian Borntraeger <borntraeger@de.ibm.com>
|
|
|
d2798f5 |
Date: Thu Dec 29 13:47:43 2011 +0100
|
|
|
d2798f5 |
|
|
|
d2798f5 |
virtio-console: Fix failure on unconnected pty
|
|
|
d2798f5 |
|
|
|
d2798f5 |
when I tried qemu with -virtio-console pty the guest hangs and attaching
|
|
|
d2798f5 |
on /dev/pts/<x> does not return anything if the attachment is too late.
|
|
|
d2798f5 |
|
|
|
d2798f5 |
This results in pty_chr_write() returning 0, which causes the port to
|
|
|
d2798f5 |
get throttled. This results in the guest getting frozen as the
|
|
|
d2798f5 |
guest->host virtio_console writes don't return until the host releases
|
|
|
d2798f5 |
the vq element back to the guest.
|
|
|
d2798f5 |
|
|
|
d2798f5 |
For the virtio-serial use case we don't want to lose data but for the
|
|
|
d2798f5 |
console case we better drop data instead of "killing" the guest
|
|
|
d2798f5 |
console. If we get chardev->frontend notification and a better behaving
|
|
|
d2798f5 |
virtio-console we can revert this fix.
|
|
|
d2798f5 |
|
|
|
d2798f5 |
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
|
|
|
d2798f5 |
Signed-off-by: Amit Shah <amit.shah@redhat.com>
|
|
|
d2798f5 |
|
|
|
d2798f5 |
diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c
|
|
|
d2798f5 |
index fe0233f..3a9004a 100644
|
|
|
d2798f5 |
--- a/hw/virtio-serial-bus.c
|
|
|
d2798f5 |
+++ b/hw/virtio-serial-bus.c
|
|
|
d2798f5 |
@@ -163,7 +163,19 @@ static void do_flush_queued_data(VirtIOSerialPort *port, VirtQueue *vq,
|
|
|
d2798f5 |
abort();
|
|
|
d2798f5 |
}
|
|
|
d2798f5 |
if (ret == -EAGAIN || (ret >= 0 && ret < buf_size)) {
|
|
|
d2798f5 |
- virtio_serial_throttle_port(port, true);
|
|
|
d2798f5 |
+ /*
|
|
|
d2798f5 |
+ * this is a temporary check until chardevs can signal to
|
|
|
d2798f5 |
+ * frontends that they are writable again. This prevents
|
|
|
d2798f5 |
+ * the console from going into throttled mode (forever)
|
|
|
d2798f5 |
+ * if virtio-console is connected to a pty without a
|
|
|
d2798f5 |
+ * listener. Otherwise the guest spins forever.
|
|
|
d2798f5 |
+ * We can revert this if
|
|
|
d2798f5 |
+ * 1: chardevs can notify frondends
|
|
|
d2798f5 |
+ * 2: the guest driver does not spin in these cases
|
|
|
d2798f5 |
+ */
|
|
|
d2798f5 |
+ if (!info->is_console) {
|
|
|
d2798f5 |
+ virtio_serial_throttle_port(port, true);
|
|
|
d2798f5 |
+ }
|
|
|
d2798f5 |
port->iov_idx = i;
|
|
|
d2798f5 |
if (ret > 0) {
|
|
|
d2798f5 |
port->iov_offset += ret;
|