357a44f
diff -ruNp qemu-kvm-1.0/default-configs/pci.mak qemu-kvm-1.0.virtio-scsi/default-configs/pci.mak
357a44f
--- qemu-kvm-1.0/default-configs/pci.mak	2011-12-04 04:38:06.000000000 -0600
357a44f
+++ qemu-kvm-1.0.virtio-scsi/default-configs/pci.mak	2012-02-07 14:44:53.424905251 -0600
357a44f
@@ -1,5 +1,6 @@
357a44f
 CONFIG_PCI=y
357a44f
 CONFIG_VIRTIO_PCI=y
357a44f
+CONFIG_VIRTIO_SCSI=y
357a44f
 CONFIG_VIRTIO=y
357a44f
 CONFIG_USB_UHCI=y
357a44f
 CONFIG_USB_OHCI=y
357a44f
diff -ruNp qemu-kvm-1.0/default-configs/s390x-softmmu.mak qemu-kvm-1.0.virtio-scsi/default-configs/s390x-softmmu.mak
357a44f
--- qemu-kvm-1.0/default-configs/s390x-softmmu.mak	2011-12-04 04:38:06.000000000 -0600
357a44f
+++ qemu-kvm-1.0.virtio-scsi/default-configs/s390x-softmmu.mak	2012-02-07 14:44:53.424905251 -0600
357a44f
@@ -1 +1,2 @@
357a44f
 CONFIG_VIRTIO=y
357a44f
+CONFIG_VIRTIO_SCSI=y
357a44f
diff -ruNp qemu-kvm-1.0/dma.h qemu-kvm-1.0.virtio-scsi/dma.h
357a44f
--- qemu-kvm-1.0/dma.h	2011-12-04 04:38:06.000000000 -0600
357a44f
+++ qemu-kvm-1.0.virtio-scsi/dma.h	2012-02-07 14:44:53.425905267 -0600
357a44f
@@ -17,6 +17,13 @@
357a44f
 
357a44f
 typedef struct ScatterGatherEntry ScatterGatherEntry;
357a44f
 
357a44f
+struct QEMUSGList {
357a44f
+    ScatterGatherEntry *sg;
357a44f
+    int nsg;
357a44f
+    int nalloc;
357a44f
+    size_t size;
357a44f
+};
357a44f
+
357a44f
 #if defined(TARGET_PHYS_ADDR_BITS)
357a44f
 typedef target_phys_addr_t dma_addr_t;
357a44f
 
357a44f
@@ -32,13 +39,6 @@ struct ScatterGatherEntry {
357a44f
     dma_addr_t len;
357a44f
 };
357a44f
 
357a44f
-struct QEMUSGList {
357a44f
-    ScatterGatherEntry *sg;
357a44f
-    int nsg;
357a44f
-    int nalloc;
357a44f
-    dma_addr_t size;
357a44f
-};
357a44f
-
357a44f
 void qemu_sglist_init(QEMUSGList *qsg, int alloc_hint);
357a44f
 void qemu_sglist_add(QEMUSGList *qsg, dma_addr_t base, dma_addr_t len);
357a44f
 void qemu_sglist_destroy(QEMUSGList *qsg);
357a44f
@@ -58,4 +58,10 @@ BlockDriverAIOCB *dma_bdrv_read(BlockDri
357a44f
 BlockDriverAIOCB *dma_bdrv_write(BlockDriverState *bs,
357a44f
                                  QEMUSGList *sg, uint64_t sector,
357a44f
                                  BlockDriverCompletionFunc *cb, void *opaque);
357a44f
+uint64_t dma_buf_read(uint8_t *ptr, int32_t len, QEMUSGList *sg);
357a44f
+uint64_t dma_buf_write(uint8_t *ptr, int32_t len, QEMUSGList *sg);
357a44f
+
357a44f
+void dma_acct_start(BlockDriverState *bs, BlockAcctCookie *cookie,
357a44f
+                    QEMUSGList *sg, enum BlockAcctType type);
357a44f
+
357a44f
 #endif
357a44f
diff -ruNp qemu-kvm-1.0/dma-helpers.c qemu-kvm-1.0.virtio-scsi/dma-helpers.c
357a44f
--- qemu-kvm-1.0/dma-helpers.c	2011-12-04 04:38:06.000000000 -0600
357a44f
+++ qemu-kvm-1.0.virtio-scsi/dma-helpers.c	2012-02-07 14:44:53.424905251 -0600
357a44f
@@ -196,3 +196,39 @@ BlockDriverAIOCB *dma_bdrv_write(BlockDr
357a44f
 {
357a44f
     return dma_bdrv_io(bs, sg, sector, bdrv_aio_writev, cb, opaque, true);
357a44f
 }
357a44f
+
357a44f
+
357a44f
+static uint64_t dma_buf_rw(uint8_t *ptr, int32_t len, QEMUSGList *sg, bool to_dev)
357a44f
+{
357a44f
+    uint64_t resid;
357a44f
+    int sg_cur_index;
357a44f
+
357a44f
+    resid = sg->size;
357a44f
+    sg_cur_index = 0;
357a44f
+    len = MIN(len, resid);
357a44f
+    while (len > 0) {
357a44f
+        ScatterGatherEntry entry = sg->sg[sg_cur_index++];
357a44f
+        cpu_physical_memory_rw(entry.base, ptr, MIN(len, entry.len), !to_dev);
357a44f
+        ptr += entry.len;
357a44f
+        len -= entry.len;
357a44f
+        resid -= entry.len;
357a44f
+    }
357a44f
+
357a44f
+    return resid;
357a44f
+}
357a44f
+
357a44f
+uint64_t dma_buf_read(uint8_t *ptr, int32_t len, QEMUSGList *sg)
357a44f
+{
357a44f
+    return dma_buf_rw(ptr, len, sg, 0);
357a44f
+}
357a44f
+
357a44f
+uint64_t dma_buf_write(uint8_t *ptr, int32_t len, QEMUSGList *sg)
357a44f
+{
357a44f
+    return dma_buf_rw(ptr, len, sg, 1);
357a44f
+}
357a44f
+
357a44f
+void dma_acct_start(BlockDriverState *bs, BlockAcctCookie *cookie,
357a44f
+                    QEMUSGList *sg, enum BlockAcctType type)
357a44f
+{
357a44f
+    bdrv_acct_start(bs, cookie, sg->size, type);
357a44f
+}
357a44f
diff -ruNp qemu-kvm-1.0/hw/esp.c qemu-kvm-1.0.virtio-scsi/hw/esp.c
357a44f
--- qemu-kvm-1.0/hw/esp.c	2011-12-04 04:38:06.000000000 -0600
357a44f
+++ qemu-kvm-1.0.virtio-scsi/hw/esp.c	2012-02-07 14:44:53.425905267 -0600
357a44f
@@ -389,7 +389,8 @@ static void esp_do_dma(ESPState *s)
357a44f
     esp_dma_done(s);
357a44f
 }
357a44f
 
357a44f
-static void esp_command_complete(SCSIRequest *req, uint32_t status)
357a44f
+static void esp_command_complete(SCSIRequest *req, uint32_t status,
357a44f
+                                 int32_t resid)
357a44f
 {
357a44f
     ESPState *s = DO_UPCAST(ESPState, busdev.qdev, req->bus->qbus.parent);
357a44f
 
357a44f
diff -ruNp qemu-kvm-1.0/hw/ide/ahci.c qemu-kvm-1.0.virtio-scsi/hw/ide/ahci.c
357a44f
--- qemu-kvm-1.0/hw/ide/ahci.c	2011-12-04 04:38:06.000000000 -0600
357a44f
+++ qemu-kvm-1.0.virtio-scsi/hw/ide/ahci.c	2012-02-07 14:44:53.426905283 -0600
357a44f
@@ -425,55 +425,6 @@ static void ahci_reg_init(AHCIState *s)
357a44f
     }
357a44f
 }
357a44f
 
357a44f
-static uint32_t read_from_sglist(uint8_t *buffer, uint32_t len,
357a44f
-                                 QEMUSGList *sglist)
357a44f
-{
357a44f
-    uint32_t i = 0;
357a44f
-    uint32_t total = 0, once;
357a44f
-    ScatterGatherEntry *cur_prd;
357a44f
-    uint32_t sgcount;
357a44f
-
357a44f
-    cur_prd = sglist->sg;
357a44f
-    sgcount = sglist->nsg;
357a44f
-    for (i = 0; len && sgcount; i++) {
357a44f
-        once = MIN(cur_prd->len, len);
357a44f
-        cpu_physical_memory_read(cur_prd->base, buffer, once);
357a44f
-        cur_prd++;
357a44f
-        sgcount--;
357a44f
-        len -= once;
357a44f
-        buffer += once;
357a44f
-        total += once;
357a44f
-    }
357a44f
-
357a44f
-    return total;
357a44f
-}
357a44f
-
357a44f
-static uint32_t write_to_sglist(uint8_t *buffer, uint32_t len,
357a44f
-                                QEMUSGList *sglist)
357a44f
-{
357a44f
-    uint32_t i = 0;
357a44f
-    uint32_t total = 0, once;
357a44f
-    ScatterGatherEntry *cur_prd;
357a44f
-    uint32_t sgcount;
357a44f
-
357a44f
-    DPRINTF(-1, "total: 0x%x bytes\n", len);
357a44f
-
357a44f
-    cur_prd = sglist->sg;
357a44f
-    sgcount = sglist->nsg;
357a44f
-    for (i = 0; len && sgcount; i++) {
357a44f
-        once = MIN(cur_prd->len, len);
357a44f
-        DPRINTF(-1, "write 0x%x bytes to 0x%lx\n", once, (long)cur_prd->base);
357a44f
-        cpu_physical_memory_write(cur_prd->base, buffer, once);
357a44f
-        cur_prd++;
357a44f
-        sgcount--;
357a44f
-        len -= once;
357a44f
-        buffer += once;
357a44f
-        total += once;
357a44f
-    }
357a44f
-
357a44f
-    return total;
357a44f
-}
357a44f
-
357a44f
 static void check_cmd(AHCIState *s, int port)
357a44f
 {
357a44f
     AHCIPortRegs *pr = &s->dev[port].port_regs;
357a44f
@@ -794,9 +745,8 @@ static void process_ncq_command(AHCIStat
357a44f
             DPRINTF(port, "tag %d aio read %"PRId64"\n",
357a44f
                     ncq_tfs->tag, ncq_tfs->lba);
357a44f
 
357a44f
-            bdrv_acct_start(ncq_tfs->drive->port.ifs[0].bs, &ncq_tfs->acct,
357a44f
-                            (ncq_tfs->sector_count-1) * BDRV_SECTOR_SIZE,
357a44f
-                            BDRV_ACCT_READ);
357a44f
+            dma_acct_start(ncq_tfs->drive->port.ifs[0].bs, &ncq_tfs->acct,
357a44f
+                           &ncq_tfs->sglist, BDRV_ACCT_READ);
357a44f
             ncq_tfs->aiocb = dma_bdrv_read(ncq_tfs->drive->port.ifs[0].bs,
357a44f
                                            &ncq_tfs->sglist, ncq_tfs->lba,
357a44f
                                            ncq_cb, ncq_tfs);
357a44f
@@ -808,9 +758,8 @@ static void process_ncq_command(AHCIStat
357a44f
             DPRINTF(port, "tag %d aio write %"PRId64"\n",
357a44f
                     ncq_tfs->tag, ncq_tfs->lba);
357a44f
 
357a44f
-            bdrv_acct_start(ncq_tfs->drive->port.ifs[0].bs, &ncq_tfs->acct,
357a44f
-                            (ncq_tfs->sector_count-1) * BDRV_SECTOR_SIZE,
357a44f
-                            BDRV_ACCT_WRITE);
357a44f
+            dma_acct_start(ncq_tfs->drive->port.ifs[0].bs, &ncq_tfs->acct,
357a44f
+                           &ncq_tfs->sglist, BDRV_ACCT_WRITE);
357a44f
             ncq_tfs->aiocb = dma_bdrv_write(ncq_tfs->drive->port.ifs[0].bs,
357a44f
                                             &ncq_tfs->sglist, ncq_tfs->lba,
357a44f
                                             ncq_cb, ncq_tfs);
357a44f
@@ -1015,12 +964,12 @@ static int ahci_start_transfer(IDEDMA *d
357a44f
             is_write ? "writ" : "read", size, is_atapi ? "atapi" : "ata",
357a44f
             has_sglist ? "" : "o");
357a44f
 
357a44f
-    if (is_write && has_sglist && (s->data_ptr < s->data_end)) {
357a44f
-        read_from_sglist(s->data_ptr, size, &s->sg);
357a44f
-    }
357a44f
-
357a44f
-    if (!is_write && has_sglist && (s->data_ptr < s->data_end)) {
357a44f
-        write_to_sglist(s->data_ptr, size, &s->sg);
357a44f
+    if (has_sglist && size) {
357a44f
+        if (is_write) {
357a44f
+            dma_buf_write(s->data_ptr, size, &s->sg);
357a44f
+        } else {
357a44f
+            dma_buf_read(s->data_ptr, size, &s->sg);
357a44f
+        }
357a44f
     }
357a44f
 
357a44f
     /* update number of transferred bytes */
357a44f
@@ -1059,14 +1008,9 @@ static int ahci_dma_prepare_buf(IDEDMA *
357a44f
 {
357a44f
     AHCIDevice *ad = DO_UPCAST(AHCIDevice, dma, dma);
357a44f
     IDEState *s = &ad->port.ifs[0];
357a44f
-    int i;
357a44f
 
357a44f
     ahci_populate_sglist(ad, &s->sg);
357a44f
-
357a44f
-    s->io_buffer_size = 0;
357a44f
-    for (i = 0; i < s->sg.nsg; i++) {
357a44f
-        s->io_buffer_size += s->sg.sg[i].len;
357a44f
-    }
357a44f
+    s->io_buffer_size = s->sg.size;
357a44f
 
357a44f
     DPRINTF(ad->port_no, "len=%#x\n", s->io_buffer_size);
357a44f
     return s->io_buffer_size != 0;
357a44f
@@ -1084,9 +1028,9 @@ static int ahci_dma_rw_buf(IDEDMA *dma,
357a44f
     }
357a44f
 
357a44f
     if (is_write) {
357a44f
-        write_to_sglist(p, l, &s->sg);
357a44f
+        dma_buf_read(p, l, &s->sg);
357a44f
     } else {
357a44f
-        read_from_sglist(p, l, &s->sg);
357a44f
+        dma_buf_write(p, l, &s->sg);
357a44f
     }
357a44f
 
357a44f
     /* update number of transferred bytes */
357a44f
diff -ruNp qemu-kvm-1.0/hw/lsi53c895a.c qemu-kvm-1.0.virtio-scsi/hw/lsi53c895a.c
357a44f
--- qemu-kvm-1.0/hw/lsi53c895a.c	2011-12-04 04:38:06.000000000 -0600
357a44f
+++ qemu-kvm-1.0.virtio-scsi/hw/lsi53c895a.c	2012-02-07 14:44:53.427905299 -0600
357a44f
@@ -699,7 +699,7 @@ static int lsi_queue_req(LSIState *s, SC
357a44f
 }
357a44f
 
357a44f
  /* Callback to indicate that the SCSI layer has completed a command.  */
357a44f
-static void lsi_command_complete(SCSIRequest *req, uint32_t status)
357a44f
+static void lsi_command_complete(SCSIRequest *req, uint32_t status, int32_t resid)
357a44f
 {
357a44f
     LSIState *s = DO_UPCAST(LSIState, dev.qdev, req->bus->qbus.parent);
357a44f
     int out;
357a44f
diff -ruNp qemu-kvm-1.0/hw/pci.h qemu-kvm-1.0.virtio-scsi/hw/pci.h
357a44f
--- qemu-kvm-1.0/hw/pci.h	2011-12-04 04:38:06.000000000 -0600
357a44f
+++ qemu-kvm-1.0.virtio-scsi/hw/pci.h	2012-02-07 14:44:53.427905299 -0600
357a44f
@@ -76,6 +76,7 @@
357a44f
 #define PCI_DEVICE_ID_VIRTIO_BLOCK       0x1001
357a44f
 #define PCI_DEVICE_ID_VIRTIO_BALLOON     0x1002
357a44f
 #define PCI_DEVICE_ID_VIRTIO_CONSOLE     0x1003
357a44f
+#define PCI_DEVICE_ID_VIRTIO_SCSI        0x1004
357a44f
 
357a44f
 #define FMT_PCIBUS                      PRIx64
357a44f
 
357a44f
diff -ruNp qemu-kvm-1.0/hw/s390-virtio-bus.c qemu-kvm-1.0.virtio-scsi/hw/s390-virtio-bus.c
357a44f
--- qemu-kvm-1.0/hw/s390-virtio-bus.c	2011-12-04 04:38:06.000000000 -0600
357a44f
+++ qemu-kvm-1.0.virtio-scsi/hw/s390-virtio-bus.c	2012-02-07 14:44:53.428905315 -0600
357a44f
@@ -158,6 +158,18 @@ static int s390_virtio_serial_init(VirtI
357a44f
     return r;
357a44f
 }
357a44f
 
357a44f
+static int s390_virtio_scsi_init(VirtIOS390Device *dev)
357a44f
+{
357a44f
+    VirtIODevice *vdev;
357a44f
+
357a44f
+    vdev = virtio_scsi_init((DeviceState *)dev, &dev->scsi);
357a44f
+    if (!vdev) {
357a44f
+        return -1;
357a44f
+    }
357a44f
+
357a44f
+    return s390_virtio_device_init(dev, vdev);
357a44f
+}
357a44f
+
357a44f
 static uint64_t s390_virtio_device_vq_token(VirtIOS390Device *dev, int vq)
357a44f
 {
357a44f
     ram_addr_t token_off;
357a44f
@@ -370,6 +382,17 @@ static VirtIOS390DeviceInfo s390_virtio_
357a44f
     },
357a44f
 };
357a44f
 
357a44f
+static VirtIOS390DeviceInfo s390_virtio_scsi = {
357a44f
+    .init = s390_virtio_scsi_init,
357a44f
+    .qdev.name = "virtio-scsi-s390",
357a44f
+    .qdev.alias = "virtio-scsi",
357a44f
+    .qdev.size = sizeof(VirtIOS390Device),
357a44f
+    .qdev.props = (Property[]) {
357a44f
+        DEFINE_VIRTIO_SCSI_PROPERTIES(VirtIOS390Device, host_features, scsi),
357a44f
+        DEFINE_PROP_END_OF_LIST(),
357a44f
+    },
357a44f
+};
357a44f
+
357a44f
 static int s390_virtio_busdev_init(DeviceState *dev, DeviceInfo *info)
357a44f
 {
357a44f
     VirtIOS390DeviceInfo *_info = (VirtIOS390DeviceInfo *)info;
357a44f
@@ -392,6 +415,7 @@ static void s390_virtio_register(void)
357a44f
     s390_virtio_bus_register_withprop(&s390_virtio_serial);
357a44f
     s390_virtio_bus_register_withprop(&s390_virtio_blk);
357a44f
     s390_virtio_bus_register_withprop(&s390_virtio_net);
357a44f
+    s390_virtio_bus_register_withprop(&s390_virtio_scsi);
357a44f
 }
357a44f
 device_init(s390_virtio_register);
357a44f
 
357a44f
diff -ruNp qemu-kvm-1.0/hw/s390-virtio-bus.h qemu-kvm-1.0.virtio-scsi/hw/s390-virtio-bus.h
357a44f
--- qemu-kvm-1.0/hw/s390-virtio-bus.h	2011-12-04 04:38:06.000000000 -0600
357a44f
+++ qemu-kvm-1.0.virtio-scsi/hw/s390-virtio-bus.h	2012-02-07 14:44:53.428905315 -0600
357a44f
@@ -19,6 +19,7 @@
357a44f
 
357a44f
 #include "virtio-net.h"
357a44f
 #include "virtio-serial.h"
357a44f
+#include "virtio-scsi.h"
357a44f
 
357a44f
 #define VIRTIO_DEV_OFFS_TYPE		0	/* 8 bits */
357a44f
 #define VIRTIO_DEV_OFFS_NUM_VQ		1	/* 8 bits */
357a44f
@@ -47,6 +48,7 @@ typedef struct VirtIOS390Device {
357a44f
     uint32_t host_features;
357a44f
     virtio_serial_conf serial;
357a44f
     virtio_net_conf net;
357a44f
+    VirtIOSCSIConf scsi;
357a44f
 } VirtIOS390Device;
357a44f
 
357a44f
 typedef struct VirtIOS390Bus {
357a44f
diff -ruNp qemu-kvm-1.0/hw/scsi-bus.c qemu-kvm-1.0.virtio-scsi/hw/scsi-bus.c
357a44f
--- qemu-kvm-1.0/hw/scsi-bus.c	2011-12-04 04:38:06.000000000 -0600
357a44f
+++ qemu-kvm-1.0.virtio-scsi/hw/scsi-bus.c	2012-02-07 14:44:53.428905315 -0600
357a44f
@@ -5,6 +5,7 @@
357a44f
 #include "qdev.h"
357a44f
 #include "blockdev.h"
357a44f
 #include "trace.h"
357a44f
+#include "dma.h"
357a44f
 
357a44f
 static char *scsibus_get_fw_dev_path(DeviceState *dev);
357a44f
 static int scsi_req_parse(SCSICommand *cmd, SCSIDevice *dev, uint8_t *buf);
357a44f
@@ -50,6 +51,7 @@ static void scsi_dma_restart_bh(void *op
357a44f
                 scsi_req_continue(req);
357a44f
                 break;
357a44f
             case SCSI_XFER_NONE:
357a44f
+                assert(!req->sg);
357a44f
                 scsi_req_dequeue(req);
357a44f
                 scsi_req_enqueue(req);
357a44f
                 break;
357a44f
@@ -512,6 +514,8 @@ SCSIRequest *scsi_req_new(SCSIDevice *d,
357a44f
     }
357a44f
 
357a44f
     req->cmd = cmd;
357a44f
+    req->resid = req->cmd.xfer;
357a44f
+
357a44f
     switch (buf[0]) {
357a44f
     case INQUIRY:
357a44f
         trace_scsi_inquiry(d->id, lun, tag, cmd.buf[1], cmd.buf[2]);
357a44f
@@ -624,15 +628,25 @@ void scsi_req_build_sense(SCSIRequest *r
357a44f
     req->sense_len = 18;
357a44f
 }
357a44f
 
357a44f
-int32_t scsi_req_enqueue(SCSIRequest *req)
357a44f
+static void scsi_req_enqueue_internal(SCSIRequest *req)
357a44f
 {
357a44f
-    int32_t rc;
357a44f
-
357a44f
     assert(!req->enqueued);
357a44f
     scsi_req_ref(req);
357a44f
+    if (req->bus->info->get_sg_list) {
357a44f
+        req->sg = req->bus->info->get_sg_list(req);
357a44f
+    } else {
357a44f
+        req->sg = NULL;
357a44f
+    }
357a44f
     req->enqueued = true;
357a44f
     QTAILQ_INSERT_TAIL(&req->dev->requests, req, next);
357a44f
+}
357a44f
+
357a44f
+int32_t scsi_req_enqueue(SCSIRequest *req)
357a44f
+{
357a44f
+    int32_t rc;
357a44f
 
357a44f
+    assert (!req->retry);
357a44f
+    scsi_req_enqueue_internal(req);
357a44f
     scsi_req_ref(req);
357a44f
     rc = req->ops->send_command(req, req->cmd.buf);
357a44f
     scsi_req_unref(req);
357a44f
@@ -1254,12 +1268,32 @@ void scsi_req_continue(SCSIRequest *req)
357a44f
    Once it completes, calling scsi_req_continue will restart I/O.  */
357a44f
 void scsi_req_data(SCSIRequest *req, int len)
357a44f
 {
357a44f
+    uint8_t *buf;
357a44f
     if (req->io_canceled) {
357a44f
         trace_scsi_req_data_canceled(req->dev->id, req->lun, req->tag, len);
357a44f
-    } else {
357a44f
-        trace_scsi_req_data(req->dev->id, req->lun, req->tag, len);
357a44f
+        return;
357a44f
+    }
357a44f
+    trace_scsi_req_data(req->dev->id, req->lun, req->tag, len);
357a44f
+    assert(req->cmd.mode != SCSI_XFER_NONE);
357a44f
+    if (!req->sg) {
357a44f
+        req->resid -= len;
357a44f
         req->bus->info->transfer_data(req, len);
357a44f
+        return;
357a44f
+    }
357a44f
+
357a44f
+    /* If the device calls scsi_req_data and the HBA specified a
357a44f
+     * scatter/gather list, the transfer has to happen in a single
357a44f
+     * step.  */
357a44f
+    assert(!req->dma_started);
357a44f
+    req->dma_started = true;
357a44f
+
357a44f
+    buf = scsi_req_get_buf(req);
357a44f
+    if (req->cmd.mode == SCSI_XFER_FROM_DEV) {
357a44f
+        req->resid = dma_buf_read(buf, len, req->sg);
357a44f
+    } else {
357a44f
+        req->resid = dma_buf_write(buf, len, req->sg);
357a44f
     }
357a44f
+    scsi_req_continue(req);
357a44f
 }
357a44f
 
357a44f
 void scsi_req_print(SCSIRequest *req)
357a44f
@@ -1318,7 +1352,7 @@ void scsi_req_complete(SCSIRequest *req,
357a44f
 
357a44f
     scsi_req_ref(req);
357a44f
     scsi_req_dequeue(req);
357a44f
-    req->bus->info->complete(req, req->status);
357a44f
+    req->bus->info->complete(req, req->status, req->resid);
357a44f
     scsi_req_unref(req);
357a44f
 }
357a44f
 
357a44f
@@ -1393,3 +1427,100 @@ SCSIDevice *scsi_device_find(SCSIBus *bu
357a44f
     }
357a44f
     return target_dev;
357a44f
 }
357a44f
+
357a44f
+
357a44f
+/* SCSI request list.  For simplicity, pv points to the whole device */
357a44f
+
357a44f
+static void put_scsi_requests(QEMUFile *f, void *pv, size_t size)
357a44f
+{
357a44f
+    SCSIDevice *s = pv;
357a44f
+    SCSIBus *bus = DO_UPCAST(SCSIBus, qbus, s->qdev.parent_bus);
357a44f
+    SCSIRequest *req;
357a44f
+
357a44f
+    QTAILQ_FOREACH(req, &s->requests, next) {
357a44f
+        assert(!req->io_canceled);
357a44f
+        assert(req->status == -1);
357a44f
+        assert(req->retry);
357a44f
+        assert(req->enqueued);
357a44f
+
357a44f
+        qemu_put_sbyte(f, 1);
357a44f
+        qemu_put_buffer(f, req->cmd.buf, sizeof(req->cmd.buf));
357a44f
+        qemu_put_be32s(f, &req->tag);
357a44f
+        qemu_put_be32s(f, &req->lun);
357a44f
+        if (bus->info->save_request) {
357a44f
+            bus->info->save_request(f, req);
357a44f
+        }
357a44f
+        if (req->ops->save_request) {
357a44f
+            req->ops->save_request(f, req);
357a44f
+        }
357a44f
+    }
357a44f
+    qemu_put_sbyte(f, 0);
357a44f
+}
357a44f
+
357a44f
+static int get_scsi_requests(QEMUFile *f, void *pv, size_t size)
357a44f
+{
357a44f
+    SCSIDevice *s = pv;
357a44f
+    SCSIBus *bus = DO_UPCAST(SCSIBus, qbus, s->qdev.parent_bus);
357a44f
+
357a44f
+    while (qemu_get_sbyte(f)) {
357a44f
+        uint8_t buf[SCSI_CMD_BUF_SIZE];
357a44f
+        uint32_t tag;
357a44f
+        uint32_t lun;
357a44f
+        SCSIRequest *req;
357a44f
+
357a44f
+        qemu_get_buffer(f, buf, sizeof(buf));
357a44f
+        qemu_get_be32s(f, &tag;;
357a44f
+        qemu_get_be32s(f, &lun;;
357a44f
+        req = scsi_req_new(s, tag, lun, buf, NULL);
357a44f
+        if (bus->info->load_request) {
357a44f
+            req->hba_private = bus->info->load_request(f, req);
357a44f
+        }
357a44f
+        if (req->ops->load_request) {
357a44f
+            req->ops->load_request(f, req);
357a44f
+        }
357a44f
+
357a44f
+        /* Just restart it later.  */
357a44f
+        req->retry = true;
357a44f
+        scsi_req_enqueue_internal(req);
357a44f
+
357a44f
+        /* At this point, the request will be kept alive by the reference
357a44f
+         * added by scsi_req_enqueue_internal, so we can release our reference.
357a44f
+         * The HBA of course will add its own reference in the load_request
357a44f
+         * callback if it needs to hold on the SCSIRequest.
357a44f
+         */
357a44f
+        scsi_req_unref(req);
357a44f
+    }
357a44f
+
357a44f
+    return 0;
357a44f
+}
357a44f
+
357a44f
+const VMStateInfo vmstate_info_scsi_requests = {
357a44f
+    .name = "scsi-requests",
357a44f
+    .get  = get_scsi_requests,
357a44f
+    .put  = put_scsi_requests,
357a44f
+};
357a44f
+
357a44f
+const VMStateDescription vmstate_scsi_device = {
357a44f
+    .name = "SCSIDevice",
357a44f
+    .version_id = 1,
357a44f
+    .minimum_version_id = 1,
357a44f
+    .minimum_version_id_old = 1,
357a44f
+    .fields = (VMStateField[]) {
357a44f
+        VMSTATE_UINT8(unit_attention.key, SCSIDevice),
357a44f
+        VMSTATE_UINT8(unit_attention.asc, SCSIDevice),
357a44f
+        VMSTATE_UINT8(unit_attention.ascq, SCSIDevice),
357a44f
+        VMSTATE_BOOL(sense_is_ua, SCSIDevice),
357a44f
+        VMSTATE_UINT8_ARRAY(sense, SCSIDevice, SCSI_SENSE_BUF_SIZE),
357a44f
+        VMSTATE_UINT32(sense_len, SCSIDevice),
357a44f
+        {
357a44f
+            .name         = "requests",
357a44f
+            .version_id   = 0,
357a44f
+            .field_exists = NULL,
357a44f
+            .size         = 0,   /* ouch */
357a44f
+            .info         = &vmstate_info_scsi_requests,
357a44f
+            .flags        = VMS_SINGLE,
357a44f
+            .offset       = 0,
357a44f
+        },
357a44f
+        VMSTATE_END_OF_LIST()
357a44f
+    }
357a44f
+};
357a44f
diff -ruNp qemu-kvm-1.0/hw/scsi-disk.c qemu-kvm-1.0.virtio-scsi/hw/scsi-disk.c
357a44f
--- qemu-kvm-1.0/hw/scsi-disk.c	2011-12-04 04:38:06.000000000 -0600
357a44f
+++ qemu-kvm-1.0.virtio-scsi/hw/scsi-disk.c	2012-02-07 14:44:53.429905331 -0600
357a44f
@@ -38,6 +38,7 @@ do { fprintf(stderr, "scsi-disk: " fmt ,
357a44f
 #include "sysemu.h"
357a44f
 #include "blockdev.h"
357a44f
 #include "block_int.h"
357a44f
+#include "dma.h"
357a44f
 
357a44f
 #ifdef __linux
357a44f
 #include <scsi/sg.h>
357a44f
@@ -110,12 +111,12 @@ static void scsi_cancel_io(SCSIRequest *
357a44f
     r->req.aiocb = NULL;
357a44f
 }
357a44f
 
357a44f
-static uint32_t scsi_init_iovec(SCSIDiskReq *r)
357a44f
+static uint32_t scsi_init_iovec(SCSIDiskReq *r, size_t size)
357a44f
 {
357a44f
     SCSIDiskState *s = DO_UPCAST(SCSIDiskState, qdev, r->req.dev);
357a44f
 
357a44f
     if (!r->iov.iov_base) {
357a44f
-        r->buflen = SCSI_DMA_BUF_SIZE;
357a44f
+        r->buflen = size;
357a44f
         r->iov.iov_base = qemu_blockalign(s->qdev.conf.bs, r->buflen);
357a44f
     }
357a44f
     r->iov.iov_len = MIN(r->sector_count * 512, r->buflen);
357a44f
@@ -123,6 +124,56 @@ static uint32_t scsi_init_iovec(SCSIDisk
357a44f
     return r->qiov.size / 512;
357a44f
 }
357a44f
 
357a44f
+static void scsi_disk_save_request(QEMUFile *f, SCSIRequest *req)
357a44f
+{
357a44f
+    SCSIDiskReq *r = DO_UPCAST(SCSIDiskReq, req, req);
357a44f
+
357a44f
+    qemu_put_be64s(f, &r->sector);
357a44f
+    qemu_put_be32s(f, &r->sector_count);
357a44f
+    qemu_put_be32s(f, &r->buflen);
357a44f
+    if (r->buflen && r->req.cmd.mode == SCSI_XFER_TO_DEV) {
357a44f
+        qemu_put_buffer(f, r->iov.iov_base, r->iov.iov_len);
357a44f
+    }
357a44f
+}
357a44f
+
357a44f
+static void scsi_disk_load_request(QEMUFile *f, SCSIRequest *req)
357a44f
+{
357a44f
+    SCSIDiskReq *r = DO_UPCAST(SCSIDiskReq, req, req);
357a44f
+
357a44f
+    qemu_get_be64s(f, &r->sector);
357a44f
+    qemu_get_be32s(f, &r->sector_count);
357a44f
+    qemu_get_be32s(f, &r->buflen);
357a44f
+    if (r->buflen) {
357a44f
+        scsi_init_iovec(r, r->buflen);
357a44f
+        if (r->req.cmd.mode == SCSI_XFER_TO_DEV) {
357a44f
+            qemu_get_buffer(f, r->iov.iov_base, r->iov.iov_len);
357a44f
+        }
357a44f
+    }
357a44f
+
357a44f
+    qemu_iovec_init_external(&r->qiov, &r->iov, 1);
357a44f
+}
357a44f
+
357a44f
+static void scsi_dma_complete(void * opaque, int ret)
357a44f
+{
357a44f
+    SCSIDiskReq *r = (SCSIDiskReq *)opaque;
357a44f
+    SCSIDiskState *s = DO_UPCAST(SCSIDiskState, qdev, r->req.dev);
357a44f
+
357a44f
+    bdrv_acct_done(s->qdev.conf.bs, &r->acct);
357a44f
+
357a44f
+    if (ret) {
357a44f
+        if (scsi_handle_rw_error(r, -ret)) {
357a44f
+            goto done;
357a44f
+        }
357a44f
+    }
357a44f
+
357a44f
+    r->sector += r->sector_count;
357a44f
+    r->sector_count = 0;
357a44f
+    scsi_req_complete(&r->req, GOOD);
357a44f
+
357a44f
+done:
357a44f
+    scsi_req_unref(&r->req);
357a44f
+}
357a44f
+
357a44f
 static void scsi_read_complete(void * opaque, int ret)
357a44f
 {
357a44f
     SCSIDiskReq *r = (SCSIDiskReq *)opaque;
357a44f
@@ -213,10 +264,17 @@ static void scsi_read_data(SCSIRequest *
357a44f
         return;
357a44f
     }
357a44f
 
357a44f
-    n = scsi_init_iovec(r);
357a44f
-    bdrv_acct_start(s->qdev.conf.bs, &r->acct, n * BDRV_SECTOR_SIZE, BDRV_ACCT_READ);
357a44f
-    r->req.aiocb = bdrv_aio_readv(s->qdev.conf.bs, r->sector, &r->qiov, n,
357a44f
-                              scsi_read_complete, r);
357a44f
+    if (r->req.sg) {
357a44f
+        dma_acct_start(s->qdev.conf.bs, &r->acct, r->req.sg, BDRV_ACCT_READ);
357a44f
+	r->req.resid -= r->req.sg->size;
357a44f
+        r->req.aiocb = dma_bdrv_read(s->qdev.conf.bs, r->req.sg, r->sector,
357a44f
+                                     scsi_dma_complete, r);
357a44f
+    } else {
357a44f
+        n = scsi_init_iovec(r, SCSI_DMA_BUF_SIZE);
357a44f
+        bdrv_acct_start(s->qdev.conf.bs, &r->acct, n * BDRV_SECTOR_SIZE, BDRV_ACCT_READ);
357a44f
+        r->req.aiocb = bdrv_aio_readv(s->qdev.conf.bs, r->sector, &r->qiov, n,
357a44f
+                                      scsi_read_complete, r);
357a44f
+    }
357a44f
     if (r->req.aiocb == NULL) {
357a44f
         scsi_read_complete(r, -EIO);
357a44f
     }
357a44f
@@ -290,7 +348,7 @@ static void scsi_write_complete(void * o
357a44f
     if (r->sector_count == 0) {
357a44f
         scsi_req_complete(&r->req, GOOD);
357a44f
     } else {
357a44f
-        scsi_init_iovec(r);
357a44f
+        scsi_init_iovec(r, SCSI_DMA_BUF_SIZE);
357a44f
         DPRINTF("Write complete tag=0x%x more=%d\n", r->req.tag, r->qiov.size);
357a44f
         scsi_req_data(&r->req, r->qiov.size);
357a44f
     }
357a44f
@@ -318,21 +376,29 @@ static void scsi_write_data(SCSIRequest
357a44f
         return;
357a44f
     }
357a44f
 
357a44f
-    n = r->qiov.size / 512;
357a44f
-    if (n) {
357a44f
-        if (s->tray_open) {
357a44f
-            scsi_write_complete(r, -ENOMEDIUM);
357a44f
-            return;
357a44f
-        }
357a44f
+    if (!r->req.sg && !r->qiov.size) {
357a44f
+        /* Called for the first time.  Ask the driver to send us more data.  */
357a44f
+        scsi_write_complete(r, 0);
357a44f
+        return;
357a44f
+    }
357a44f
+    if (s->tray_open) {
357a44f
+        scsi_write_complete(r, -ENOMEDIUM);
357a44f
+        return;
357a44f
+    }
357a44f
+
357a44f
+    if (r->req.sg) {
357a44f
+        dma_acct_start(s->qdev.conf.bs, &r->acct, r->req.sg, BDRV_ACCT_WRITE);
357a44f
+	r->req.resid -= r->req.sg->size;
357a44f
+        r->req.aiocb = dma_bdrv_write(s->qdev.conf.bs, r->req.sg, r->sector,
357a44f
+                                      scsi_dma_complete, r);
357a44f
+    } else {
357a44f
+        n = r->qiov.size / 512;
357a44f
         bdrv_acct_start(s->qdev.conf.bs, &r->acct, n * BDRV_SECTOR_SIZE, BDRV_ACCT_WRITE);
357a44f
         r->req.aiocb = bdrv_aio_writev(s->qdev.conf.bs, r->sector, &r->qiov, n,
357a44f
                                        scsi_write_complete, r);
357a44f
-        if (r->req.aiocb == NULL) {
357a44f
-            scsi_write_complete(r, -ENOMEM);
357a44f
-        }
357a44f
-    } else {
357a44f
-        /* Called for the first time.  Ask the driver to send us more data.  */
357a44f
-        scsi_write_complete(r, 0);
357a44f
+    }
357a44f
+    if (r->req.aiocb == NULL) {
357a44f
+        scsi_write_complete(r, -ENOMEM);
357a44f
     }
357a44f
 }
357a44f
 
357a44f
@@ -1601,6 +1667,8 @@ static const SCSIReqOps scsi_disk_reqops
357a44f
     .write_data   = scsi_write_data,
357a44f
     .cancel_io    = scsi_cancel_io,
357a44f
     .get_buf      = scsi_get_buf,
357a44f
+    .load_request = scsi_disk_load_request,
357a44f
+    .save_request = scsi_disk_save_request,
357a44f
 };
357a44f
 
357a44f
 static SCSIRequest *scsi_new_request(SCSIDevice *d, uint32_t tag, uint32_t lun,
357a44f
@@ -1729,6 +1797,22 @@ static SCSIRequest *scsi_block_new_reque
357a44f
     DEFINE_PROP_STRING("ver",  SCSIDiskState, version),         \
357a44f
     DEFINE_PROP_STRING("serial",  SCSIDiskState, serial)
357a44f
 
357a44f
+static const VMStateDescription vmstate_scsi_disk_state = {
357a44f
+    .name = "scsi-disk",
357a44f
+    .version_id = 1,
357a44f
+    .minimum_version_id = 1,
357a44f
+    .minimum_version_id_old = 1,
357a44f
+    .fields = (VMStateField[]) {
357a44f
+        VMSTATE_SCSI_DEVICE(qdev, SCSIDiskState),
357a44f
+        VMSTATE_BOOL(media_changed, SCSIDiskState),
357a44f
+        VMSTATE_BOOL(media_event, SCSIDiskState),
357a44f
+        VMSTATE_BOOL(eject_request, SCSIDiskState),
357a44f
+        VMSTATE_BOOL(tray_open, SCSIDiskState),
357a44f
+        VMSTATE_BOOL(tray_locked, SCSIDiskState),
357a44f
+        VMSTATE_END_OF_LIST()
357a44f
+    }
357a44f
+};
357a44f
+
357a44f
 static SCSIDeviceInfo scsi_disk_info[] = {
357a44f
     {
357a44f
         .qdev.name    = "scsi-hd",
357a44f
@@ -1736,6 +1820,7 @@ static SCSIDeviceInfo scsi_disk_info[] =
357a44f
         .qdev.desc    = "virtual SCSI disk",
357a44f
         .qdev.size    = sizeof(SCSIDiskState),
357a44f
         .qdev.reset   = scsi_disk_reset,
357a44f
+        .qdev.vmsd    = &vmstate_scsi_disk_state,
357a44f
         .init         = scsi_hd_initfn,
357a44f
         .destroy      = scsi_destroy,
357a44f
         .alloc_req    = scsi_new_request,
357a44f
@@ -1751,6 +1836,7 @@ static SCSIDeviceInfo scsi_disk_info[] =
357a44f
         .qdev.desc    = "virtual SCSI CD-ROM",
357a44f
         .qdev.size    = sizeof(SCSIDiskState),
357a44f
         .qdev.reset   = scsi_disk_reset,
357a44f
+        .qdev.vmsd    = &vmstate_scsi_disk_state,
357a44f
         .init         = scsi_cd_initfn,
357a44f
         .destroy      = scsi_destroy,
357a44f
         .alloc_req    = scsi_new_request,
357a44f
@@ -1766,6 +1852,7 @@ static SCSIDeviceInfo scsi_disk_info[] =
357a44f
         .qdev.desc    = "SCSI block device passthrough",
357a44f
         .qdev.size    = sizeof(SCSIDiskState),
357a44f
         .qdev.reset   = scsi_disk_reset,
357a44f
+        .qdev.vmsd    = &vmstate_scsi_disk_state,
357a44f
         .init         = scsi_block_initfn,
357a44f
         .destroy      = scsi_destroy,
357a44f
         .alloc_req    = scsi_block_new_request,
357a44f
@@ -1780,6 +1867,7 @@ static SCSIDeviceInfo scsi_disk_info[] =
357a44f
         .qdev.desc    = "virtual SCSI disk or CD-ROM (legacy)",
357a44f
         .qdev.size    = sizeof(SCSIDiskState),
357a44f
         .qdev.reset   = scsi_disk_reset,
357a44f
+        .qdev.vmsd    = &vmstate_scsi_disk_state,
357a44f
         .init         = scsi_disk_initfn,
357a44f
         .destroy      = scsi_destroy,
357a44f
         .alloc_req    = scsi_new_request,
357a44f
diff -ruNp qemu-kvm-1.0/hw/scsi-generic.c qemu-kvm-1.0.virtio-scsi/hw/scsi-generic.c
357a44f
--- qemu-kvm-1.0/hw/scsi-generic.c	2011-12-04 04:38:06.000000000 -0600
357a44f
+++ qemu-kvm-1.0.virtio-scsi/hw/scsi-generic.c	2012-02-07 14:44:53.430905347 -0600
357a44f
@@ -59,6 +59,28 @@ typedef struct SCSIGenericReq {
357a44f
     sg_io_hdr_t io_header;
357a44f
 } SCSIGenericReq;
357a44f
 
357a44f
+static void scsi_generic_save_request(QEMUFile *f, SCSIRequest *req)
357a44f
+{
357a44f
+    SCSIGenericReq *r = DO_UPCAST(SCSIGenericReq, req, req);
357a44f
+
357a44f
+    qemu_put_sbe32s(f, &r->buflen);
357a44f
+    if (r->buflen && r->req.cmd.mode == SCSI_XFER_TO_DEV) {
357a44f
+        assert(!r->req.sg);
357a44f
+        qemu_put_buffer(f, r->buf, r->req.cmd.xfer);
357a44f
+    }
357a44f
+}
357a44f
+
357a44f
+static void scsi_generic_load_request(QEMUFile *f, SCSIRequest *req)
357a44f
+{
357a44f
+    SCSIGenericReq *r = DO_UPCAST(SCSIGenericReq, req, req);
357a44f
+
357a44f
+    qemu_get_sbe32s(f, &r->buflen);
357a44f
+    if (r->buflen && r->req.cmd.mode == SCSI_XFER_TO_DEV) {
357a44f
+        assert(!r->req.sg);
357a44f
+        qemu_get_buffer(f, r->buf, r->req.cmd.xfer);
357a44f
+    }
357a44f
+}
357a44f
+
357a44f
 static void scsi_free_request(SCSIRequest *req)
357a44f
 {
357a44f
     SCSIGenericReq *r = DO_UPCAST(SCSIGenericReq, req, req);
357a44f
@@ -450,6 +472,8 @@ const SCSIReqOps scsi_generic_req_ops =
357a44f
     .write_data   = scsi_write_data,
357a44f
     .cancel_io    = scsi_cancel_io,
357a44f
     .get_buf      = scsi_get_buf,
357a44f
+    .load_request = scsi_generic_load_request,
357a44f
+    .save_request = scsi_generic_save_request,
357a44f
 };
357a44f
 
357a44f
 static SCSIRequest *scsi_new_request(SCSIDevice *d, uint32_t tag, uint32_t lun,
357a44f
@@ -467,6 +491,7 @@ static SCSIDeviceInfo scsi_generic_info
357a44f
     .qdev.desc    = "pass through generic scsi device (/dev/sg*)",
357a44f
     .qdev.size    = sizeof(SCSIDevice),
357a44f
     .qdev.reset   = scsi_generic_reset,
357a44f
+    .qdev.vmsd    = &vmstate_scsi_device,
357a44f
     .init         = scsi_generic_initfn,
357a44f
     .destroy      = scsi_destroy,
357a44f
     .alloc_req    = scsi_new_request,
357a44f
diff -ruNp qemu-kvm-1.0/hw/scsi.h qemu-kvm-1.0.virtio-scsi/hw/scsi.h
357a44f
--- qemu-kvm-1.0/hw/scsi.h	2011-12-04 04:38:06.000000000 -0600
357a44f
+++ qemu-kvm-1.0.virtio-scsi/hw/scsi.h	2012-02-07 14:44:53.430905347 -0600
357a44f
@@ -47,8 +47,11 @@ struct SCSIRequest {
357a44f
     uint32_t          tag;
357a44f
     uint32_t          lun;
357a44f
     uint32_t          status;
357a44f
+    size_t            resid;
357a44f
     SCSICommand       cmd;
357a44f
     BlockDriverAIOCB  *aiocb;
357a44f
+    QEMUSGList        *sg;
357a44f
+    bool              dma_started;
357a44f
     uint8_t sense[SCSI_SENSE_BUF_SIZE];
357a44f
     uint32_t sense_len;
357a44f
     bool enqueued;
357a44f
@@ -78,6 +81,16 @@ struct SCSIDevice
357a44f
     uint64_t max_lba;
357a44f
 };
357a44f
 
357a44f
+extern const VMStateDescription vmstate_scsi_device;
357a44f
+
357a44f
+#define VMSTATE_SCSI_DEVICE(_field, _state) {                        \
357a44f
+    .name       = (stringify(_field)),                               \
357a44f
+    .size       = sizeof(SCSIDevice),                                \
357a44f
+    .vmsd       = &vmstate_scsi_device,                              \
357a44f
+    .flags      = VMS_STRUCT,                                        \
357a44f
+    .offset     = vmstate_offset_value(_state, _field, SCSIDevice),  \
357a44f
+}
357a44f
+
357a44f
 /* cdrom.c */
357a44f
 int cdrom_read_toc(int nb_sectors, uint8_t *buf, int msf, int start_track);
357a44f
 int cdrom_read_toc_raw(int nb_sectors, uint8_t *buf, int msf, int session_num);
357a44f
@@ -91,6 +104,9 @@ struct SCSIReqOps {
357a44f
     void (*write_data)(SCSIRequest *req);
357a44f
     void (*cancel_io)(SCSIRequest *req);
357a44f
     uint8_t *(*get_buf)(SCSIRequest *req);
357a44f
+
357a44f
+    void (*save_request)(QEMUFile *f, SCSIRequest *req);
357a44f
+    void (*load_request)(QEMUFile *f, SCSIRequest *req);
357a44f
 };
357a44f
 
357a44f
 typedef int (*scsi_qdev_initfn)(SCSIDevice *dev);
357a44f
@@ -107,8 +123,12 @@ struct SCSIBusInfo {
357a44f
     int tcq;
357a44f
     int max_channel, max_target, max_lun;
357a44f
     void (*transfer_data)(SCSIRequest *req, uint32_t arg);
357a44f
-    void (*complete)(SCSIRequest *req, uint32_t arg);
357a44f
+    void (*complete)(SCSIRequest *req, uint32_t arg, int32_t len);
357a44f
     void (*cancel)(SCSIRequest *req);
357a44f
+    QEMUSGList *(*get_sg_list)(SCSIRequest *req);
357a44f
+
357a44f
+    void (*save_request)(QEMUFile *f, SCSIRequest *req);
357a44f
+    void *(*load_request)(QEMUFile *f, SCSIRequest *req);
357a44f
 };
357a44f
 
357a44f
 struct SCSIBus {
357a44f
diff -ruNp qemu-kvm-1.0/hw/spapr_vscsi.c qemu-kvm-1.0.virtio-scsi/hw/spapr_vscsi.c
357a44f
--- qemu-kvm-1.0/hw/spapr_vscsi.c	2011-12-04 04:38:06.000000000 -0600
357a44f
+++ qemu-kvm-1.0.virtio-scsi/hw/spapr_vscsi.c	2012-02-07 14:44:53.430905347 -0600
357a44f
@@ -494,7 +494,7 @@ static void vscsi_transfer_data(SCSIRequ
357a44f
 }
357a44f
 
357a44f
 /* Callback to indicate that the SCSI layer has completed a transfer.  */
357a44f
-static void vscsi_command_complete(SCSIRequest *sreq, uint32_t status)
357a44f
+static void vscsi_command_complete(SCSIRequest *sreq, uint32_t status, int32_t resid)
357a44f
 {
357a44f
     VSCSIState *s = DO_UPCAST(VSCSIState, vdev.qdev, sreq->bus->qbus.parent);
357a44f
     vscsi_req *req = sreq->hba_private;
357a44f
diff -ruNp qemu-kvm-1.0/hw/usb-msd.c qemu-kvm-1.0.virtio-scsi/hw/usb-msd.c
357a44f
--- qemu-kvm-1.0/hw/usb-msd.c	2012-02-07 14:44:04.881123501 -0600
357a44f
+++ qemu-kvm-1.0.virtio-scsi/hw/usb-msd.c	2012-02-07 14:44:53.431905363 -0600
357a44f
@@ -223,7 +223,7 @@ static void usb_msd_transfer_data(SCSIRe
357a44f
     }
357a44f
 }
357a44f
 
357a44f
-static void usb_msd_command_complete(SCSIRequest *req, uint32_t status)
357a44f
+static void usb_msd_command_complete(SCSIRequest *req, uint32_t status, int32_t resid)
357a44f
 {
357a44f
     MSDState *s = DO_UPCAST(MSDState, dev.qdev, req->bus->qbus.parent);
357a44f
     USBPacket *p = s->packet;
357a44f
diff -ruNp qemu-kvm-1.0/hw/virtio.h qemu-kvm-1.0.virtio-scsi/hw/virtio.h
357a44f
--- qemu-kvm-1.0/hw/virtio.h	2011-12-04 04:38:06.000000000 -0600
357a44f
+++ qemu-kvm-1.0.virtio-scsi/hw/virtio.h	2012-02-07 14:44:53.433905395 -0600
357a44f
@@ -199,6 +199,8 @@ VirtIODevice *virtio_net_init(DeviceStat
357a44f
 typedef struct virtio_serial_conf virtio_serial_conf;
357a44f
 VirtIODevice *virtio_serial_init(DeviceState *dev, virtio_serial_conf *serial);
357a44f
 VirtIODevice *virtio_balloon_init(DeviceState *dev);
357a44f
+typedef struct VirtIOSCSIConf VirtIOSCSIConf;
357a44f
+VirtIODevice *virtio_scsi_init(DeviceState *dev, VirtIOSCSIConf *conf);
357a44f
 #ifdef CONFIG_LINUX
357a44f
 VirtIODevice *virtio_9p_init(DeviceState *dev, V9fsConf *conf);
357a44f
 #endif
357a44f
@@ -208,6 +210,7 @@ void virtio_net_exit(VirtIODevice *vdev)
357a44f
 void virtio_blk_exit(VirtIODevice *vdev);
357a44f
 void virtio_serial_exit(VirtIODevice *vdev);
357a44f
 void virtio_balloon_exit(VirtIODevice *vdev);
357a44f
+void virtio_scsi_exit(VirtIODevice *vdev);
357a44f
 
357a44f
 #define DEFINE_VIRTIO_COMMON_FEATURES(_state, _field) \
357a44f
 	DEFINE_PROP_BIT("indirect_desc", _state, _field, \
357a44f
diff -ruNp qemu-kvm-1.0/hw/virtio-pci.c qemu-kvm-1.0.virtio-scsi/hw/virtio-pci.c
357a44f
--- qemu-kvm-1.0/hw/virtio-pci.c	2012-02-07 14:44:04.850123002 -0600
357a44f
+++ qemu-kvm-1.0.virtio-scsi/hw/virtio-pci.c	2012-02-07 14:44:53.432905379 -0600
357a44f
@@ -19,6 +19,7 @@
357a44f
 #include "virtio-blk.h"
357a44f
 #include "virtio-net.h"
357a44f
 #include "virtio-serial.h"
357a44f
+#include "virtio-scsi.h"
357a44f
 #include "pci.h"
357a44f
 #include "qemu-error.h"
357a44f
 #include "msix.h"
357a44f
@@ -855,6 +856,32 @@ static int virtio_balloon_exit_pci(PCIDe
357a44f
     return virtio_exit_pci(pci_dev);
357a44f
 }
357a44f
 
357a44f
+static int virtio_scsi_init_pci(PCIDevice *pci_dev)
357a44f
+{
357a44f
+    VirtIOPCIProxy *proxy = DO_UPCAST(VirtIOPCIProxy, pci_dev, pci_dev);
357a44f
+    VirtIODevice *vdev;
357a44f
+
357a44f
+    vdev = virtio_scsi_init(&pci_dev->qdev, &proxy->scsi);
357a44f
+    if (!vdev) {
357a44f
+        return -EINVAL;
357a44f
+    }
357a44f
+
357a44f
+    vdev->nvectors = proxy->nvectors;
357a44f
+    virtio_init_pci(proxy, vdev);
357a44f
+
357a44f
+    /* make the actual value visible */
357a44f
+    proxy->nvectors = vdev->nvectors;
357a44f
+    return 0;
357a44f
+}
357a44f
+
357a44f
+static int virtio_scsi_exit_pci(PCIDevice *pci_dev)
357a44f
+{
357a44f
+    VirtIOPCIProxy *proxy = DO_UPCAST(VirtIOPCIProxy, pci_dev, pci_dev);
357a44f
+
357a44f
+    virtio_scsi_exit(proxy->vdev);
357a44f
+    return virtio_exit_pci(pci_dev);
357a44f
+}
357a44f
+
357a44f
 static PCIDeviceInfo virtio_info[] = {
357a44f
     {
357a44f
         .qdev.name = "virtio-blk-pci",
357a44f
@@ -940,6 +967,21 @@ static PCIDeviceInfo virtio_info[] = {
357a44f
         },
357a44f
         .qdev.reset = virtio_pci_reset,
357a44f
     },{
357a44f
+        .qdev.name = "virtio-scsi-pci",
357a44f
+        .qdev.alias = "virtio-scsi",
357a44f
+        .qdev.size = sizeof(VirtIOPCIProxy),
357a44f
+        .init      = virtio_scsi_init_pci,
357a44f
+        .exit      = virtio_scsi_exit_pci,
357a44f
+        .vendor_id = PCI_VENDOR_ID_REDHAT_QUMRANET,
357a44f
+        .device_id = PCI_DEVICE_ID_VIRTIO_SCSI,
357a44f
+        .class_id  = PCI_CLASS_STORAGE_SCSI,
357a44f
+        .revision  = 0x00,
357a44f
+        .qdev.props = (Property[]) {
357a44f
+            DEFINE_PROP_UINT32("vectors", VirtIOPCIProxy, nvectors, 2),
357a44f
+            DEFINE_VIRTIO_SCSI_PROPERTIES(VirtIOPCIProxy, host_features, scsi),
357a44f
+            DEFINE_PROP_END_OF_LIST(),
357a44f
+        },
357a44f
+    }, {
357a44f
         /* end of list */
357a44f
     }
357a44f
 };
357a44f
diff -ruNp qemu-kvm-1.0/hw/virtio-pci.h qemu-kvm-1.0.virtio-scsi/hw/virtio-pci.h
357a44f
--- qemu-kvm-1.0/hw/virtio-pci.h	2012-02-07 14:44:04.850123002 -0600
357a44f
+++ qemu-kvm-1.0.virtio-scsi/hw/virtio-pci.h	2012-02-07 14:44:53.432905379 -0600
357a44f
@@ -17,6 +17,7 @@
357a44f
 
357a44f
 #include "virtio-net.h"
357a44f
 #include "virtio-serial.h"
357a44f
+#include "virtio-scsi.h"
357a44f
 
357a44f
 /* Performance improves when virtqueue kick processing is decoupled from the
357a44f
  * vcpu thread using ioeventfd for some devices. */
357a44f
@@ -40,6 +41,7 @@ typedef struct {
357a44f
 #endif
357a44f
     virtio_serial_conf serial;
357a44f
     virtio_net_conf net;
357a44f
+    VirtIOSCSIConf scsi;
357a44f
     bool ioeventfd_disabled;
357a44f
     bool ioeventfd_started;
357a44f
 } VirtIOPCIProxy;
357a44f
diff -ruNp qemu-kvm-1.0/hw/virtio-scsi.c qemu-kvm-1.0.virtio-scsi/hw/virtio-scsi.c
357a44f
--- qemu-kvm-1.0/hw/virtio-scsi.c	1969-12-31 18:00:00.000000000 -0600
357a44f
+++ qemu-kvm-1.0.virtio-scsi/hw/virtio-scsi.c	2012-02-07 14:44:53.432905379 -0600
357a44f
@@ -0,0 +1,607 @@
357a44f
+/*
357a44f
+ * Virtio SCSI HBA
357a44f
+ *
357a44f
+ * Copyright IBM, Corp. 2010
357a44f
+ * Copyright Red Hat, Inc. 2011
357a44f
+ *
357a44f
+ * Authors:
357a44f
+ *   Stefan Hajnoczi    <stefanha@linux.vnet.ibm.com>
357a44f
+ *   Paolo Bonzini      <pbonzini@redhat.com>
357a44f
+ *
357a44f
+ * This work is licensed under the terms of the GNU GPL, version 2 or later.
357a44f
+ * See the COPYING file in the top-level directory.
357a44f
+ *
357a44f
+ */
357a44f
+
357a44f
+#include "virtio-scsi.h"
357a44f
+#include <hw/scsi.h>
357a44f
+#include <hw/scsi-defs.h>
357a44f
+
357a44f
+#define VIRTIO_SCSI_VQ_SIZE     128
357a44f
+#define VIRTIO_SCSI_CDB_SIZE    32
357a44f
+#define VIRTIO_SCSI_SENSE_SIZE  96
357a44f
+#define VIRTIO_SCSI_MAX_CHANNEL	0
357a44f
+#define VIRTIO_SCSI_MAX_TARGET  255
357a44f
+#define VIRTIO_SCSI_MAX_LUN     16383
357a44f
+
357a44f
+/* Response codes */
357a44f
+#define VIRTIO_SCSI_S_OK                       0
357a44f
+#define VIRTIO_SCSI_S_OVERRUN                  1
357a44f
+#define VIRTIO_SCSI_S_ABORTED                  2
357a44f
+#define VIRTIO_SCSI_S_BAD_TARGET               3
357a44f
+#define VIRTIO_SCSI_S_RESET                    4
357a44f
+#define VIRTIO_SCSI_S_BUSY                     5
357a44f
+#define VIRTIO_SCSI_S_TRANSPORT_FAILURE        6
357a44f
+#define VIRTIO_SCSI_S_TARGET_FAILURE           7
357a44f
+#define VIRTIO_SCSI_S_NEXUS_FAILURE            8
357a44f
+#define VIRTIO_SCSI_S_FAILURE                  9
357a44f
+#define VIRTIO_SCSI_S_FUNCTION_SUCCEEDED       10
357a44f
+#define VIRTIO_SCSI_S_FUNCTION_REJECTED        11
357a44f
+#define VIRTIO_SCSI_S_INCORRECT_LUN            12
357a44f
+
357a44f
+/* Controlq type codes.  */
357a44f
+#define VIRTIO_SCSI_T_TMF                      0
357a44f
+#define VIRTIO_SCSI_T_AN_QUERY                 1
357a44f
+#define VIRTIO_SCSI_T_AN_SUBSCRIBE             2
357a44f
+
357a44f
+/* Valid TMF subtypes.  */
357a44f
+#define VIRTIO_SCSI_T_TMF_ABORT_TASK           0
357a44f
+#define VIRTIO_SCSI_T_TMF_ABORT_TASK_SET       1
357a44f
+#define VIRTIO_SCSI_T_TMF_CLEAR_ACA            2
357a44f
+#define VIRTIO_SCSI_T_TMF_CLEAR_TASK_SET       3
357a44f
+#define VIRTIO_SCSI_T_TMF_I_T_NEXUS_RESET      4
357a44f
+#define VIRTIO_SCSI_T_TMF_LOGICAL_UNIT_RESET   5
357a44f
+#define VIRTIO_SCSI_T_TMF_QUERY_TASK           6
357a44f
+#define VIRTIO_SCSI_T_TMF_QUERY_TASK_SET       7
357a44f
+
357a44f
+/* Events.  */
357a44f
+#define VIRTIO_SCSI_T_EVENTS_MISSED            0x80000000
357a44f
+#define VIRTIO_SCSI_T_NO_EVENT                 0
357a44f
+#define VIRTIO_SCSI_T_TRANSPORT_RESET          1
357a44f
+#define VIRTIO_SCSI_T_ASYNC_NOTIFY             2
357a44f
+
357a44f
+/* SCSI command request, followed by data-out */
357a44f
+typedef struct {
357a44f
+    uint8_t lun[8];              /* Logical Unit Number */
357a44f
+    uint64_t tag;                /* Command identifier */
357a44f
+    uint8_t task_attr;           /* Task attribute */
357a44f
+    uint8_t prio;
357a44f
+    uint8_t crn;
357a44f
+    uint8_t cdb[];
357a44f
+} QEMU_PACKED VirtIOSCSICmdReq;
357a44f
+
357a44f
+/* Response, followed by sense data and data-in */
357a44f
+typedef struct {
357a44f
+    uint32_t sense_len;          /* Sense data length */
357a44f
+    uint32_t resid;              /* Residual bytes in data buffer */
357a44f
+    uint16_t status_qualifier;   /* Status qualifier */
357a44f
+    uint8_t status;              /* Command completion status */
357a44f
+    uint8_t response;            /* Response values */
357a44f
+    uint8_t sense[];
357a44f
+} QEMU_PACKED VirtIOSCSICmdResp;
357a44f
+
357a44f
+/* Task Management Request */
357a44f
+typedef struct {
357a44f
+    uint32_t type;
357a44f
+    uint32_t subtype;
357a44f
+    uint8_t lun[8];
357a44f
+    uint64_t tag;
357a44f
+} QEMU_PACKED VirtIOSCSICtrlTMFReq;
357a44f
+
357a44f
+typedef struct {
357a44f
+    uint8_t response;
357a44f
+} QEMU_PACKED VirtIOSCSICtrlTMFResp;
357a44f
+
357a44f
+/* Asynchronous notification query/subscription */
357a44f
+typedef struct {
357a44f
+    uint32_t type;
357a44f
+    uint8_t lun[8];
357a44f
+    uint32_t event_requested;
357a44f
+} QEMU_PACKED VirtIOSCSICtrlANReq;
357a44f
+
357a44f
+typedef struct {
357a44f
+    uint32_t event_actual;
357a44f
+    uint8_t response;
357a44f
+} QEMU_PACKED VirtIOSCSICtrlANResp;
357a44f
+
357a44f
+typedef struct {
357a44f
+    uint32_t event;
357a44f
+    uint8_t lun[8];
357a44f
+    uint32_t reason;
357a44f
+} QEMU_PACKED VirtIOSCSIEvent;
357a44f
+
357a44f
+typedef struct {
357a44f
+    uint32_t num_queues;
357a44f
+    uint32_t seg_max;
357a44f
+    uint32_t max_sectors;
357a44f
+    uint32_t cmd_per_lun;
357a44f
+    uint32_t event_info_size;
357a44f
+    uint32_t sense_size;
357a44f
+    uint32_t cdb_size;
357a44f
+    uint16_t max_channel;
357a44f
+    uint16_t max_target;
357a44f
+    uint32_t max_lun;
357a44f
+} QEMU_PACKED VirtIOSCSIConfig;
357a44f
+
357a44f
+typedef struct {
357a44f
+    VirtIODevice vdev;
357a44f
+    DeviceState *qdev;
357a44f
+    VirtIOSCSIConf *conf;
357a44f
+
357a44f
+    SCSIBus bus;
357a44f
+    VirtQueue *ctrl_vq;
357a44f
+    VirtQueue *event_vq;
357a44f
+    VirtQueue *cmd_vq;
357a44f
+    uint32_t sense_size;
357a44f
+    uint32_t cdb_size;
357a44f
+    bool resetting;
357a44f
+} VirtIOSCSI;
357a44f
+
357a44f
+typedef struct VirtIOSCSIReq {
357a44f
+    VirtIOSCSI *dev;
357a44f
+    VirtQueue *vq;
357a44f
+    VirtQueueElement elem;
357a44f
+    QEMUSGList qsgl;
357a44f
+    SCSIRequest *sreq;
357a44f
+    union {
357a44f
+        char                  *buf;
357a44f
+        VirtIOSCSICmdReq      *cmd;
357a44f
+        VirtIOSCSICtrlTMFReq  *tmf;
357a44f
+        VirtIOSCSICtrlANReq   *an;
357a44f
+    } req;
357a44f
+    union {
357a44f
+        char                  *buf;
357a44f
+        VirtIOSCSICmdResp     *cmd;
357a44f
+        VirtIOSCSICtrlTMFResp *tmf;
357a44f
+        VirtIOSCSICtrlANResp  *an;
357a44f
+        VirtIOSCSIEvent       *event;
357a44f
+    } resp;
357a44f
+} VirtIOSCSIReq;
357a44f
+
357a44f
+static inline int virtio_scsi_get_lun(uint8_t *lun)
357a44f
+{
357a44f
+    return ((lun[2] << 8) | lun[3]) & 0x3FFF;
357a44f
+}
357a44f
+
357a44f
+static inline SCSIDevice *virtio_scsi_device_find(VirtIOSCSI *s, uint8_t *lun)
357a44f
+{
357a44f
+    if (lun[0] != 1) {
357a44f
+        return NULL;
357a44f
+    }
357a44f
+    if (lun[2] != 0 && !(lun[2] >= 0x40 && lun[2] < 0x80)) {
357a44f
+        return NULL;
357a44f
+    }
357a44f
+    return scsi_device_find(&s->bus, 0, lun[1], virtio_scsi_get_lun(lun));
357a44f
+}
357a44f
+
357a44f
+static void virtio_scsi_complete_req(VirtIOSCSIReq *req)
357a44f
+{
357a44f
+    VirtIOSCSI *s = req->dev;
357a44f
+    VirtQueue *vq = req->vq;
357a44f
+    virtqueue_push(vq, &req->elem, req->qsgl.size + req->elem.in_sg[0].iov_len);
357a44f
+    qemu_sglist_destroy(&req->qsgl);
357a44f
+    if (req->sreq) {
357a44f
+        req->sreq->hba_private = NULL;
357a44f
+        scsi_req_unref(req->sreq);
357a44f
+    }
357a44f
+    g_free(req);
357a44f
+    virtio_notify(&s->vdev, vq);
357a44f
+}
357a44f
+
357a44f
+static void virtio_scsi_bad_req(void)
357a44f
+{
357a44f
+    error_report("wrong size for virtio-scsi headers");
357a44f
+    exit(1);
357a44f
+}
357a44f
+
357a44f
+static void qemu_sgl_init_external(QEMUSGList *qsgl, struct iovec *sg,
357a44f
+                                   target_phys_addr_t *addr, int num)
357a44f
+{
357a44f
+    memset(qsgl, 0, sizeof(*qsgl));
357a44f
+    while (num--) {
357a44f
+        qemu_sglist_add(qsgl, *(addr++), (sg++)->iov_len);
357a44f
+    }
357a44f
+}
357a44f
+
357a44f
+static void virtio_scsi_parse_req(VirtIOSCSI *s, VirtQueue *vq,
357a44f
+                                  VirtIOSCSIReq *req)
357a44f
+{
357a44f
+    assert(req->elem.out_num && req->elem.in_num);
357a44f
+    req->vq = vq;
357a44f
+    req->dev = s;
357a44f
+    req->sreq = NULL;
357a44f
+    req->req.buf = req->elem.out_sg[0].iov_base;
357a44f
+    req->resp.buf = req->elem.in_sg[0].iov_base;
357a44f
+
357a44f
+    if (req->elem.out_num > 1) {
357a44f
+        qemu_sgl_init_external(&req->qsgl, &req->elem.out_sg[1],
357a44f
+                               &req->elem.out_addr[1],
357a44f
+                               req->elem.out_num - 1);
357a44f
+    } else {
357a44f
+        qemu_sgl_init_external(&req->qsgl, &req->elem.in_sg[1],
357a44f
+                               &req->elem.in_addr[1],
357a44f
+                               req->elem.in_num - 1);
357a44f
+    }
357a44f
+}
357a44f
+
357a44f
+static VirtIOSCSIReq *virtio_scsi_pop_req(VirtIOSCSI *s, VirtQueue *vq)
357a44f
+{
357a44f
+    VirtIOSCSIReq *req;
357a44f
+    req = g_malloc(sizeof(*req));
357a44f
+    if (!virtqueue_pop(vq, &req->elem)) {
357a44f
+        g_free(req);
357a44f
+        return NULL;
357a44f
+    }
357a44f
+
357a44f
+    virtio_scsi_parse_req(s, vq, req);
357a44f
+    return req;
357a44f
+}
357a44f
+
357a44f
+static void virtio_scsi_save_request(QEMUFile *f, SCSIRequest *sreq)
357a44f
+{
357a44f
+    VirtIOSCSIReq *req = sreq->hba_private;
357a44f
+
357a44f
+    qemu_put_buffer(f, (unsigned char*)&req->elem, sizeof(req->elem));
357a44f
+}
357a44f
+
357a44f
+static void *virtio_scsi_load_request(QEMUFile *f, SCSIRequest *sreq)
357a44f
+{
357a44f
+    SCSIBus *bus = sreq->bus;
357a44f
+    VirtIOSCSI *s = container_of(bus, VirtIOSCSI, bus);
357a44f
+    VirtIOSCSIReq *req;
357a44f
+
357a44f
+    req = g_malloc(sizeof(*req));
357a44f
+    qemu_get_buffer(f, (unsigned char*)&req->elem, sizeof(req->elem));
357a44f
+    virtio_scsi_parse_req(s, s->cmd_vq, req);
357a44f
+
357a44f
+    scsi_req_ref(sreq);
357a44f
+    req->sreq = sreq;
357a44f
+    if (req->sreq->cmd.mode != SCSI_XFER_NONE) {
357a44f
+        int req_mode =
357a44f
+            (req->elem.in_num > 1 ? SCSI_XFER_FROM_DEV : SCSI_XFER_TO_DEV);
357a44f
+
357a44f
+	assert (req->sreq->cmd.mode == req_mode);
357a44f
+    }
357a44f
+    return req;
357a44f
+}
357a44f
+
357a44f
+static void virtio_scsi_do_tmf(VirtIOSCSI *s, VirtIOSCSIReq *req)
357a44f
+{
357a44f
+    SCSIDevice *d = virtio_scsi_device_find(s, req->req.cmd->lun);
357a44f
+    SCSIRequest *r, *next;
357a44f
+    DeviceState *qdev;
357a44f
+    int target;
357a44f
+
357a44f
+    switch (req->req.tmf->subtype) {
357a44f
+    case VIRTIO_SCSI_T_TMF_ABORT_TASK:
357a44f
+    case VIRTIO_SCSI_T_TMF_QUERY_TASK:
357a44f
+        d = virtio_scsi_device_find(s, req->req.cmd->lun);
357a44f
+        if (!d) {
357a44f
+            goto fail;
357a44f
+        }
357a44f
+        if (d->lun != virtio_scsi_get_lun(req->req.cmd->lun)) {
357a44f
+            req->resp.tmf->response = VIRTIO_SCSI_S_INCORRECT_LUN;
357a44f
+            break;
357a44f
+        }
357a44f
+        QTAILQ_FOREACH_SAFE(r, &d->requests, next, next) {
357a44f
+            if (r->tag == req->req.cmd->tag) {
357a44f
+                break;
357a44f
+            }
357a44f
+        }
357a44f
+        if (r && r->hba_private) {
357a44f
+            if (req->req.tmf->subtype == VIRTIO_SCSI_T_TMF_ABORT_TASK) {
357a44f
+                scsi_req_cancel(r);
357a44f
+            }
357a44f
+            req->resp.tmf->response = VIRTIO_SCSI_S_FUNCTION_SUCCEEDED;
357a44f
+        } else {
357a44f
+            req->resp.tmf->response = VIRTIO_SCSI_S_OK;
357a44f
+        }
357a44f
+        break;
357a44f
+
357a44f
+    case VIRTIO_SCSI_T_TMF_LOGICAL_UNIT_RESET:
357a44f
+        d = virtio_scsi_device_find(s, req->req.cmd->lun);
357a44f
+        if (!d) {
357a44f
+            goto fail;
357a44f
+        }
357a44f
+        if (d->lun == virtio_scsi_get_lun(req->req.cmd->lun)) {
357a44f
+            s->resetting++;
357a44f
+            qdev_reset_all(&d->qdev);
357a44f
+            s->resetting--;
357a44f
+        }
357a44f
+        break;
357a44f
+
357a44f
+    case VIRTIO_SCSI_T_TMF_ABORT_TASK_SET:
357a44f
+    case VIRTIO_SCSI_T_TMF_CLEAR_TASK_SET:
357a44f
+    case VIRTIO_SCSI_T_TMF_QUERY_TASK_SET:
357a44f
+        d = virtio_scsi_device_find(s, req->req.cmd->lun);
357a44f
+        if (!d) {
357a44f
+            goto fail;
357a44f
+        }
357a44f
+        if (d->lun != virtio_scsi_get_lun(req->req.cmd->lun)) {
357a44f
+            req->resp.tmf->response = VIRTIO_SCSI_S_INCORRECT_LUN;
357a44f
+            break;
357a44f
+        }
357a44f
+        req->resp.tmf->response = VIRTIO_SCSI_S_OK;
357a44f
+        QTAILQ_FOREACH_SAFE(r, &d->requests, next, next) {
357a44f
+            if (r->hba_private) {
357a44f
+                if (req->req.tmf->subtype != VIRTIO_SCSI_T_TMF_QUERY_TASK) {
357a44f
+                    scsi_req_cancel(r);
357a44f
+                }
357a44f
+                req->resp.tmf->response = VIRTIO_SCSI_S_FUNCTION_SUCCEEDED;
357a44f
+            }
357a44f
+        }
357a44f
+        break;
357a44f
+
357a44f
+    case VIRTIO_SCSI_T_TMF_I_T_NEXUS_RESET:
357a44f
+        target = req->req.cmd->lun[1];
357a44f
+        s->resetting++;
357a44f
+        QTAILQ_FOREACH(qdev, &s->bus.qbus.children, sibling) {
357a44f
+             d = DO_UPCAST(SCSIDevice, qdev, qdev);
357a44f
+             if (d->channel == 0 && d->id == target) {
357a44f
+                qdev_reset_all(&d->qdev);
357a44f
+             }
357a44f
+        }
357a44f
+        s->resetting--;
357a44f
+        break;
357a44f
+
357a44f
+    case VIRTIO_SCSI_T_TMF_CLEAR_ACA:
357a44f
+    default:
357a44f
+        req->resp.tmf->response = VIRTIO_SCSI_S_FUNCTION_REJECTED;
357a44f
+        break;
357a44f
+    }
357a44f
+
357a44f
+    return;
357a44f
+
357a44f
+fail:
357a44f
+    req->resp.tmf->response = VIRTIO_SCSI_S_BAD_TARGET;
357a44f
+}
357a44f
+
357a44f
+static void virtio_scsi_handle_ctrl(VirtIODevice *vdev, VirtQueue *vq)
357a44f
+{
357a44f
+    VirtIOSCSI *s = (VirtIOSCSI *)vdev;
357a44f
+    VirtIOSCSIReq *req;
357a44f
+
357a44f
+    while ((req = virtio_scsi_pop_req(s, vq))) {
357a44f
+        int out_size, in_size;
357a44f
+        if (req->elem.out_num < 1 || req->elem.in_num < 1) {
357a44f
+            virtio_scsi_bad_req();
357a44f
+            continue;
357a44f
+        }
357a44f
+
357a44f
+        out_size = req->elem.out_sg[0].iov_len;
357a44f
+        in_size = req->elem.in_sg[0].iov_len;
357a44f
+        if (req->req.tmf->type == VIRTIO_SCSI_T_TMF) {
357a44f
+            if (out_size < sizeof(VirtIOSCSICtrlTMFReq) ||
357a44f
+                in_size < sizeof(VirtIOSCSICtrlTMFResp)) {
357a44f
+                virtio_scsi_bad_req();
357a44f
+            }
357a44f
+            virtio_scsi_do_tmf(s, req);
357a44f
+
357a44f
+        } else if (req->req.tmf->type == VIRTIO_SCSI_T_AN_QUERY ||
357a44f
+                   req->req.tmf->type == VIRTIO_SCSI_T_AN_SUBSCRIBE) {
357a44f
+            if (out_size < sizeof(VirtIOSCSICtrlANReq) ||
357a44f
+                in_size < sizeof(VirtIOSCSICtrlANResp)) {
357a44f
+                virtio_scsi_bad_req();
357a44f
+            }
357a44f
+            req->resp.an->event_actual = 0;
357a44f
+            req->resp.an->response = VIRTIO_SCSI_S_OK;
357a44f
+        }
357a44f
+        virtio_scsi_complete_req(req);
357a44f
+    }
357a44f
+}
357a44f
+
357a44f
+static void virtio_scsi_command_complete(SCSIRequest *r, uint32_t status,
357a44f
+                                         int32_t resid)
357a44f
+{
357a44f
+    VirtIOSCSIReq *req = r->hba_private;
357a44f
+
357a44f
+    req->resp.cmd->response = VIRTIO_SCSI_S_OK;
357a44f
+    req->resp.cmd->status = status;
357a44f
+    if (req->resp.cmd->status == GOOD) {
357a44f
+        req->resp.cmd->resid = resid;
357a44f
+    } else {
357a44f
+       req->resp.cmd->resid = 0;
357a44f
+       scsi_req_get_sense(r, req->resp.cmd->sense, VIRTIO_SCSI_SENSE_SIZE);
357a44f
+    }
357a44f
+    virtio_scsi_complete_req(req);
357a44f
+}
357a44f
+
357a44f
+static QEMUSGList *virtio_scsi_get_sg_list(SCSIRequest *r)
357a44f
+{
357a44f
+    VirtIOSCSIReq *req = r->hba_private;
357a44f
+
357a44f
+    return &req->qsgl;
357a44f
+}
357a44f
+
357a44f
+static void virtio_scsi_request_cancelled(SCSIRequest *r)
357a44f
+{
357a44f
+    VirtIOSCSIReq *req = r->hba_private;
357a44f
+
357a44f
+    if (!req) {
357a44f
+        return;
357a44f
+    }
357a44f
+    if (req->dev->resetting) {
357a44f
+        req->resp.cmd->response = VIRTIO_SCSI_S_RESET;
357a44f
+    } else {
357a44f
+        req->resp.cmd->response = VIRTIO_SCSI_S_ABORTED;
357a44f
+    }
357a44f
+    virtio_scsi_complete_req(req);
357a44f
+}
357a44f
+
357a44f
+static void virtio_scsi_fail_cmd_req(VirtIOSCSIReq *req)
357a44f
+{
357a44f
+    req->resp.cmd->response = VIRTIO_SCSI_S_FAILURE;
357a44f
+    virtio_scsi_complete_req(req);
357a44f
+}
357a44f
+
357a44f
+static void virtio_scsi_handle_cmd(VirtIODevice *vdev, VirtQueue *vq)
357a44f
+{
357a44f
+    VirtIOSCSI *s = (VirtIOSCSI *)vdev;
357a44f
+    VirtIOSCSIReq *req;
357a44f
+    int n;
357a44f
+
357a44f
+    while ((req = virtio_scsi_pop_req(s, vq))) {
357a44f
+        SCSIDevice *d;
357a44f
+        int out_size, in_size;
357a44f
+        if (req->elem.out_num < 1 || req->elem.in_num < 1) {
357a44f
+            virtio_scsi_bad_req();
357a44f
+        }
357a44f
+
357a44f
+        out_size = req->elem.out_sg[0].iov_len;
357a44f
+        in_size = req->elem.in_sg[0].iov_len;
357a44f
+        if (out_size < sizeof(VirtIOSCSICmdReq) + s->cdb_size ||
357a44f
+            in_size < sizeof(VirtIOSCSICmdResp) + s->sense_size) {
357a44f
+            virtio_scsi_bad_req();
357a44f
+        }
357a44f
+
357a44f
+        if (req->elem.out_num > 1 && req->elem.in_num > 1) {
357a44f
+            virtio_scsi_fail_cmd_req(req);
357a44f
+            continue;
357a44f
+        }
357a44f
+
357a44f
+        d = virtio_scsi_device_find(s, req->req.cmd->lun);
357a44f
+        if (!d) {
357a44f
+            req->resp.cmd->response = VIRTIO_SCSI_S_BAD_TARGET;
357a44f
+            virtio_scsi_complete_req(req);
357a44f
+            continue;
357a44f
+        }
357a44f
+        req->sreq = scsi_req_new(d, req->req.cmd->tag,
357a44f
+                                 virtio_scsi_get_lun(req->req.cmd->lun),
357a44f
+                                 req->req.cmd->cdb, req);
357a44f
+
357a44f
+        if (req->sreq->cmd.mode != SCSI_XFER_NONE) {
357a44f
+            int req_mode =
357a44f
+                (req->elem.in_num > 1 ? SCSI_XFER_FROM_DEV : SCSI_XFER_TO_DEV);
357a44f
+
357a44f
+            if (req->sreq->cmd.mode != req_mode ||
357a44f
+                req->sreq->cmd.xfer > req->qsgl.size) {
357a44f
+                req->resp.cmd->response = VIRTIO_SCSI_S_OVERRUN;
357a44f
+                virtio_scsi_complete_req(req);
357a44f
+                continue;
357a44f
+            }
357a44f
+        }
357a44f
+
357a44f
+        n = scsi_req_enqueue(req->sreq);
357a44f
+        if (n) {
357a44f
+            scsi_req_continue(req->sreq);
357a44f
+        }
357a44f
+    }
357a44f
+}
357a44f
+
357a44f
+static void virtio_scsi_get_config(VirtIODevice *vdev,
357a44f
+                                   uint8_t *config)
357a44f
+{
357a44f
+    VirtIOSCSIConfig *scsiconf = (VirtIOSCSIConfig *)config;
357a44f
+    VirtIOSCSI *s = (VirtIOSCSI *)vdev;
357a44f
+
357a44f
+    stl_raw(&scsiconf->num_queues, s->conf->num_queues);
357a44f
+    stl_raw(&scsiconf->seg_max, 128 - 2);
357a44f
+    stl_raw(&scsiconf->max_sectors, s->conf->max_sectors);
357a44f
+    stl_raw(&scsiconf->cmd_per_lun, s->conf->cmd_per_lun);
357a44f
+    stl_raw(&scsiconf->event_info_size, sizeof(VirtIOSCSIEvent));
357a44f
+    stl_raw(&scsiconf->sense_size, s->sense_size);
357a44f
+    stl_raw(&scsiconf->cdb_size, s->cdb_size);
357a44f
+    stl_raw(&scsiconf->max_channel, VIRTIO_SCSI_MAX_CHANNEL);
357a44f
+    stl_raw(&scsiconf->max_target, VIRTIO_SCSI_MAX_TARGET);
357a44f
+    stl_raw(&scsiconf->max_lun, VIRTIO_SCSI_MAX_LUN);
357a44f
+}
357a44f
+
357a44f
+static void virtio_scsi_set_config(VirtIODevice *vdev,
357a44f
+                                   const uint8_t *config)
357a44f
+{
357a44f
+    VirtIOSCSIConfig *scsiconf = (VirtIOSCSIConfig *)config;
357a44f
+    VirtIOSCSI *s = (VirtIOSCSI *)vdev;
357a44f
+
357a44f
+    if ((uint32_t) ldl_raw(&scsiconf->sense_size) >= 65536 ||
357a44f
+        (uint32_t) ldl_raw(&scsiconf->cdb_size) >= 256) {
357a44f
+        error_report("bad data written to virtio-scsi configuration space");
357a44f
+        exit(1);
357a44f
+    }
357a44f
+
357a44f
+    s->sense_size = ldl_raw(&scsiconf->sense_size);
357a44f
+    s->cdb_size = ldl_raw(&scsiconf->cdb_size);
357a44f
+}
357a44f
+
357a44f
+static uint32_t virtio_scsi_get_features(VirtIODevice *vdev,
357a44f
+                                         uint32_t requested_features)
357a44f
+{
357a44f
+    return requested_features;
357a44f
+}
357a44f
+
357a44f
+static void virtio_scsi_reset(VirtIODevice *vdev)
357a44f
+{
357a44f
+    VirtIOSCSI *s = (VirtIOSCSI *)vdev;
357a44f
+
357a44f
+    s->sense_size = VIRTIO_SCSI_SENSE_SIZE;
357a44f
+    s->cdb_size = VIRTIO_SCSI_CDB_SIZE;
357a44f
+}
357a44f
+
357a44f
+/* The device does not have anything to save beyond the virtio data.
357a44f
+ * Request data is saved with callbacks from SCSI devices.
357a44f
+ */
357a44f
+static void virtio_scsi_save(QEMUFile *f, void *opaque)
357a44f
+{
357a44f
+    VirtIOSCSI *s = opaque;
357a44f
+    virtio_save(&s->vdev, f);
357a44f
+}
357a44f
+
357a44f
+static int virtio_scsi_load(QEMUFile *f, void *opaque, int version_id)
357a44f
+{
357a44f
+    VirtIOSCSI *s = opaque;
357a44f
+    virtio_load(&s->vdev, f);
357a44f
+    return 0;
357a44f
+}
357a44f
+
357a44f
+static struct SCSIBusInfo virtio_scsi_scsi_info = {
357a44f
+    .tcq = true,
357a44f
+    .max_channel = VIRTIO_SCSI_MAX_CHANNEL,
357a44f
+    .max_target = VIRTIO_SCSI_MAX_TARGET,
357a44f
+    .max_lun = VIRTIO_SCSI_MAX_LUN,
357a44f
+
357a44f
+    .complete = virtio_scsi_command_complete,
357a44f
+    .cancel = virtio_scsi_request_cancelled,
357a44f
+    .get_sg_list = virtio_scsi_get_sg_list,
357a44f
+    .save_request = virtio_scsi_save_request,
357a44f
+    .load_request = virtio_scsi_load_request,
357a44f
+};
357a44f
+
357a44f
+VirtIODevice *virtio_scsi_init(DeviceState *dev, VirtIOSCSIConf *proxyconf)
357a44f
+{
357a44f
+    VirtIOSCSI *s;
357a44f
+    static int virtio_scsi_id;
357a44f
+
357a44f
+    s = (VirtIOSCSI *)virtio_common_init("virtio-scsi", VIRTIO_ID_SCSI,
357a44f
+                                         sizeof(VirtIOSCSIConfig),
357a44f
+                                         sizeof(VirtIOSCSI));
357a44f
+
357a44f
+    s->qdev = dev;
357a44f
+    s->conf = proxyconf;
357a44f
+
357a44f
+    /* TODO set up vdev function pointers */
357a44f
+    s->vdev.get_config = virtio_scsi_get_config;
357a44f
+    s->vdev.set_config = virtio_scsi_set_config;
357a44f
+    s->vdev.get_features = virtio_scsi_get_features;
357a44f
+    s->vdev.reset = virtio_scsi_reset;
357a44f
+
357a44f
+    s->ctrl_vq = virtio_add_queue(&s->vdev, VIRTIO_SCSI_VQ_SIZE,
357a44f
+                                   virtio_scsi_handle_ctrl);
357a44f
+    s->event_vq = virtio_add_queue(&s->vdev, VIRTIO_SCSI_VQ_SIZE,
357a44f
+                                   NULL);
357a44f
+    s->cmd_vq = virtio_add_queue(&s->vdev, VIRTIO_SCSI_VQ_SIZE,
357a44f
+                                   virtio_scsi_handle_cmd);
357a44f
+
357a44f
+    scsi_bus_new(&s->bus, dev, &virtio_scsi_scsi_info);
357a44f
+    if (!dev->hotplugged) {
357a44f
+        scsi_bus_legacy_handle_cmdline(&s->bus);
357a44f
+    }
357a44f
+
357a44f
+    register_savevm(dev, "virtio-scsi", virtio_scsi_id++, 1,
357a44f
+                    virtio_scsi_save, virtio_scsi_load, s);
357a44f
+
357a44f
+    return &s->vdev;
357a44f
+}
357a44f
+
357a44f
+void virtio_scsi_exit(VirtIODevice *vdev)
357a44f
+{
357a44f
+    virtio_cleanup(vdev);
357a44f
+}
357a44f
diff -ruNp qemu-kvm-1.0/hw/virtio-scsi.h qemu-kvm-1.0.virtio-scsi/hw/virtio-scsi.h
357a44f
--- qemu-kvm-1.0/hw/virtio-scsi.h	1969-12-31 18:00:00.000000000 -0600
357a44f
+++ qemu-kvm-1.0.virtio-scsi/hw/virtio-scsi.h	2012-02-07 14:44:53.432905379 -0600
357a44f
@@ -0,0 +1,36 @@
357a44f
+/*
357a44f
+ * Virtio SCSI HBA
357a44f
+ *
357a44f
+ * Copyright IBM, Corp. 2010
357a44f
+ *
357a44f
+ * Authors:
357a44f
+ *  Stefan Hajnoczi    <stefanha@linux.vnet.ibm.com>
357a44f
+ *
357a44f
+ * This work is licensed under the terms of the GNU GPL, version 2.  See
357a44f
+ * the COPYING file in the top-level directory.
357a44f
+ *
357a44f
+ */
357a44f
+
357a44f
+#ifndef _QEMU_VIRTIO_SCSI_H
357a44f
+#define _QEMU_VIRTIO_SCSI_H
357a44f
+
357a44f
+#include "virtio.h"
357a44f
+#include "net.h"
357a44f
+#include "pci.h"
357a44f
+
357a44f
+/* The ID for virtio_scsi */
357a44f
+#define VIRTIO_ID_SCSI  8
357a44f
+
357a44f
+struct VirtIOSCSIConf {
357a44f
+    uint32_t num_queues;
357a44f
+    uint32_t max_sectors;
357a44f
+    uint32_t cmd_per_lun;
357a44f
+};
357a44f
+
357a44f
+#define DEFINE_VIRTIO_SCSI_PROPERTIES(_state, _features_field, _conf_field) \
357a44f
+    DEFINE_VIRTIO_COMMON_FEATURES(_state, _features_field), \
357a44f
+    DEFINE_PROP_UINT32("num_queues", _state, _conf_field.num_queues, 1), \
357a44f
+    DEFINE_PROP_UINT32("max_sectors", _state, _conf_field.max_sectors, 0xFFFF), \
357a44f
+    DEFINE_PROP_UINT32("cmd_per_lun", _state, _conf_field.cmd_per_lun, 128)
357a44f
+
357a44f
+#endif /* _QEMU_VIRTIO_SCSI_H */
357a44f
diff -ruNp qemu-kvm-1.0/Makefile.target qemu-kvm-1.0.virtio-scsi/Makefile.target
357a44f
--- qemu-kvm-1.0/Makefile.target	2012-02-07 14:44:04.965124855 -0600
357a44f
+++ qemu-kvm-1.0.virtio-scsi/Makefile.target	2012-02-07 14:44:53.126900450 -0600
357a44f
@@ -205,6 +205,7 @@ obj-y = arch_init.o cpus.o monitor.o mac
357a44f
 obj-$(CONFIG_NO_PCI) += pci-stub.o
357a44f
 obj-$(CONFIG_PCI) += pci.o
357a44f
 obj-$(CONFIG_VIRTIO) += virtio.o virtio-blk.o virtio-balloon.o virtio-net.o virtio-serial-bus.o
357a44f
+obj-$(CONFIG_VIRTIO_SCSI) += virtio-scsi.o
357a44f
 obj-y += vhost_net.o
357a44f
 obj-$(CONFIG_VHOST_NET) += vhost.o
357a44f
 obj-$(CONFIG_REALLY_VIRTFS) += 9pfs/virtio-9p-device.o