#1 Enable ffmpeg input plugin
Closed a year ago by kvolny. Opened a year ago by yselkowitz.
rpms/ yselkowitz/qmmp rawhide  into  rawhide

file modified
+8 -17
@@ -1,6 +1,6 @@ 

  Name:		qmmp

  Version:	2.1.2

- Release:	2%{?dist}

+ Release:	3%{?dist}

  Summary:	Qt-based multimedia player

  

  License:	GPLv2+ and CC-BY-SAv4+
@@ -12,6 +12,7 @@ 

  BuildRequires:	desktop-file-utils

  BuildRequires:	enca-devel

  BuildRequires:	flac-devel

+ BuildRequires:	ffmpeg-free-devel

  BuildRequires:	game-music-emu-devel

  BuildRequires:	jack-audio-connection-kit-devel

  BuildRequires:	libarchive-devel
@@ -52,6 +53,9 @@ 

  Recommends:	wavpack

  Recommends:	flac

  

+ # latest version at time of ffmpeg input plugin move

+ Obsoletes:	qmmp-plugins-freeworld < 2.1.2-2

+ 

  # Do not check .so files in an application-specific library directory

  %global __provides_exclude_from ^%{_libdir}/%{name}/.*\\.so$

  
@@ -100,7 +104,6 @@ 

  %build

  %cmake \

  	-D USE_AAC:BOOL=FALSE \

- 	-D USE_FFMPEG:BOOL=FALSE \

  	-D USE_MMS:BOOL=FALSE \

  	-D USE_MPLAYER:BOOL=FALSE \

  	-D USE_LIBRCD:BOOL=TRUE \
@@ -112,21 +115,6 @@ 

  

  %install

  %cmake_install

- # filter out unsupported formats from MimeType

- sed -i -e "s#audio/x-ffmpeg-shorten;##" \

-        -e "s#audio/x-ms-wma;##" \

-        -e "s#audio/aac;##" \

-        -e "s#audio/x-aac;##" \

-        -e "s#audio/m4a;##" \

-        -e "s#audio/x-m4a;##" \

-     %{buildroot}/%{_datadir}/applications/%{name}.desktop

- sed -i -e "s#audio/x-ffmpeg-shorten;##" \

-        -e "s#audio/x-ms-wma;##" \

-        -e "s#audio/aac;##" \

-        -e "s#audio/x-aac;##" \

-        -e "s#audio/m4a;##" \

-        -e "s#audio/x-m4a;##" \

-     %{buildroot}/%{_datadir}/applications/%{name}-enqueue.desktop

  desktop-file-validate %{buildroot}/%{_datadir}/applications/%{name}.desktop

  desktop-file-validate %{buildroot}/%{_datadir}/applications/%{name}-dir.desktop

  desktop-file-validate %{buildroot}/%{_datadir}/applications/%{name}-enqueue.desktop
@@ -155,6 +143,9 @@ 

  %{_libdir}/libqmmp*.so

  

  %changelog

+ * Tue Feb 07 2023 Yaakov Selkowitz <yselkowi@redhat.com> - 2.1.2-3

+ - Enable ffmpeg input plugin

+ 

  * Fri Jan 20 2023 Fedora Release Engineering <releng@fedoraproject.org> - 2.1.2-2

  - Rebuilt for https://fedoraproject.org/wiki/Fedora_38_Mass_Rebuild

  

Now that ffmpeg-free is available in Fedora, the ffmpeg input plugin can be enabled here.

Please also merge into f38, and let me know if you're interested in a similar change for f37.

Thanks for the heads-up and for the patch, however I haven't used it as aac i handled by different plugin.

The F38 update now awaits freeze lift, but I don't think this kind of change is something that has to be pushed also into already released versions ...

Pull-Request has been closed by kvolny

a year ago

FWIW ffmpeg-free does have some support for AAC via fdk-aac-free. It's not as complete as a full fdk-aac (in ffmpeg) or faad2 (in qmmp) would be, but it's something.

Metadata