PR#5: Fixes the "machine-readable provides" bug - rpms/qpid-proton

rpms / qpid-proton

#5 Fixes the "machine-readable provides" bug

Merged 2 months ago by hiwkby. Opened 4 months ago by hiwkby.

rpms/ hiwkby/qpid-proton rawhide into rawhide

Fixes the "machine-readable provides" bug

Hirotaka Wakabayashi • 2 months ago

c68363a

Adds "Provides" tag manually for compatibility

Hirotaka Wakabayashi • 4 months ago

6e8aaff

qpid-proton.spec

file modified

+1 -1

		`@@ -181,7 +181,7 @@`
		`%{python3_sitearch}/*.so`
		`%{python3_sitearch}/.py`
		`%{python3_sitearch}/proton`
		`- %{python3_sitearch}/python_qpid_proton-%{version}.dist-info/*`
		`+ %{python3_sitearch}/python_qpid_proton-%{version}.dist-info`


		`%package -n python-qpid-proton-docs`

hiwkby commented 4 months ago

Hello, This PR fixes the dependency problem of the pachage that requires python3-qpid-proton. Here is an example of python3-pyngus[1] installation error in Fedora39.

$ sudo dnf install python3-pyngus

...(snip)...

Error: 
 Problem: conflicting requests
  - nothing provides python3.12dist(python-qpid-proton) needed by python3-pyngus-2.3.0-14.fc39.noarch from @commandline

python3-pyngus was retired half a year ago as a FTBFS/FTI bugs[2]. I have confirmed that the patch could solve the problem in my environment, but I don't know this patch is a right way to fix the dependency problem above.

Thanks in advance,
Hirotaka

[1] https://src.fedoraproject.org/rpms/python-pyngus
[2] https://bugzilla.redhat.com/show_bug.cgi?id=2184027

churchyard commented 3 months ago

For the record, this should not be done. See https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#Machine-readable-provides

This is generated automatically from the dist-info metadata. The provide SHOULD NOT be added manually: if the generator fails to add it, the metadata MUST be fixed.

kpvdr commented 3 months ago

I am one of the maintainers for this package taking over from Irina Boverman. I'll take a closer look at this and respond.

hiwkby commented 2 months ago

Hello @kpvdr, I think we should decide how python3-qpid-proton package should provide python3.Xdist(python-qpid-proton) that was provided until python3-qpid-proton-37.0 but is probably dropped since python3-qpid-proton-38.0 by this commit[1].

1: https://src.fedoraproject.org/fork/hiwkby/rpms/qpid-proton/c/2d2222634b62a45033e675a772dd4d813119306c?branch=rawhide

1 new commit added

Fixes the "machine-readable provides" bug

2 months ago

hiwkby commented 2 months ago

Hi @churchyard, Thanks for the comment!

I removed the manual provide tag and fixed the spec file to automatically generate the python3dist and python3.Xdist provide info by using the dist-info metadata. Please check the log below.

Before fixing the spec file,

$ rpmbuild -bb --rpmfcdebug qpid-proton.spec
...(snip)...
 74 /builddir/build/BUILDROOT/qpid-proton-0.38.0-4.fc41.x86_64/usr/lib64/python3.12/site-packages/proton/utils.py       Python script, ASCII text executable [python,pythonname]
        R python(abi) = 3.12
 75 /builddir/build/BUILDROOT/qpid-proton-0.38.0-4.fc41.x86_64/usr/lib64/python3.12/site-packages/python_qpid_proton-0.38.0.dist-info/INSTALLER ASCII text [pythonname]
 76 /builddir/build/BUILDROOT/qpid-proton-0.38.0-4.fc41.x86_64/usr/lib64/python3.12/site-packages/python_qpid_proton-0.38.0.dist-info/METADATA  ASCII text [pythonname]

After changing the spec file, we can find:

$ rpmbuild -bb --rpmfcdebug qpid-proton.spec
...(snip)...
 75 /builddir/build/BUILDROOT/qpid-proton-0.38.0-4.fc41.x86_64/usr/lib64/python3.12/site-packages/python_qpid_proton-0.38.0.dist-info   directory [pythondist,pythonname]   <--- This line added.
        P python3.12dist(python-qpid-proton) = 0.38
        P python3dist(python-qpid-proton) = 0.38
        R python(abi) = 3.12
 76 /builddir/build/BUILDROOT/qpid-proton-0.38.0-4.fc41.x86_64/usr/lib64/python3.12/site-packages/python_qpid_proton-0.38.0.dist-info/INSTALLER ASCII text [pythonname]
 77 /builddir/build/BUILDROOT/qpid-proton-0.38.0-4.fc41.x86_64/usr/lib64/python3.12/site-packages/python_qpid_proton-0.38.0.dist-info/METADATA  ASCII text [pythonname]

Thanks in advance,
Hirotaka

churchyard commented 2 months ago

Yes, this is the correct fix. Thanks!

Metadata Update from @hiwkby:
- Request assigned

2 months ago

Pull-Request has been merged by hiwkby

2 months ago