6aec805
diff -up qt-everywhere-opensource-src-4.6.2/src/3rdparty/webkit/WebCore/css/CSSGrammar.y.cve-2010-0051-lax-css-parsing-cross-domain-theft qt-everywhere-opensource-src-4.6.2/src/3rdparty/webkit/WebCore/css/CSSGrammar.y
6aec805
--- qt-everywhere-opensource-src-4.6.2/src/3rdparty/webkit/WebCore/css/CSSGrammar.y.cve-2010-0051-lax-css-parsing-cross-domain-theft	2010-02-11 16:55:20.000000000 +0100
6aec805
+++ qt-everywhere-opensource-src-4.6.2/src/3rdparty/webkit/WebCore/css/CSSGrammar.y	2010-02-25 17:07:29.114742034 +0100
6aec805
@@ -416,7 +416,9 @@ valid_rule:
6aec805
   ;
6aec805
 
6aec805
 rule:
6aec805
-    valid_rule
6aec805
+    valid_rule {
6aec805
+        static_cast<CSSParser*>(parser)->m_hadSyntacticallyValidCSSRule = true;
6aec805
+    }
6aec805
   | invalid_rule
6aec805
   | invalid_at
6aec805
   | invalid_import
6aec805
@@ -1517,8 +1519,12 @@ invalid_rule:
6aec805
     ;
6aec805
 
6aec805
 invalid_block:
6aec805
-    '{' error invalid_block_list error closing_brace
6aec805
-  | '{' error closing_brace
6aec805
+    '{' error invalid_block_list error closing_brace {
6aec805
+        static_cast<CSSParser*>(parser)->invalidBlockHit();
6aec805
+    }
6aec805
+  | '{' error closing_brace {
6aec805
+        static_cast<CSSParser*>(parser)->invalidBlockHit();
6aec805
+    }
6aec805
     ;
6aec805
 
6aec805
 invalid_block_list:
6aec805
diff -up qt-everywhere-opensource-src-4.6.2/src/3rdparty/webkit/WebCore/css/CSSImportRule.cpp.cve-2010-0051-lax-css-parsing-cross-domain-theft qt-everywhere-opensource-src-4.6.2/src/3rdparty/webkit/WebCore/css/CSSImportRule.cpp
6aec805
--- qt-everywhere-opensource-src-4.6.2/src/3rdparty/webkit/WebCore/css/CSSImportRule.cpp.cve-2010-0051-lax-css-parsing-cross-domain-theft	2010-02-11 16:55:20.000000000 +0100
6aec805
+++ qt-everywhere-opensource-src-4.6.2/src/3rdparty/webkit/WebCore/css/CSSImportRule.cpp	2010-02-25 17:13:34.292803953 +0100
6aec805
@@ -25,6 +25,7 @@
6aec805
 #include "CachedCSSStyleSheet.h"
6aec805
 #include "DocLoader.h"
6aec805
 #include "Document.h"
6aec805
+#include "SecurityOrigin.h"
6aec805
 #include "MediaList.h"
6aec805
 #include "Settings.h"
6aec805
 #include <wtf/StdLibExtras.h>
6aec805
@@ -60,11 +61,21 @@ void CSSImportRule::setCSSStyleSheet(con
6aec805
         m_styleSheet->setParent(0);
6aec805
     m_styleSheet = CSSStyleSheet::create(this, url, charset);
6aec805
 
6aec805
+    bool crossOriginCSS = false;
6aec805
+    bool validMIMEType = false;
6aec805
     CSSStyleSheet* parent = parentStyleSheet();
6aec805
     bool strict = !parent || parent->useStrictParsing();
6aec805
-    String sheetText = sheet->sheetText(strict);
6aec805
+    bool enforceMIMEType = strict;
6aec805
+
6aec805
+    String sheetText = sheet->sheetText(enforceMIMEType, &validMIMEType);
6aec805
     m_styleSheet->parseString(sheetText, strict);
6aec805
 
6aec805
+    if (!parent || !parent->doc() || !parent->doc()->securityOrigin()->canRequest(KURL(ParsedURLString, url)))
6aec805
+        crossOriginCSS = true;
6aec805
+
6aec805
+    if (crossOriginCSS && !validMIMEType && !m_styleSheet->hasSyntacticallyValidCSSHeader())
6aec805
+        m_styleSheet = CSSStyleSheet::create(this, url, charset);
6aec805
+
6aec805
     if (strict && parent && parent->doc() && parent->doc()->settings() && parent->doc()->settings()->needsSiteSpecificQuirks()) {
6aec805
         // Work around <https://bugs.webkit.org/show_bug.cgi?id=28350>.
6aec805
         DEFINE_STATIC_LOCAL(const String, slashKHTMLFixesDotCss, ("/KHTMLFixes.css"));
6aec805
diff -up qt-everywhere-opensource-src-4.6.2/src/3rdparty/webkit/WebCore/css/CSSParser.cpp.cve-2010-0051-lax-css-parsing-cross-domain-theft qt-everywhere-opensource-src-4.6.2/src/3rdparty/webkit/WebCore/css/CSSParser.cpp
6aec805
--- qt-everywhere-opensource-src-4.6.2/src/3rdparty/webkit/WebCore/css/CSSParser.cpp.cve-2010-0051-lax-css-parsing-cross-domain-theft	2010-02-25 17:07:29.101741771 +0100
6aec805
+++ qt-everywhere-opensource-src-4.6.2/src/3rdparty/webkit/WebCore/css/CSSParser.cpp	2010-02-25 17:07:29.117741744 +0100
6aec805
@@ -139,6 +139,7 @@ CSSParser::CSSParser(bool strictParsing)
6aec805
     , m_currentShorthand(0)
6aec805
     , m_implicitShorthand(false)
6aec805
     , m_hasFontFaceOnlyValues(false)
6aec805
+    , m_hadSyntacticallyValidCSSRule(false)
6aec805
     , m_defaultNamespace(starAtom)
6aec805
     , m_data(0)
6aec805
     , yy_start(1)
6aec805
@@ -5175,6 +5176,12 @@ WebKitCSSKeyframeRule* CSSParser::create
6aec805
     return keyframePtr;
6aec805
 }
6aec805
 
6aec805
+void CSSParser::invalidBlockHit()
6aec805
+{
6aec805
+    if (m_styleSheet && !m_hadSyntacticallyValidCSSRule)
6aec805
+        m_styleSheet->setHasSyntacticallyValidCSSHeader(false);
6aec805
+}
6aec805
+
6aec805
 static int cssPropertyID(const UChar* propertyName, unsigned length)
6aec805
 {
6aec805
     if (!length)
6aec805
diff -up qt-everywhere-opensource-src-4.6.2/src/3rdparty/webkit/WebCore/css/CSSParser.h.cve-2010-0051-lax-css-parsing-cross-domain-theft qt-everywhere-opensource-src-4.6.2/src/3rdparty/webkit/WebCore/css/CSSParser.h
6aec805
--- qt-everywhere-opensource-src-4.6.2/src/3rdparty/webkit/WebCore/css/CSSParser.h.cve-2010-0051-lax-css-parsing-cross-domain-theft	2010-02-11 16:55:20.000000000 +0100
6aec805
+++ qt-everywhere-opensource-src-4.6.2/src/3rdparty/webkit/WebCore/css/CSSParser.h	2010-02-25 17:07:29.117741744 +0100
6aec805
@@ -191,6 +191,7 @@ namespace WebCore {
6aec805
         bool addVariableDeclarationBlock(const CSSParserString&);
6aec805
         bool checkForVariables(CSSParserValueList*);
6aec805
         void addUnresolvedProperty(int propId, bool important);
6aec805
+        void invalidBlockHit();
6aec805
         
6aec805
         Vector<CSSSelector*>* reusableSelectorVector() { return &m_reusableSelectorVector; }
6aec805
         
6aec805
@@ -212,6 +213,7 @@ namespace WebCore {
6aec805
         bool m_implicitShorthand;
6aec805
 
6aec805
         bool m_hasFontFaceOnlyValues;
6aec805
+        bool m_hadSyntacticallyValidCSSRule;
6aec805
 
6aec805
         Vector<String> m_variableNames;
6aec805
         Vector<RefPtr<CSSValue> > m_variableValues;
6aec805
diff -up qt-everywhere-opensource-src-4.6.2/src/3rdparty/webkit/WebCore/css/CSSStyleSheet.cpp.cve-2010-0051-lax-css-parsing-cross-domain-theft qt-everywhere-opensource-src-4.6.2/src/3rdparty/webkit/WebCore/css/CSSStyleSheet.cpp
6aec805
--- qt-everywhere-opensource-src-4.6.2/src/3rdparty/webkit/WebCore/css/CSSStyleSheet.cpp.cve-2010-0051-lax-css-parsing-cross-domain-theft	2010-02-11 16:55:19.000000000 +0100
6aec805
+++ qt-everywhere-opensource-src-4.6.2/src/3rdparty/webkit/WebCore/css/CSSStyleSheet.cpp	2010-02-25 17:07:29.118741824 +0100
6aec805
@@ -41,6 +41,7 @@ CSSStyleSheet::CSSStyleSheet(CSSStyleShe
6aec805
     , m_loadCompleted(false)
6aec805
     , m_strictParsing(!parentSheet || parentSheet->useStrictParsing())
6aec805
     , m_isUserStyleSheet(parentSheet ? parentSheet->isUserStyleSheet() : false)
6aec805
+    , m_hasSyntacticallyValidCSSHeader(true)
6aec805
 {
6aec805
 }
6aec805
 
6aec805
@@ -52,6 +53,7 @@ CSSStyleSheet::CSSStyleSheet(Node* paren
6aec805
     , m_loadCompleted(false)
6aec805
     , m_strictParsing(false)
6aec805
     , m_isUserStyleSheet(false)
6aec805
+    , m_hasSyntacticallyValidCSSHeader(true)
6aec805
 {
6aec805
 }
6aec805
 
6aec805
@@ -61,6 +63,7 @@ CSSStyleSheet::CSSStyleSheet(CSSRule* ow
6aec805
     , m_charset(charset)
6aec805
     , m_loadCompleted(false)
6aec805
     , m_strictParsing(!ownerRule || ownerRule->useStrictParsing())
6aec805
+    , m_hasSyntacticallyValidCSSHeader(true)
6aec805
 {
6aec805
     CSSStyleSheet* parentSheet = ownerRule ? ownerRule->parentStyleSheet() : 0;
6aec805
     m_doc = parentSheet ? parentSheet->doc() : 0;
6aec805
diff -up qt-everywhere-opensource-src-4.6.2/src/3rdparty/webkit/WebCore/css/CSSStyleSheet.h.cve-2010-0051-lax-css-parsing-cross-domain-theft qt-everywhere-opensource-src-4.6.2/src/3rdparty/webkit/WebCore/css/CSSStyleSheet.h
6aec805
--- qt-everywhere-opensource-src-4.6.2/src/3rdparty/webkit/WebCore/css/CSSStyleSheet.h.cve-2010-0051-lax-css-parsing-cross-domain-theft	2010-02-11 16:55:20.000000000 +0100
6aec805
+++ qt-everywhere-opensource-src-4.6.2/src/3rdparty/webkit/WebCore/css/CSSStyleSheet.h	2010-02-25 17:07:29.118741824 +0100
6aec805
@@ -95,6 +95,8 @@ public:
6aec805
 
6aec805
     void setIsUserStyleSheet(bool b) { m_isUserStyleSheet = b; }
6aec805
     bool isUserStyleSheet() const { return m_isUserStyleSheet; }
6aec805
+    void setHasSyntacticallyValidCSSHeader(bool b) { m_hasSyntacticallyValidCSSHeader = b; }
6aec805
+    bool hasSyntacticallyValidCSSHeader() const { return m_hasSyntacticallyValidCSSHeader; }
6aec805
 
6aec805
 private:
6aec805
     CSSStyleSheet(Node* ownerNode, const String& href, const String& charset);
6aec805
@@ -110,6 +112,7 @@ private:
6aec805
     bool m_loadCompleted : 1;
6aec805
     bool m_strictParsing : 1;
6aec805
     bool m_isUserStyleSheet : 1;
6aec805
+    bool m_hasSyntacticallyValidCSSHeader : 1;
6aec805
 };
6aec805
 
6aec805
 } // namespace
6aec805
diff -up qt-everywhere-opensource-src-4.6.2/src/3rdparty/webkit/WebCore/dom/ProcessingInstruction.cpp.cve-2010-0051-lax-css-parsing-cross-domain-theft qt-everywhere-opensource-src-4.6.2/src/3rdparty/webkit/WebCore/dom/ProcessingInstruction.cpp
6aec805
--- qt-everywhere-opensource-src-4.6.2/src/3rdparty/webkit/WebCore/dom/ProcessingInstruction.cpp.cve-2010-0051-lax-css-parsing-cross-domain-theft	2010-02-11 16:55:19.000000000 +0100
6aec805
+++ qt-everywhere-opensource-src-4.6.2/src/3rdparty/webkit/WebCore/dom/ProcessingInstruction.cpp	2010-02-25 17:07:29.118741824 +0100
6aec805
@@ -203,7 +203,10 @@ void ProcessingInstruction::setCSSStyleS
6aec805
 #endif
6aec805
     RefPtr<CSSStyleSheet> newSheet = CSSStyleSheet::create(this, url, charset);
6aec805
     m_sheet = newSheet;
6aec805
-    parseStyleSheet(sheet->sheetText());
6aec805
+    // We don't need the cross-origin security check here because we are
6aec805
+    // getting the sheet text in "strict" mode. This enforces a valid CSS MIME
6aec805
+    // type.
6aec805
+    parseStyleSheet(sheet->sheetText(true));
6aec805
     newSheet->setTitle(m_title);
6aec805
     newSheet->setMedia(MediaList::create(newSheet.get(), m_media));
6aec805
     newSheet->setDisabled(m_alternate);
6aec805
diff -up qt-everywhere-opensource-src-4.6.2/src/3rdparty/webkit/WebCore/html/HTMLLinkElement.cpp.cve-2010-0051-lax-css-parsing-cross-domain-theft qt-everywhere-opensource-src-4.6.2/src/3rdparty/webkit/WebCore/html/HTMLLinkElement.cpp
6aec805
--- qt-everywhere-opensource-src-4.6.2/src/3rdparty/webkit/WebCore/html/HTMLLinkElement.cpp.cve-2010-0051-lax-css-parsing-cross-domain-theft	2010-02-11 16:55:17.000000000 +0100
6aec805
+++ qt-everywhere-opensource-src-4.6.2/src/3rdparty/webkit/WebCore/html/HTMLLinkElement.cpp	2010-02-25 17:07:29.119741915 +0100
6aec805
@@ -260,14 +260,27 @@ void HTMLLinkElement::setCSSStyleSheet(c
6aec805
     bool strictParsing = !document()->inCompatMode();
6aec805
     bool enforceMIMEType = strictParsing;
6aec805
 
6aec805
+    bool crossOriginCSS = false;
6aec805
+    bool validMIMEType = false;
6aec805
     // Check to see if we should enforce the MIME type of the CSS resource in strict mode.
6aec805
     // Running in iWeb 2 is one example of where we don't want to - <rdar://problem/6099748>
6aec805
     if (enforceMIMEType && document()->page() && !document()->page()->settings()->enforceCSSMIMETypeInStrictMode())
6aec805
         enforceMIMEType = false;
6aec805
 
6aec805
-    String sheetText = sheet->sheetText(enforceMIMEType);
6aec805
+    String sheetText = sheet->sheetText(enforceMIMEType, &validMIMEType);
6aec805
     m_sheet->parseString(sheetText, strictParsing);
6aec805
 
6aec805
+    // If we're loading a stylesheet cross-origin, and the MIME type is not
6aec805
+    // standard, require the CSS to at least start with a syntactically
6aec805
+    // valid CSS rule.
6aec805
+    // This prevents an attacker playing games by injecting CSS strings into
6aec805
+    // HTML, XML, JSON, etc. etc.
6aec805
+    if (!document()->securityOrigin()->canRequest(KURL(ParsedURLString, url)))
6aec805
+        crossOriginCSS = true;
6aec805
+
6aec805
+    if (crossOriginCSS && !validMIMEType && !m_sheet->hasSyntacticallyValidCSSHeader())
6aec805
+        m_sheet = CSSStyleSheet::create(this, url, charset);
6aec805
+
6aec805
     if (strictParsing && document()->settings() && document()->settings()->needsSiteSpecificQuirks()) {
6aec805
         // Work around <https://bugs.webkit.org/show_bug.cgi?id=28350>.
6aec805
         DEFINE_STATIC_LOCAL(const String, slashKHTMLFixesDotCss, ("/KHTMLFixes.css"));
6aec805
diff -up qt-everywhere-opensource-src-4.6.2/src/3rdparty/webkit/WebCore/loader/CachedCSSStyleSheet.cpp.cve-2010-0051-lax-css-parsing-cross-domain-theft qt-everywhere-opensource-src-4.6.2/src/3rdparty/webkit/WebCore/loader/CachedCSSStyleSheet.cpp
6aec805
--- qt-everywhere-opensource-src-4.6.2/src/3rdparty/webkit/WebCore/loader/CachedCSSStyleSheet.cpp.cve-2010-0051-lax-css-parsing-cross-domain-theft	2010-02-11 16:55:19.000000000 +0100
6aec805
+++ qt-everywhere-opensource-src-4.6.2/src/3rdparty/webkit/WebCore/loader/CachedCSSStyleSheet.cpp	2010-02-25 17:07:29.119741915 +0100
6aec805
@@ -71,11 +71,11 @@ String CachedCSSStyleSheet::encoding() c
6aec805
     return m_decoder->encoding().name();
6aec805
 }
6aec805
     
6aec805
-const String CachedCSSStyleSheet::sheetText(bool enforceMIMEType) const 
6aec805
+const String CachedCSSStyleSheet::sheetText(bool enforceMIMEType, bool* hasValidMIMEType) const 
6aec805
 { 
6aec805
     ASSERT(!isPurgeable());
6aec805
 
6aec805
-    if (!m_data || m_data->isEmpty() || !canUseSheet(enforceMIMEType))
6aec805
+    if (!m_data || m_data->isEmpty() || !canUseSheet(enforceMIMEType, hasValidMIMEType))
6aec805
         return String();
6aec805
     
6aec805
     if (!m_decodedSheetText.isNull())
6aec805
@@ -122,12 +122,12 @@ void CachedCSSStyleSheet::error()
6aec805
     checkNotify();
6aec805
 }
6aec805
 
6aec805
-bool CachedCSSStyleSheet::canUseSheet(bool enforceMIMEType) const
6aec805
+bool CachedCSSStyleSheet::canUseSheet(bool enforceMIMEType, bool* hasValidMIMEType) const
6aec805
 {
6aec805
     if (errorOccurred())
6aec805
         return false;
6aec805
         
6aec805
-    if (!enforceMIMEType)
6aec805
+    if (!enforceMIMEType && !hasValidMIMEType)
6aec805
         return true;
6aec805
 
6aec805
     // This check exactly matches Firefox.  Note that we grab the Content-Type
6aec805
@@ -138,7 +138,12 @@ bool CachedCSSStyleSheet::canUseSheet(bo
6aec805
     // This code defaults to allowing the stylesheet for non-HTTP protocols so
6aec805
     // folks can use standards mode for local HTML documents.
6aec805
     String mimeType = extractMIMETypeFromMediaType(response().httpHeaderField("Content-Type"));
6aec805
-    return mimeType.isEmpty() || equalIgnoringCase(mimeType, "text/css") || equalIgnoringCase(mimeType, "application/x-unknown-content-type");
6aec805
+    bool typeOK = mimeType.isEmpty() || equalIgnoringCase(mimeType, "text/css") || equalIgnoringCase(mimeType, "application/x-unknown-content-type");
6aec805
+    if (hasValidMIMEType)
6aec805
+        *hasValidMIMEType = typeOK;
6aec805
+    if (!enforceMIMEType)
6aec805
+        return true;
6aec805
+    return typeOK;
6aec805
 }
6aec805
  
6aec805
 }
6aec805
diff -up qt-everywhere-opensource-src-4.6.2/src/3rdparty/webkit/WebCore/loader/CachedCSSStyleSheet.h.cve-2010-0051-lax-css-parsing-cross-domain-theft qt-everywhere-opensource-src-4.6.2/src/3rdparty/webkit/WebCore/loader/CachedCSSStyleSheet.h
6aec805
--- qt-everywhere-opensource-src-4.6.2/src/3rdparty/webkit/WebCore/loader/CachedCSSStyleSheet.h.cve-2010-0051-lax-css-parsing-cross-domain-theft	2010-02-11 16:55:19.000000000 +0100
6aec805
+++ qt-everywhere-opensource-src-4.6.2/src/3rdparty/webkit/WebCore/loader/CachedCSSStyleSheet.h	2010-02-25 17:07:29.120741848 +0100
6aec805
@@ -40,7 +40,7 @@ namespace WebCore {
6aec805
         CachedCSSStyleSheet(const String& URL, const String& charset);
6aec805
         virtual ~CachedCSSStyleSheet();
6aec805
 
6aec805
-        const String sheetText(bool enforceMIMEType = true) const;
6aec805
+        const String sheetText(bool enforceMIMEType = true, bool* hasValidMIMEType = 0) const;
6aec805
 
6aec805
         virtual void didAddClient(CachedResourceClient*);
6aec805
         
6aec805
@@ -56,7 +56,7 @@ namespace WebCore {
6aec805
         void checkNotify();
6aec805
     
6aec805
     private:
6aec805
-        bool canUseSheet(bool enforceMIMEType) const;
6aec805
+        bool canUseSheet(bool enforceMIMEType, bool* hasValidMIMEType) const;
6aec805
 
6aec805
     protected:
6aec805
         RefPtr<TextResourceDecoder> m_decoder;