#5 Add riscv64 support
Opened 3 months ago by jasenchao. Modified 21 hours ago
https://github.com/fedora-riscv/qt5.git rawhide  into  rawhide

Add riscv64 support
Jasen Chao • 21 hours ago  
macros.qt5-srpm
file modified
+1 -1
@@ -5,5 +5,5 @@

  # # If you cannot get this package to build on your secondary architecure, please:

  # # * remove your architecture from this list AND

  # # * put #1298011 onto your ExcludeArch tracker.

- %qt5_qtwebengine_arches %{ix86} x86_64 %{arm} aarch64 mips mipsel mips64el

+ %qt5_qtwebengine_arches %{ix86} x86_64 %{arm} aarch64 mips mipsel mips64el riscv64

  

qt5.spec
file modified
+4 -1
@@ -6,7 +6,7 @@

  

  Name: qt5

  Version: 5.15.13

- Release: 1%{?dist}

+ Release: 2%{?dist}

  Summary: Qt5 meta package

  License: GPL-3.0-only

  URL: https://getfedora.org/
@@ -141,6 +141,9 @@

  

  

  %changelog

+ * Mon May 06 2024 Liu Yang <Yang.Liu.sn@gmail.com> - 5.15.13-2

+ - Add riscv64 to macro %qt5_qtwebengine_arches.

+ 

  * Mon Mar 11 2024 Jan Grulich <jgrulich@redhat.com> - 5.15.13-1

  - 5.15.13

  

no initial comment

So this package would build successfully anyways. The one that is important is qt5-qtwebengine, which builds in OpenKoji: https://openkoji.iscas.ac.cn/koji/packageinfo?packageID=15911

I would prefer qt5-qtwebengine PR to land 1st.

Otherwise LGTM.

I don't think we want to carry giant out-of-tree patches (aka chromium port) for qtwebegine ... FWIW ppc64le enabled webengine lives in my copr repo.

On Fedora/RISCV Koji I have it disabled. I quickly looked into the patches, and it seems majority of it is v8 support for riscv64.

Is anyone working on qtwebengine upstream to have these changes?

v8 is likely a separate project, but at the end all needs to go thru chromium, which is bundled in qtwebengine. And chromium is controlled by Google ...

Can we merge this change or does anything else need to be done here?

IMO this PR should be closed as there is no qtwebengine (yet).

rebased onto cdcfde6

21 hours ago

PR to qt5-qtwebengine has been merged, please consider this PR, thanks.

https://src.fedoraproject.org/rpms/qt5-qtwebengine/pull-request/15

Metadata