From 7f17e02d34e8157009d2603bfcea3bc619709eee Mon Sep 17 00:00:00 2001 From: jkar8572 Date: Wed, 5 May 2010 15:17:09 +0000 Subject: [PATCH 1/2] GFS2 implements the XFS interface for setting and reporting the quota information, and only allows state changes via remount. (Christoph Hellwig) Petr Pisar: Changelog lines removed. --- mntopt.h | 1 + quotacheck.c | 4 +++- quotaio.c | 3 ++- quotaon.c | 8 ++++++-- quotasys.c | 12 +++++++++--- diff --git a/mntopt.h b/mntopt.h index 90673fc..5117033 100644 --- a/mntopt.h +++ b/mntopt.h @@ -18,6 +18,7 @@ #define MNTTYPE_NFS4 "nfs4" /* NFSv4 filesystem */ #define MNTTYPE_MPFS "mpfs" /* EMC Celerra MPFS filesystem */ #define MNTTYPE_OCFS2 "ocfs2" /* Oracle Cluster filesystem */ +#define MNTTYPE_GFS2 "gfs2" /* Red Hat Global filesystem 2 */ /* mount options */ #define MNTOPT_NOQUOTA "noquota" /* don't enforce quota */ diff --git a/quotacheck.c b/quotacheck.c index 41901f1..0e9bac9 100644 --- a/quotacheck.c +++ b/quotacheck.c @@ -1049,7 +1049,9 @@ static void check_all(void) while ((mnt = get_next_mount())) { if (flags & FL_ALL && flags & FL_NOROOT && !strcmp(mnt->mnt_dir, "/")) continue; - if (!strcmp(mnt->mnt_type, MNTTYPE_XFS) || nfs_fstype(mnt->mnt_type) || + if (!strcmp(mnt->mnt_type, MNTTYPE_XFS) || + !strcmp(mnt->mnt_type, MNTTYPE_GFS2) || + nfs_fstype(mnt->mnt_type) || meta_qf_fstype(mnt->mnt_type)) { debug(FL_DEBUG | FL_VERBOSE, _("Skipping %s [%s]\n"), mnt->mnt_fsname, mnt->mnt_dir); continue; diff --git a/quotaio.c b/quotaio.c index e857328..533b631 100644 --- a/quotaio.c +++ b/quotaio.c @@ -78,7 +78,8 @@ struct quota_handle *init_io(struct mntent *mnt, int type, int fmt, int flags) goto out_handle; } - if (!strcmp(mnt->mnt_type, MNTTYPE_XFS)) { /* XFS filesystem? */ + if (!strcmp(mnt->mnt_type, MNTTYPE_XFS) || /* XFS filesystem? */ + !strcmp(mnt->mnt_type, MNTTYPE_GFS2)) { /* XFS filesystem? */ if (fmt != -1 && fmt != QF_XFS) { /* User wanted some other format? */ errstr(_("Only XFS quota format is allowed on XFS filesystem.\n")); goto out_handle; diff --git a/quotaon.c b/quotaon.c index 813c021..1d1187b 100644 --- a/quotaon.c +++ b/quotaon.c @@ -273,7 +273,10 @@ static int newstate(struct mntent *mnt, int type, char *extra) if (flags & FL_ALL) sflags |= STATEFLAG_ALL; - if (!strcmp(mnt->mnt_type, MNTTYPE_XFS)) { /* XFS filesystem has special handling... */ + if (!strcmp(mnt->mnt_type, MNTTYPE_GFS2)) { + errstr(_("Cannot change state of GFS2 quota.\n")); + return 1; + } else if (!strcmp(mnt->mnt_type, MNTTYPE_XFS)) { /* XFS filesystem has special handling... */ if (!kern_qfmt_supp(QF_XFS)) { errstr(_("Cannot change state of XFS quota. It's not compiled in kernel.\n")); return 1; @@ -329,7 +332,8 @@ static int print_state(struct mntent *mnt, int type) { int on = 0; - if (!strcmp(mnt->mnt_type, MNTTYPE_XFS)) { + if (!strcmp(mnt->mnt_type, MNTTYPE_XFS) || + !strcmp(mnt->mnt_type, MNTTYPE_GFS2)) { if (kern_qfmt_supp(QF_XFS)) on = kern_quota_on(mnt->mnt_fsname, type, QF_XFS) != -1; } diff --git a/quotasys.c b/quotasys.c index cce5787..0cc008c 100644 --- a/quotasys.c +++ b/quotasys.c @@ -91,7 +91,8 @@ static int correct_fstype(char *type) !strcmp(type, MNTTYPE_NFS) || !strcmp(type, MNTTYPE_NFS4) || !strcmp(type, MNTTYPE_OCFS2) || - !strcmp(type, MNTTYPE_MPFS)) { + !strcmp(type, MNTTYPE_MPFS) || + !strcmp(type, MNTTYPE_GFS2)) { free(mtype); return 1; } @@ -495,6 +496,8 @@ int hasquota(struct mntent *mnt, int type, int flags) if (!correct_fstype(mnt->mnt_type) || hasmntopt(mnt, MNTOPT_NOQUOTA)) return 0; + if (!strcmp(mnt->mnt_type, MNTTYPE_GFS2)) + return 1; if (!strcmp(mnt->mnt_type, MNTTYPE_XFS)) return hasxfsquota(mnt, type, flags); if (nfs_fstype(mnt->mnt_type)) /* NFS always has quota or better there is no good way how to detect it */ @@ -652,11 +655,14 @@ add_entry: goto add_entry; break; case QF_XFS: - if (!strcmp(mnt->mnt_type, MNTTYPE_XFS)) + if (!strcmp(mnt->mnt_type, MNTTYPE_XFS) || + !strcmp(mnt->mnt_type, MNTTYPE_GFS2)) goto add_entry; break; default: - if (strcmp(mnt->mnt_type, MNTTYPE_XFS) && !nfs_fstype(mnt->mnt_type)) + if (strcmp(mnt->mnt_type, MNTTYPE_XFS) && + strcmp(mnt->mnt_type, MNTTYPE_GFS2) && + !nfs_fstype(mnt->mnt_type)) goto add_entry; break; } -- 1.7.3.2 From f3553cfee6701f98e27a30318f8b759bcbbca370 Mon Sep 17 00:00:00 2001 From: jkar8572 Date: Fri, 7 May 2010 15:45:52 +0000 Subject: [PATCH 2/2] Previous GFS2 patch was missing a hunk to properly detect whether a GFS2 filesystem has quotas enabled. (Christoph Hellwig) --- quotasys.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/quotasys.c b/quotasys.c index 0cc008c..307a359 100644 --- a/quotasys.c +++ b/quotasys.c @@ -496,9 +496,8 @@ int hasquota(struct mntent *mnt, int type, int flags) if (!correct_fstype(mnt->mnt_type) || hasmntopt(mnt, MNTOPT_NOQUOTA)) return 0; - if (!strcmp(mnt->mnt_type, MNTTYPE_GFS2)) - return 1; - if (!strcmp(mnt->mnt_type, MNTTYPE_XFS)) + if (!strcmp(mnt->mnt_type, MNTTYPE_GFS2) || + !strcmp(mnt->mnt_type, MNTTYPE_XFS)) return hasxfsquota(mnt, type, flags); if (nfs_fstype(mnt->mnt_type)) /* NFS always has quota or better there is no good way how to detect it */ return 1; -- 1.7.3.2