#1 FTBFS fix
Merged 6 years ago by tdawson. Opened 6 years ago by merlinm.
Unknown source rollback_to_v3_6_5  into  master

file modified
+8 -3
@@ -7,8 +7,8 @@

  #global failjunit yes

  

  Name:          rabbitmq-java-client

- Version:       3.6.6

- Release:       3%{?dist}

+ Version:       3.6.5

+ Release:       2%{?dist}

  Summary:       Java Advanced Message Queue Protocol client library

  License:       ASL 2.0 and GPLv2+ and MPLv1.1

  URL:           http://www.rabbitmq.com/java-client.html
@@ -25,7 +25,7 @@

  BuildRequires: %{_bindir}/pdflatex

  %endif

  

- %if 0%{?fedora}

+ %if 0%{?fedora} || 0%{?rhel} > 7

  # for tests execution

  BuildRequires:  rabbitmq-server

  BuildRequires:  hostname
@@ -130,6 +130,11 @@

  

  

  %changelog

+ * Mon Jan 22 2018 Merlin Mathesius <mmathesi@redhat.com> - 3.6.5-2

+ - v3.6.6 has never built successfully since the spec file was updated

+   to use it. v3.6.6 also changed the way the package would need to build,

+   so fixing FTBFS by rolling back to v3.6.5. (BZ#1537230)

+ 

  * Thu Jul 27 2017 Fedora Release Engineering <releng@fedoraproject.org> - 3.6.6-3

  - Rebuilt for https://fedoraproject.org/wiki/Fedora_27_Mass_Rebuild

  

rabbitmq-java-client currently fails to build from source in F26, F27, and Rawhide. See Bugzilla #1537230.

The initial FTBFS problem is that the v3.6.6 source code for this package was never uploaded to the dist-git lookaside cache. I discovered the upstream source archive download location changed to https://github.com/rabbitmq/rabbitmq-java-client starting with v3.6.6. An attempt to fix the FTBFS source relocation issue can be found here.

However, v3.6.6 also changed the way the source code needs to build, and would requiring significant changes to the spec file to make it work.

The spec referencing v3.6.6 should have never been committed to dist-git.

Ideally, the spec should be updated to build correctly with newer versions of the upstream source. However, as a simple workaround, this PR fixes the FTBFS issue by rolling back to v3.6.5.

A successful rawhide scratch build of this update can be found at https://koji.fedoraproject.org/koji/taskinfo?taskID=24375282

This looks good to me, but I'd like to wait a week to see if the maintainer finds and uploads the source for 3.6.6.
If they don't, I'll merge this just so we can get a F28 build.

Just for clarity, the v3.6.6 source can easily be found at https://github.com/rabbitmq/rabbitmq-java-client/archive/rabbitmq_v3_6_6.tar.gz. But this spec would need to be reworked to get it to build successfully...

It's been a week. I'm going to merge this so it will build. If the package needs to be updated to 3.6.6 for some reason, it can still happen later.

Pull-Request has been merged by tdawson

6 years ago
Metadata