rpms / redhat-rpm-config

Clone
Source Code
GIT

#183 [F35] Backport the %bcond macro from RPM 4.18+
Closed 2 years ago by churchyard. Opened 2 years ago by churchyard.
rpms/ churchyard/redhat-rpm-config f35-bcond  into  f35

file modified
+7 
@@ -393,3 +393,10 @@ 
 

  %global __find_provides /bin/sh -c "%{?__filter_prov_cmd} %{__deploop P} %{?__filter_from_prov}" \
 

  %global __find_requires /bin/sh -c "%{?__filter_req_cmd}  %{__deploop R} %{?__filter_from_req}" \
 

  }
 

+ 

+ # RPM 4.18+ %%bcond macro backport
 

+ # From https://github.com/rpm-software-management/rpm/pull/1918
 

+ %bcond() %[ (%2)\
 

+     ? "%{expand:%%{!?_without_%{1}:%%global with_%{1} 1}}"\
 

+     : "%{expand:%%{?_with_%{1}:%%global with_%{1} 1}}"\
 

+ ]

file modified
+4 -1 
@@ -6,7 +6,7 @@ 
 

  

  Summary: Red Hat specific rpm configuration files
 

  Name: redhat-rpm-config
 

- Version: 199
 

+ Version: 200
 

  Release: 1%{?dist}
 

  # No version specified.
 

  License: GPL+
 
@@ -214,6 +214,9 @@ 
 

  %{_rpmconfigdir}/macros.d/macros.kmp
 

  

  %changelog
 

+ * Wed Apr 27 2022 Miro Hrončok <mhroncok@redhat.com> - 200-1
 

+ - Backport the %%bcond macro from RPM 4.18+
 

+ 

  * Tue Sep 21 2021 Tom Stellard <tstellar@redhat.com> - 199-1
 

  - Drop annobin-plugin-clang dependency

no initial comment

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci

I'm not comfortable with this. First of all, it's too early to be backporting it to anything at all, and second, I think it should be backported inside rpm (and upstream maintenance release at that) rather than have it across different packages in different releases.

I wasn'T sure you would be willing to do that. Ok then.

Pull-Request has been closed by churchyard
2 years ago

As a general rule, if features are to be backported the best place to do so is via upstream maintenance releases as that way it'll benefit everybody and avoids fragmenting the ecosystem just that little bit. The issue tends to be more about what is considered backportable and to what: down to 4.16 this should be easy, but earlier than that it requires a huge bulk of macro engine related changes that is nothing like backportable.
Metadata
None
No Tags
Changes Summary 2
+7 -0
file changed
macros
+4 -1
file changed
redhat-rpm-config.spec
Powered by Pagure 5.13.3
Documentation • File an Issue • About this Instance • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.