rpms / redhat-rpm-config

Clone
Source Code
GIT

#206 Add macros.shell-completions
Merged 2 years ago by pmatilai. Opened 2 years ago by gotmax23.
rpms/ gotmax23/redhat-rpm-config rawhide  into  rawhide

file added
+3 
@@ -0,0 +1,3 @@ 
 

+ %bash_completions_dir   %{_datadir}/bash-completion/completions
 

+ %zsh_completions_dir    %{_datadir}/zsh/site-functions
 

+ %fish_completions_dir   %{_datadir}/fish/vendor_completions.d

file modified
+5 
@@ -48,6 +48,7 @@ 
 

  Source153: macros.forge
 

  Source155: macros.ldconfig
 

  Source156: macros.vpath
 

+ Source157: macros.shell-completions
 

  

  # Build policy scripts
 

  # this comes from https://github.com/rpm-software-management/rpm/pull/344
 
@@ -204,6 +205,7 @@ 
 

  %{_rpmconfigdir}/macros.d/macros.fedora-misc
 

  %{_rpmconfigdir}/macros.d/macros.forge
 

  %{_rpmconfigdir}/macros.d/macros.ldconfig
 

+ %{_rpmconfigdir}/macros.d/macros.shell-completions
 

  %{_rpmconfigdir}/macros.d/macros.vpath
 

  %dir %{_rpmluadir}/fedora
 

  %dir %{_rpmluadir}/fedora/srpm
 
@@ -219,6 +221,9 @@ 
 

  %doc buildflags.md
 

  

  %changelog
 

+ * Mon Aug 8 2022 Maxwell G <gotmax@e.email> - 228-1
 

+ - Add macros.shell-completions
 

+ 

  * Fri Aug 05 2022 Nikita Popov <npopov@redhat.com> - 227-1
 

  - brp-llvm-compile-lto-elf: Pass -r to xargs

This was discussed on the packaging mailing list1.

Build succeeded.

2 new commits added

  • Align specfile directives and remove Source numbers
  • Add macros.shell-completions
2 years ago

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci

recheck

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci

recheck

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci

This should be ready for review.

Build succeeded.

Friendly ping. Please let me know if I need to make any other changes here. This was discussed on the packaging mailing list, and there was general agreement about this.

NAK. Drop the "lets reformat the spec for fun" commit. That sort of thing is not welcome as an almost silent side-effect of adding a couple of new innocent macros.

NAK. Drop the "lets reformat the spec for fun" commit. That sort of thing is not welcome as an almost silent side-effect of adding a couple of new innocent macros.

Well, the reformatting was split up into a separate commit, but you're right that it would've been better as a separate PR or maybe not all. I'm a bit particular about formatting. I've dropped it.

rebased onto 72ddf0566f359dc46ddda0728a6ca37cb4c8b0b8
2 years ago

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci

rebased onto 483a3b8
2 years ago

Build succeeded.

I'm a bit particular about formatting. I've dropped it.

Aren't we all :sweat_smile: but not everybody prefers the indented style. Thanks.

Pull-Request has been merged by pmatilai
2 years ago

@pmatilai, do you mind if I build this and the f3{5,6} backports?

Sorry, this fell through the cracks. I certainly don't mind building this for rawhide, to be followed with backports if no surprises turn up. This being a simple macro addition there's not much potential for surprises, but following the principle never killed a kitten that I'm aware of, the contrary however...

Sorry, this fell through the cracks. I certainly don't mind building this for rawhide, to be followed with backports if no surprises turn up. This being a simple macro addition there's not much potential for surprises, but following the principle never killed a kitten that I'm aware of, the contrary however...

Alright, thanks! I'll go ahead and build this for rawhide and f37 (this was merged before branching). I guess we can merge the backports this later this week, assuming rawhide doesn't blow up (because of this :wink:).
Metadata
None
No Tags
Changes Summary 2
+3
file added
macros.shell-completions
+5 -0
file changed
redhat-rpm-config.spec
Powered by Pagure 5.13.3
Documentation • File an Issue • About this Instance • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.