|
![](https://seccdn.libravatar.org/avatar/01757ac6220c7c80daecba48378c2721a35cf00771becbb512a1ec0b1043f5ea?s=16&d=retro) |
51dd64e |
From 2aa02353663674a338c92fa4e72a0c0e529c410e Mon Sep 17 00:00:00 2001
|
|
![](https://seccdn.libravatar.org/avatar/01757ac6220c7c80daecba48378c2721a35cf00771becbb512a1ec0b1043f5ea?s=16&d=retro) |
51dd64e |
From: Enrico Guiraud <enrico.guiraud@cern.ch>
|
|
![](https://seccdn.libravatar.org/avatar/01757ac6220c7c80daecba48378c2721a35cf00771becbb512a1ec0b1043f5ea?s=16&d=retro) |
51dd64e |
Date: Fri, 8 Apr 2022 17:52:18 +0200
|
|
![](https://seccdn.libravatar.org/avatar/01757ac6220c7c80daecba48378c2721a35cf00771becbb512a1ec0b1043f5ea?s=16&d=retro) |
51dd64e |
Subject: [PATCH] [DF] Fix long int + Snapshot test on 32 bit platforms
|
|
![](https://seccdn.libravatar.org/avatar/01757ac6220c7c80daecba48378c2721a35cf00771becbb512a1ec0b1043f5ea?s=16&d=retro) |
2f8e3d9 |
|
|
![](https://seccdn.libravatar.org/avatar/01757ac6220c7c80daecba48378c2721a35cf00771becbb512a1ec0b1043f5ea?s=16&d=retro) |
51dd64e |
Co-authored-by: Mattias Ellert <mattias.ellert@physics.uu.se>
|
|
![](https://seccdn.libravatar.org/avatar/01757ac6220c7c80daecba48378c2721a35cf00771becbb512a1ec0b1043f5ea?s=16&d=retro) |
2f8e3d9 |
---
|
|
![](https://seccdn.libravatar.org/avatar/01757ac6220c7c80daecba48378c2721a35cf00771becbb512a1ec0b1043f5ea?s=16&d=retro) |
51dd64e |
tree/dataframe/test/dataframe_snapshot.cxx | 7 +++++--
|
|
![](https://seccdn.libravatar.org/avatar/01757ac6220c7c80daecba48378c2721a35cf00771becbb512a1ec0b1043f5ea?s=16&d=retro) |
51dd64e |
1 file changed, 5 insertions(+), 2 deletions(-)
|
|
![](https://seccdn.libravatar.org/avatar/01757ac6220c7c80daecba48378c2721a35cf00771becbb512a1ec0b1043f5ea?s=16&d=retro) |
2f8e3d9 |
|
|
![](https://seccdn.libravatar.org/avatar/01757ac6220c7c80daecba48378c2721a35cf00771becbb512a1ec0b1043f5ea?s=16&d=retro) |
2f8e3d9 |
diff --git a/tree/dataframe/test/dataframe_snapshot.cxx b/tree/dataframe/test/dataframe_snapshot.cxx
|
|
![](https://seccdn.libravatar.org/avatar/01757ac6220c7c80daecba48378c2721a35cf00771becbb512a1ec0b1043f5ea?s=16&d=retro) |
51dd64e |
index f41848e96a..ddbacaba0f 100644
|
|
![](https://seccdn.libravatar.org/avatar/01757ac6220c7c80daecba48378c2721a35cf00771becbb512a1ec0b1043f5ea?s=16&d=retro) |
2f8e3d9 |
--- a/tree/dataframe/test/dataframe_snapshot.cxx
|
|
![](https://seccdn.libravatar.org/avatar/01757ac6220c7c80daecba48378c2721a35cf00771becbb512a1ec0b1043f5ea?s=16&d=retro) |
2f8e3d9 |
+++ b/tree/dataframe/test/dataframe_snapshot.cxx
|
|
![](https://seccdn.libravatar.org/avatar/01757ac6220c7c80daecba48378c2721a35cf00771becbb512a1ec0b1043f5ea?s=16&d=retro) |
51dd64e |
@@ -495,11 +495,14 @@ void ReadWriteCarray(const char *outFileNameBase)
|
|
![](https://seccdn.libravatar.org/avatar/01757ac6220c7c80daecba48378c2721a35cf00771becbb512a1ec0b1043f5ea?s=16&d=retro) |
2f8e3d9 |
t.Branch("vb", vb, "vb[size]/O");
|
|
![](https://seccdn.libravatar.org/avatar/01757ac6220c7c80daecba48378c2721a35cf00771becbb512a1ec0b1043f5ea?s=16&d=retro) |
51dd64e |
t.Branch("vl", vl, "vl[size]/G");
|
|
![](https://seccdn.libravatar.org/avatar/01757ac6220c7c80daecba48378c2721a35cf00771becbb512a1ec0b1043f5ea?s=16&d=retro) |
2f8e3d9 |
|
|
![](https://seccdn.libravatar.org/avatar/01757ac6220c7c80daecba48378c2721a35cf00771becbb512a1ec0b1043f5ea?s=16&d=retro) |
51dd64e |
+ // use 2**33 as a larger-than-int value on 64 bits, otherwise just something larger than short (2**30)
|
|
![](https://seccdn.libravatar.org/avatar/01757ac6220c7c80daecba48378c2721a35cf00771becbb512a1ec0b1043f5ea?s=16&d=retro) |
51dd64e |
+ static constexpr long int longintTestValue = sizeof(long int) == 8 ? 8589934592 : 1073741824;
|
|
![](https://seccdn.libravatar.org/avatar/01757ac6220c7c80daecba48378c2721a35cf00771becbb512a1ec0b1043f5ea?s=16&d=retro) |
51dd64e |
+
|
|
![](https://seccdn.libravatar.org/avatar/01757ac6220c7c80daecba48378c2721a35cf00771becbb512a1ec0b1043f5ea?s=16&d=retro) |
2f8e3d9 |
// Size 1
|
|
![](https://seccdn.libravatar.org/avatar/01757ac6220c7c80daecba48378c2721a35cf00771becbb512a1ec0b1043f5ea?s=16&d=retro) |
2f8e3d9 |
size = 1;
|
|
![](https://seccdn.libravatar.org/avatar/01757ac6220c7c80daecba48378c2721a35cf00771becbb512a1ec0b1043f5ea?s=16&d=retro) |
51dd64e |
v[0] = 12;
|
|
![](https://seccdn.libravatar.org/avatar/01757ac6220c7c80daecba48378c2721a35cf00771becbb512a1ec0b1043f5ea?s=16&d=retro) |
51dd64e |
vb[0] = true;
|
|
![](https://seccdn.libravatar.org/avatar/01757ac6220c7c80daecba48378c2721a35cf00771becbb512a1ec0b1043f5ea?s=16&d=retro) |
51dd64e |
- vl[0] = 8589934592; // 2**33
|
|
![](https://seccdn.libravatar.org/avatar/01757ac6220c7c80daecba48378c2721a35cf00771becbb512a1ec0b1043f5ea?s=16&d=retro) |
51dd64e |
+ vl[0] = longintTestValue;
|
|
![](https://seccdn.libravatar.org/avatar/01757ac6220c7c80daecba48378c2721a35cf00771becbb512a1ec0b1043f5ea?s=16&d=retro) |
51dd64e |
t.Fill();
|
|
![](https://seccdn.libravatar.org/avatar/01757ac6220c7c80daecba48378c2721a35cf00771becbb512a1ec0b1043f5ea?s=16&d=retro) |
2f8e3d9 |
|
|
![](https://seccdn.libravatar.org/avatar/01757ac6220c7c80daecba48378c2721a35cf00771becbb512a1ec0b1043f5ea?s=16&d=retro) |
51dd64e |
// Size 0 (see ROOT-9860)
|
|
![](https://seccdn.libravatar.org/avatar/01757ac6220c7c80daecba48378c2721a35cf00771becbb512a1ec0b1043f5ea?s=16&d=retro) |
51dd64e |
@@ -546,7 +549,7 @@ void ReadWriteCarray(const char *outFileNameBase)
|
|
![](https://seccdn.libravatar.org/avatar/01757ac6220c7c80daecba48378c2721a35cf00771becbb512a1ec0b1043f5ea?s=16&d=retro) |
51dd64e |
EXPECT_EQ(rvb.GetSize(), 1u);
|
|
![](https://seccdn.libravatar.org/avatar/01757ac6220c7c80daecba48378c2721a35cf00771becbb512a1ec0b1043f5ea?s=16&d=retro) |
51dd64e |
EXPECT_TRUE(rvb[0]);
|
|
![](https://seccdn.libravatar.org/avatar/01757ac6220c7c80daecba48378c2721a35cf00771becbb512a1ec0b1043f5ea?s=16&d=retro) |
51dd64e |
EXPECT_EQ(rvl.GetSize(), 1u);
|
|
![](https://seccdn.libravatar.org/avatar/01757ac6220c7c80daecba48378c2721a35cf00771becbb512a1ec0b1043f5ea?s=16&d=retro) |
51dd64e |
- EXPECT_EQ(rvl[0], 8589934592);
|
|
![](https://seccdn.libravatar.org/avatar/01757ac6220c7c80daecba48378c2721a35cf00771becbb512a1ec0b1043f5ea?s=16&d=retro) |
51dd64e |
+ EXPECT_EQ(rvl[0], longintTestValue);
|
|
![](https://seccdn.libravatar.org/avatar/01757ac6220c7c80daecba48378c2721a35cf00771becbb512a1ec0b1043f5ea?s=16&d=retro) |
2f8e3d9 |
|
|
![](https://seccdn.libravatar.org/avatar/01757ac6220c7c80daecba48378c2721a35cf00771becbb512a1ec0b1043f5ea?s=16&d=retro) |
51dd64e |
// Size 0
|
|
![](https://seccdn.libravatar.org/avatar/01757ac6220c7c80daecba48378c2721a35cf00771becbb512a1ec0b1043f5ea?s=16&d=retro) |
51dd64e |
EXPECT_TRUE(r.Next());
|
|
![](https://seccdn.libravatar.org/avatar/01757ac6220c7c80daecba48378c2721a35cf00771becbb512a1ec0b1043f5ea?s=16&d=retro) |
2f8e3d9 |
--
|
|
![](https://seccdn.libravatar.org/avatar/01757ac6220c7c80daecba48378c2721a35cf00771becbb512a1ec0b1043f5ea?s=16&d=retro) |
2f8e3d9 |
2.35.1
|
|
![](https://seccdn.libravatar.org/avatar/01757ac6220c7c80daecba48378c2721a35cf00771becbb512a1ec0b1043f5ea?s=16&d=retro) |
2f8e3d9 |
|